Re: [PATCH v4 5/5] sched: rename SD_SHARE_PKG_RESOURCES to SD_SHARE_LLC

2024-02-08 Thread Ricardo Neri
uld reduce some confusing. > > Suggested-by: Valentin Schneider > Signed-off-by: Alex Shi FWIW, Reviewed-by: Ricardo Neri

Re: [PATCH v7 00/24] x86: Implement an HPET-based hardlockup detector

2023-04-12 Thread Ricardo Neri
On Wed, Mar 01, 2023 at 03:47:29PM -0800, Ricardo Neri wrote: > Hi x86 trusted reviewers, > > This is the seventh version of this patchset. I acknowledge that it took me > a long time to post a new version. Sorry! I will commit time to continue > working on this series with high

[PATCH v7 24/24] x86/tsc: Stop the HPET hardlockup detector if TSC become unstable

2023-03-01 Thread Ricardo Neri
hardlockup detector. Cc: Andi Kleen Cc: Stephane Eranian Cc: "Ravi V. Shankar" Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Suggested-by: Thomas Gleixner Reviewed-by: Tony Luck Signed-off-by: Ricardo Neri --- Changes since v6: * Do not switch to the perf

[PATCH v7 22/24] x86/watchdog: Add a shim hardlockup detector

2023-03-01 Thread Ricardo Neri
nuxppc-dev@lists.ozlabs.org Suggested-by: Nicholas Piggin Reviewed-by: Tony Luck Signed-off-by: Ricardo Neri --- Changes since v6: * None Changes since v5: * Added watchdog_nmi_start() to be used when the watchdog is reconfigured. * Always build the x86-specific hardlockup detector shim

[PATCH v7 20/24] x86/watchdog/hardlockup/hpet: Determine if HPET timer caused NMI

2023-03-01 Thread Ricardo Neri
)) 0.01550 155.020.00158 157.56 0.00020 117.74 Cc: Andi Kleen Cc: Stephane Eranian Cc: "Ravi V. Shankar" Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Suggested-by: Andi Kleen Reviewed-by: Tony Luck Signed-off-by: Ricardo Neri --- NOTE:

[PATCH v7 23/24] watchdog: Introduce hardlockup_detector_mark_unavailable()

2023-03-01 Thread Ricardo Neri
state of /proc/sys/kernel/ nmi_watchdog to keep it consistent. Cc: Andi Kleen Cc: Stephane Eranian Cc: "Ravi V. Shankar" Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Ricardo Neri --- Changes since v6: * Introduced this patch Changes since

[PATCH v7 21/24] watchdog/hardlockup/hpet: Only enable the HPET watchdog via a boot parameter

2023-03-01 Thread Ricardo Neri
: Stephane Eranian Cc: "Ravi V. Shankar" Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Reviewed-by: Tony Luck Signed-off-by: Ricardo Neri -- Changes since v6: * Do not reuse the nmi_watchdog command line option. Instead, use a separate command line option. (Nicho

[PATCH v7 18/24] init/main: Delay initialization of the lockup detector after smp_init()

2023-03-01 Thread Ricardo Neri
eviewed-by: Tony Luck Acked-by: Nicholas Piggin Signed-off-by: Ricardo Neri --- Changes since v6: * None Changes since v5: * Introduced this patch Changes since v4: * N/A Changes since v3: * N/A Changes since v2: * N/A Changes since v1: * N/A --- init/main.c | 4 +++- 1 file

[PATCH v7 19/24] x86/watchdog/hardlockup: Add an HPET-based hardlockup detector

2023-03-01 Thread Ricardo Neri
...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Reviewed-by: Tony Luck Signed-off-by: Ricardo Neri --- Changes since v6: * Added missing header asm/nmi.h. linux/nmi.h #includes it only if CONFIG_HAVE_NMI_WATCHDOG selected. Such option is not selected for ARCH=x86. * Removed

[PATCH v7 17/24] watchdog/hardlockup: Decouple the hardlockup detector from perf

2023-03-01 Thread Ricardo Neri
r" Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Reviewed-by: Tony Luck Signed-off-by: Ricardo Neri --- Changes since v6: * None Changes since v5: * None Changes since v4: * None Changes since v3: * Squashed into this patch a previous patch to make arch_tou

[PATCH v7 16/24] watchdog/hardlockup: Define a generic function to detect hardlockups

2023-03-01 Thread Ricardo Neri
Tony Luck Signed-off-by: Ricardo Neri --- Changes since v6: * None Changes since v5: * None Changes since v4: * None Changes since v3: * None Changes since v2: * None Changes since v1: * None --- include/linux/nmi.h | 1 + kernel/watchdog_hld.c | 18 +++--- 2 files c

[PATCH v7 15/24] x86/hpet: Reserve an HPET channel for the hardlockup detector

2023-03-01 Thread Ricardo Neri
Kleen Cc: Stephane Eranian Cc: "Ravi V. Shankar" Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Reviewed-by: Tony Luck Signed-off-by: Ricardo Neri --- Changes since v6: * Reworded the commit message for clarity. * Removed pointless global variable hld_data

[PATCH v7 14/24] x86/hpet: Prepare IRQ assignments to use the X86_ALLOC_AS_NMI flag

2023-03-01 Thread Ricardo Neri
" Cc: Stephane Eranian Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Suggested-by: Thomas Gleixner Reviewed-by: Tony Luck Signed-off-by: Ricardo Neri --- Changes since v6: * None Changes since v5: * Introduced this patch. Changes since v4: * N/A Changes since

[PATCH v7 12/24] x86/hpet: Expose hpet_writel() in header

2023-03-01 Thread Ricardo Neri
Tony Luck Signed-off-by: Ricardo Neri --- Changes since v6: * None Changes since v5: * None Changes since v4: * Dropped exposing hpet_readq() as it is not needed. Changes since v3: * None Changes since v2: * None Changes since v1: * None --- arch/x86/include/asm/hpet.h | 1 + arch/

[PATCH v7 10/24] iommu/amd: Enable NMIPass when allocating an NMI

2023-03-01 Thread Ricardo Neri
oerg Roedel Cc: Suravee Suthikulpanit Cc: Stephane Eranian Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Ricardo Neri --- Changes since v6: * Removed check for nr_irqs in irq_remapping_alloc(). Allocation had been rejected already in the root domain. (Thomas)

[PATCH v7 13/24] x86/hpet: Add helper function hpet_set_comparator_periodic()

2023-03-01 Thread Ricardo Neri
: Tony Luck Cc: Stephane Eranian Cc: "Ravi V. Shankar" Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Originally-by: Suravee Suthikulpanit Reviewed-by: Tony Luck Signed-off-by: Ricardo Neri --- When programming the HPET channel in periodic mode, a udelay(1) b

[PATCH v7 11/24] iommu/amd: Compose MSI messages for NMIs in non-IR format

2023-03-01 Thread Ricardo Neri
format. Let descendant irqchips write the composed message. Cc: Andi Kleen Cc: "Ravi V. Shankar" Cc: Joerg Roedel Cc: Suravee Suthikulpanit Cc: Stephane Eranian Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Ricardo Neri --- Changes since v6:

[PATCH v7 09/24] iommu/amd: Expose [set|get]_dev_entry_bit()

2023-03-01 Thread Ricardo Neri
ists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Ricardo Neri --- Changes since v6: * None Changes since v5: * Introduced this patch Changes since v4: * N/A Changes since v3: * N/A Changes since v2: * N/A Changes since v1: * N/A --- drivers/iommu/amd/amd_iommu.h | 3 ++

[PATCH v7 07/24] iommu/vt-d: Rework prepare_irte() to support per-interrupt delivery mode

2023-03-01 Thread Ricardo Neri
Kleen Cc: David Woodhouse Cc: "Ravi V. Shankar" Cc: Lu Baolu Cc: Stephane Eranian Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Cc: x...@kernel.org Reviewed-by: Ashok Raj Reviewed-by: Tony Luck Reviewed-by: Lu Baolu Signed-off-by: Ricardo Neri --- Change

[PATCH v7 08/24] iommu/vt-d: Set the IRTE delivery mode individually for each interrupt

2023-03-01 Thread Ricardo Neri
. Cc: Andi Kleen Cc: David Woodhouse Cc: "Ravi V. Shankar" Cc: Lu Baolu Cc: Stephane Eranian Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Reviewed-by: Tony Luck Reviewed-by: Lu Baolu Signed-off-by: Ricardo Neri --- Changes since v6: * None Change

[PATCH v7 06/24] iommu/vt-d: Clear the redirection hint when the destination mode is physical

2023-03-01 Thread Ricardo Neri
ion.org Cc: linuxppc-dev@lists.ozlabs.org Suggested-by: Ashok Raj Reviewed-by: Lu Baolu Signed-off-by: Ricardo Neri --- Changes since v6: * None Changes since v5: * Introduced this patch. Changes since v4: * N/A Changes since v3: * N/A Changes since v2: * N/A Changes since v1: * N/A --

[PATCH v7 04/24] x86/apic/vector: Implement a local APIC NMI controller

2023-03-01 Thread Ricardo Neri
nuxppc-dev@lists.ozlabs.org Suggested-by: Thomas Gleixner Signed-off-by: Ricardo Neri --- Changes since v6: * Reworked patch "x86/apic/vector: Implement support for NMI delivery mode" into a separate local APIC NMI controller. (Thomas) Changes since v5: * Introduced this patch. Chan

[PATCH v7 05/24] x86/apic/vector: Skip cleanup for the NMI vector

2023-03-01 Thread Ricardo Neri
The NMI vector is fixed. No cleanup is needed after updating affinity. Cc: Andi Kleen Cc: "Ravi V. Shankar" Cc: Stephane Eranian Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Ricardo Neri --- Changes since v6: * Introduced this patch. Cha

[PATCH v7 00/24] x86: Implement an HPET-based hardlockup detector

2023-03-01 Thread Ricardo Neri
201024213535.443185-6-dw...@infradead.org/ [10]. https://lore.kernel.org/lkml/20190623132340.463097...@linutronix.de/ Ricardo Neri (24): x86/apic: Add irq_cfg::delivery_mode x86/apic/msi: Use the delivery mode from irq_cfg for message composition x86/apic: Add the X86_IRQ_ALLOC_AS_NMI interrup

[PATCH v7 03/24] x86/apic: Add the X86_IRQ_ALLOC_AS_NMI interrupt allocation flag

2023-03-01 Thread Ricardo Neri
ozlabs.org Suggested-by: Thomas Gleixner Reviewed-by: Tony Luck Signed-off-by: Ricardo Neri --- Changes since v6: * None Changes since v5: * Introduced this patch. Changes since v4: * N/A Changes since v3: * N/A Changes since v2: * N/A Changes since v1: * N/A --- arch/x86/include/asm/irqdo

[PATCH v7 01/24] x86/apic: Add irq_cfg::delivery_mode

2023-03-01 Thread Ricardo Neri
Ashok Raj Reviewed-by: Tony Luck Signed-off-by: Ricardo Neri --- Changes since v6: * Reworded the commit message to accurately state that the root domain allocates a vector for an interrupt, not an interrupt. (Thomas) * Removed stray newline. (Thomas) * Replaced 'irq' with 'in

[PATCH v7 02/24] x86/apic/msi: Use the delivery mode from irq_cfg for message composition

2023-03-01 Thread Ricardo Neri
APIC_DELIVERY_MODE_FIXED. Cc: Andi Kleen Cc: "Ravi V. Shankar" Cc: Stephane Eranian Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Reviewed-by: Tony Luck Signed-off-by: Ricardo Neri --- Changes since v6: * Reworded changelog as per suggestion from Thomas. Change

Re: [PATCH v6 15/29] x86/hpet: Add helper function hpet_set_comparator_periodic()

2022-05-17 Thread Ricardo Neri
On Sat, May 14, 2022 at 10:17:38AM +0200, Thomas Gleixner wrote: > On Fri, May 13 2022 at 14:19, Ricardo Neri wrote: > > On Fri, May 06, 2022 at 11:41:13PM +0200, Thomas Gleixner wrote: > >> The argument about not bloating the code > >> with an "obvious???&q

Re: [PATCH v6 28/29] x86/tsc: Restart NMI watchdog after refining tsc_khz

2022-05-17 Thread Ricardo Neri
On Tue, May 10, 2022 at 01:44:05PM +0200, Thomas Gleixner wrote: > On Tue, May 10 2022 at 21:16, Nicholas Piggin wrote: > > Excerpts from Ricardo Neri's message of May 6, 2022 10:00 am: > >> + /* > >> + * If in use, the HPET hardlockup detector relies on tsc_khz. > >> + * Reconfigure it to mak

Re: [PATCH v6 28/29] x86/tsc: Restart NMI watchdog after refining tsc_khz

2022-05-17 Thread Ricardo Neri
c_khz. > > > > When the HPET hardlockup is not in use, restarting the NMI watchdog is > > a noop. > > > > Cc: Andi Kleen > > Cc: Stephane Eranian > > Cc: "Ravi V. Shankar" > > Cc: io...@lists.linux-foundation.org > > Cc: l

Re: [PATCH v6 21/29] x86/nmi: Add an NMI_WATCHDOG NMI handler category

2022-05-17 Thread Ricardo Neri
On Mon, May 09, 2022 at 03:59:40PM +0200, Thomas Gleixner wrote: > On Thu, May 05 2022 at 17:00, Ricardo Neri wrote: > > Add a NMI_WATCHDOG as a new category of NMI handler. This new category > > is to be used with the HPET-based hardlockup detector. This detector > > does not

Re: [PATCH v6 29/29] x86/tsc: Switch to perf-based hardlockup detector if TSC become unstable

2022-05-16 Thread Ricardo Neri
. Shankar" > > Cc: io...@lists.linux-foundation.org > > Cc: linuxppc-dev@lists.ozlabs.org > > Cc: x...@kernel.org > > Suggested-by: Thomas Gleixner > > Reviewed-by: Tony Luck > > Signed-off-by: Ricardo Neri > > --- > > Changes since v5: > > * Reloc

Re: [PATCH v6 05/29] x86/apic/vector: Do not allocate vectors for NMIs

2022-05-13 Thread Ricardo Neri
On Fri, May 13, 2022 at 10:50:09PM +0200, Thomas Gleixner wrote: > On Fri, May 13 2022 at 11:03, Ricardo Neri wrote: > > On Fri, May 06, 2022 at 11:12:20PM +0200, Thomas Gleixner wrote: > >> Why would a NMI ever end up in this code? There is no vector management > >>

Re: [PATCH v6 24/29] watchdog/hardlockup: Use parse_option_str() to handle "nmi_watchdog"

2022-05-13 Thread Ricardo Neri
On Tue, May 10, 2022 at 08:46:41PM +1000, Nicholas Piggin wrote: > Excerpts from Ricardo Neri's message of May 6, 2022 10:00 am: > > Prepare hardlockup_panic_setup() to handle a comma-separated list of > > options. Thus, it can continue parsing its own command-line options while > > ignoring parame

Re: [PATCH v6 20/29] init/main: Delay initialization of the lockup detector after smp_init()

2022-05-13 Thread Ricardo Neri
On Tue, May 10, 2022 at 08:38:22PM +1000, Nicholas Piggin wrote: > Excerpts from Ricardo Neri's message of May 6, 2022 9:59 am: > > Certain implementations of the hardlockup detector require support for > > Inter-Processor Interrupt shorthands. On x86, support for these can only > > be determined a

Re: [PATCH v6 22/29] x86/watchdog/hardlockup: Add an HPET-based hardlockup detector

2022-05-13 Thread Ricardo Neri
On Mon, May 09, 2022 at 04:03:39PM +0200, Thomas Gleixner wrote: > On Thu, May 05 2022 at 17:00, Ricardo Neri wrote: > > + if (is_hpet_hld_interrupt(hdata)) { > > + /* > > +* Kick the timer first. If the HPET channel is periodic, it > > +

Re: [PATCH v6 15/29] x86/hpet: Add helper function hpet_set_comparator_periodic()

2022-05-13 Thread Ricardo Neri
On Fri, May 06, 2022 at 11:51:52PM +0200, Thomas Gleixner wrote: > On Fri, May 06 2022 at 23:41, Thomas Gleixner wrote: > > On Thu, May 05 2022 at 16:59, Ricardo Neri wrote: > >> Programming an HPET channel as periodic requires setting the > >> HPET_TN_SETVAL bit in the

Re: [PATCH v6 15/29] x86/hpet: Add helper function hpet_set_comparator_periodic()

2022-05-13 Thread Ricardo Neri
On Fri, May 06, 2022 at 11:41:13PM +0200, Thomas Gleixner wrote: > On Thu, May 05 2022 at 16:59, Ricardo Neri wrote: > > Programming an HPET channel as periodic requires setting the > > HPET_TN_SETVAL bit in the channel configuration. Plus, the comparator > > register must b

Re: [PATCH v6 13/29] iommu/amd: Compose MSI messages for NMI irqs in non-IR format

2022-05-13 Thread Ricardo Neri
On Fri, May 06, 2022 at 11:31:56PM +0200, Thomas Gleixner wrote: > On Thu, May 05 2022 at 16:59, Ricardo Neri wrote: > > +* > > +* Also, NMIs do not have an associated vector. No need for cleanup. > > They have a vector and what the heck is this cleanup comment

Re: [PATCH v6 12/29] iommu/amd: Enable NMIPass when allocating an NMI irq

2022-05-13 Thread Ricardo Neri
On Fri, May 06, 2022 at 11:26:22PM +0200, Thomas Gleixner wrote: > On Thu, May 05 2022 at 16:59, Ricardo Neri wrote: > > > > + if (info->flags & X86_IRQ_ALLOC_AS_NMI) { > > + /* Only one IRQ per NMI */ > > + if (nr_irqs != 1) > > +

Re: [PATCH v6 10/29] iommu/vt-d: Implement minor tweaks for NMI irqs

2022-05-13 Thread Ricardo Neri
On Fri, May 06, 2022 at 11:23:23PM +0200, Thomas Gleixner wrote: > On Thu, May 05 2022 at 16:59, Ricardo Neri wrote: > > The Intel IOMMU interrupt remapping driver already programs correctly the > > delivery mode of individual irqs as per their irq_data. Improve handling > >

Re: [PATCH v6 05/29] x86/apic/vector: Do not allocate vectors for NMIs

2022-05-13 Thread Ricardo Neri
On Fri, May 06, 2022 at 11:12:20PM +0200, Thomas Gleixner wrote: > On Thu, May 05 2022 at 16:59, Ricardo Neri wrote: > > Vectors are meaningless when allocating IRQs with NMI as the delivery > > mode. > > Vectors are not meaningless. NMI has a fixed vector. > > Th

Re: [PATCH v6 03/29] x86/apic/msi: Set the delivery mode individually for each IRQ

2022-05-11 Thread Ricardo Neri
On Fri, May 06, 2022 at 10:05:34PM +0200, Thomas Gleixner wrote: > On Thu, May 05 2022 at 16:59, Ricardo Neri wrote: > > There are no restrictions in hardware to set MSI messages with its > > own delivery mode. > > "messages with its own" ? Plural/singular confu

Re: [PATCH v6 02/29] x86/apic: Add irq_cfg::delivery_mode

2022-05-11 Thread Ricardo Neri
On Fri, May 06, 2022 at 09:53:54PM +0200, Thomas Gleixner wrote: > On Thu, May 05 2022 at 16:59, Ricardo Neri wrote: > > Currently, the delivery mode of all interrupts is set to the mode of the > > APIC driver in use. There are no restrictions in hardware to configure the > >

Re: [PATCH v6 01/29] irq/matrix: Expose functions to allocate the best CPU for new vectors

2022-05-11 Thread Ricardo Neri
On Fri, May 06, 2022 at 09:48:28PM +0200, Thomas Gleixner wrote: > Ricardo, Thank you very much for your feedback Thomas! I am sorry for my late reply, I had been out of office. > > On Thu, May 05 2022 at 16:59, Ricardo Neri wrote: > > Certain types of interrupts, such as NMI,

[PATCH v6 29/29] x86/tsc: Switch to perf-based hardlockup detector if TSC become unstable

2022-05-05 Thread Ricardo Neri
: Andi Kleen Cc: Stephane Eranian Cc: "Ravi V. Shankar" Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Cc: x...@kernel.org Suggested-by: Thomas Gleixner Reviewed-by: Tony Luck Signed-off-by: Ricardo Neri --- Changes since v5: * Relocated the delc

[PATCH v6 28/29] x86/tsc: Restart NMI watchdog after refining tsc_khz

2022-05-05 Thread Ricardo Neri
nuxppc-dev@lists.ozlabs.org Cc: x...@kernel.org Signed-off-by: Ricardo Neri --- Changes since v5: * Introduced this patch Changes since v4 * N/A Changes since v3 * N/A Changes since v2: * N/A Changes since v1: * N/A --- arch/x86/kernel/tsc.c | 6 ++ 1 file changed, 6 insertions(+) diff --

[PATCH v6 27/29] watchdog: Expose lockup_detector_reconfigure()

2022-05-05 Thread Ricardo Neri
: Nicholas Piggin Cc: Stephane Eranian Cc: "Ravi V. Shankar" Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Cc: x...@kernel.org Reviewed-by: Tony Luck Signed-off-by: Ricardo Neri --- Changes since v5: * None Changes since v4: * Switching to the perf-based lockup dete

[PATCH v6 26/29] x86/watchdog: Add a shim hardlockup detector

2022-05-05 Thread Ricardo Neri
las Piggin Reviewed-by: Tony Luck Signed-off-by: Ricardo Neri --- Changes since v5: * Added watchdog_nmi_start() to be used when tsc_khz is recalibrated. * Always build the x86-specific hardlockup detector shim; not only when the HPET-based detector is selected. * Corrected a typo in

[PATCH v6 25/29] watchdog/hardlockup/hpet: Only enable the HPET watchdog via a boot parameter

2022-05-05 Thread Ricardo Neri
-line parsing using an early_param, as __setup("nmi_watchdog=") only parses generic options. Cc: Andi Kleen Cc: Stephane Eranian Cc: "Ravi V. Shankar" Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Cc: x...@kernel.org Reviewed-by: Tony Luck Signed-

[PATCH v6 24/29] watchdog/hardlockup: Use parse_option_str() to handle "nmi_watchdog"

2022-05-05 Thread Ricardo Neri
their own options. Cc: Andi Kleen Cc: Nicholas Piggin Cc: Stephane Eranian Cc: "Ravi V. Shankar" Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Cc: x...@kernel.org Reviewed-by: Tony Luck Signed-off-by: Ricardo Neri --- Changes since v5: * Corrected typo in comm

[PATCH v6 23/29] x86/watchdog/hardlockup/hpet: Determine if HPET timer caused NMI

2022-05-05 Thread Ricardo Neri
avi V. Shankar" Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Cc: x...@kernel.org Suggested-by: Andi Kleen Reviewed-by: Tony Luck Signed-off-by: Ricardo Neri --- NOTE: The error characterization data is repetead here from the cover letter. --- Changes since v5:

[PATCH v6 22/29] x86/watchdog/hardlockup: Add an HPET-based hardlockup detector

2022-05-05 Thread Ricardo Neri
: Andi Kleen Cc: Stephane Eranian Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Cc: x...@kernel.org Reviewed-by: Tony Luck Signed-off-by: Ricardo Neri --- Changes since v5: * Squashed a previously separate patch to support interrupt remapping into this patch. There is

[PATCH v6 21/29] x86/nmi: Add an NMI_WATCHDOG NMI handler category

2022-05-05 Thread Ricardo Neri
: "Ravi V. Shankar" Cc: Stephane Eranian Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Cc: x...@kernel.org Reviewed-by: Tony Luck Signed-off-by: Ricardo Neri --- Changes since v5: * Updated to call instrumentation_end() as per f051f6979550 ("x86/nmi: Pr

[PATCH v6 20/29] init/main: Delay initialization of the lockup detector after smp_init()

2022-05-05 Thread Ricardo Neri
.org Cc: x...@kernel.org Reviewed-by: Tony Luck Signed-off-by: Ricardo Neri --- Changes since v5: * Introduced this patch Changes since v4: * N/A Changes since v3: * N/A Changes since v2: * N/A Changes since v1: * N/A --- init/main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) di

[PATCH v6 19/29] watchdog/hardlockup: Decouple the hardlockup detector from perf

2022-05-05 Thread Ricardo Neri
r" Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Cc: x...@kernel.org Reviewed-by: Tony Luck Signed-off-by: Ricardo Neri --- Changes since v5: * None Changes since v4: * None Changes since v3: * Squashed into this patch a previous patch to make arch_touch_nmi_wat

[PATCH v6 18/29] watchdog/hardlockup: Define a generic function to detect hardlockups

2022-05-05 Thread Ricardo Neri
t; Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Cc: x...@kernel.org Reviewed-by: Tony Luck Signed-off-by: Ricardo Neri --- Changes since v5: * None Changes since v4: * None Changes since v3: * None Changes since v2: * None Changes since v1: * None --- include/l

[PATCH v6 17/29] x86/hpet: Reserve an HPET channel for the hardlockup detector

2022-05-05 Thread Ricardo Neri
detector if enabled in the kernel command line. Cc: Andi Kleen Cc: Stephane Eranian Cc: "Ravi V. Shankar" Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Cc: x...@kernel.org Reviewed-by: Tony Luck Signed-off-by: Ricardo Neri --- Changes since v5: * Added a che

[PATCH v6 16/29] x86/hpet: Prepare IRQ assignments to use the X86_ALLOC_AS_NMI flag

2022-05-05 Thread Ricardo Neri
reservation of a channel for it. Cc: Andi Kleen Cc: "Ravi V. Shankar" Cc: Stephane Eranian Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Cc: x...@kernel.org Suggested-by: Thomas Gleixner Reviewed-by: Tony Luck Signed-off-by: Ricardo Neri --- Changes since v5: *

[PATCH v6 15/29] x86/hpet: Add helper function hpet_set_comparator_periodic()

2022-05-05 Thread Ricardo Neri
ned-off-by: Ricardo Neri --- When programming the HPET channel in periodic mode, a udelay(1) between the two successive writes to HPET_Tn_CMP was introduced in commit e9e2cdb41241 ("[PATCH] clockevents: i386 drivers"). The commit message does not give any reason for such delay. The hardware sp

[PATCH v6 14/29] x86/hpet: Expose hpet_writel() in header

2022-05-05 Thread Ricardo Neri
kernel.org Reviewed-by: Tony Luck Signed-off-by: Ricardo Neri --- Changes since v5: * None Changes since v4: * Dropped exposing hpet_readq() as it is not needed. Changes since v3: * None Changes since v2: * None Changes since v1: * None --- arch/x86/include/asm/hpet.h | 1 + arch/x86/ker

[PATCH v6 13/29] iommu/amd: Compose MSI messages for NMI irqs in non-IR format

2022-05-05 Thread Ricardo Neri
rnel.org Signed-off-by: Ricardo Neri --- Changes since v5: * Introduced this patch Changes since v4: * N/A Changes since v3: * N/A Changes since v2: * N/A Changes since v1: * N/A --- drivers/iommu/amd/iommu.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-

[PATCH v6 12/29] iommu/amd: Enable NMIPass when allocating an NMI irq

2022-05-05 Thread Ricardo Neri
uot; Cc: Joerg Roedel Cc: Suravee Suthikulpanit Cc: Stephane Eranian Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Cc: x...@kernel.org Signed-off-by: Ricardo Neri --- Changes since v5: * Introduced this patch Changes since v4: * N/A Changes since v3: * N/A Changes s

[PATCH v6 11/29] iommu/amd: Expose [set|get]_dev_entry_bit()

2022-05-05 Thread Ricardo Neri
nuxppc-dev@lists.ozlabs.org Cc: x...@kernel.org Signed-off-by: Ricardo Neri --- Changes since v5: * Introduced this patch Changes since v4: * N/A Changes since v3: * N/A Changes since v2: * N/A Changes since v1: * N/A --- drivers/iommu/amd/amd_iommu.h | 3 +++ drivers/iommu/amd/init.

[PATCH v6 10/29] iommu/vt-d: Implement minor tweaks for NMI irqs

2022-05-05 Thread Ricardo Neri
: Andi Kleen Cc: David Woodhouse Cc: "Ravi V. Shankar" Cc: Lu Baolu Cc: Stephane Eranian Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Cc: x...@kernel.org Reviewed-by: Lu Baolu Signed-off-by: Ricardo Neri --- Changes since v5: * Introduced this patch. Cha

[PATCH v6 09/29] iommu/vt-d: Set the IRTE delivery mode individually for each IRQ

2022-05-05 Thread Ricardo Neri
specific delivery mode. Cc: Andi Kleen Cc: David Woodhouse Cc: "Ravi V. Shankar" Cc: Lu Baolu Cc: Stephane Eranian Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Cc: x...@kernel.org Reviewed-by: Tony Luck Reviewed-by: Lu Baolu Signed-off-by: Ricardo Neri -

[PATCH v6 08/29] iommu/vt-d: Rework prepare_irte() to support per-IRQ delivery mode

2022-05-05 Thread Ricardo Neri
functional changes. Cc: Andi Kleen Cc: David Woodhouse Cc: "Ravi V. Shankar" Cc: Lu Baolu Cc: Stephane Eranian Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Cc: x...@kernel.org Reviewed-by: Ashok Raj Reviewed-by: Tony Luck Reviewed-by: Lu Baolu Signed-off-by: Ri

[PATCH v6 07/29] iommu/vt-d: Clear the redirection hint when the destination mode is physical

2022-05-05 Thread Ricardo Neri
ists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Cc: x...@kernel.org Suggested-by: Ashok Raj Reviewed-by: Lu Baolu Signed-off-by: Ricardo Neri --- Changes since v5: * Introduced this patch. Changes since v4: * N/A Changes since v3: * N/A Changes since v2: * N/A Changes since

[PATCH v6 06/29] x86/apic/vector: Implement support for NMI delivery mode

2022-05-05 Thread Ricardo Neri
using the delivery mode of the APIC driver in use. Cc: Andi Kleen Cc: "Ravi V. Shankar" Cc: Stephane Eranian Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Cc: x...@kernel.org Suggested-by: Thomas Gleixner Reviewed-by: Tony Luck Signed-off-by: Ricardo Neri -

[PATCH v6 05/29] x86/apic/vector: Do not allocate vectors for NMIs

2022-05-05 Thread Ricardo Neri
Kleen Cc: "Ravi V. Shankar" Cc: Stephane Eranian Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Cc: x...@kernel.org Reviewed-by: Tony Luck Signed-off-by: Ricardo Neri --- Changes since v5: * Introduced this patch. Changes since v4: * N/A Changes since

[PATCH v6 04/29] x86/apic: Add the X86_IRQ_ALLOC_AS_NMI irq allocation flag

2022-05-05 Thread Ricardo Neri
.org Cc: x...@kernel.org Suggested-by: Thomas Gleixner Reviewed-by: Tony Luck Signed-off-by: Ricardo Neri --- Changes since v5: * Introduced this patch. Changes since v4: * N/A Changes since v3: * N/A Changes since v2: * N/A Changes since v1: * N/A --- arch/x86/include/asm/irqdomain.h | 1

[PATCH v6 03/29] x86/apic/msi: Set the delivery mode individually for each IRQ

2022-05-05 Thread Ricardo Neri
ion.org Cc: linuxppc-dev@lists.ozlabs.org Cc: x...@kernel.org Reviewed-by: Tony Luck Signed-off-by: Ricardo Neri --- Changes since v5: * Introduced this patch Changes since v4: * N/A Changes since v3: * N/A Changes since v2: * N/A Changes since v1: * N/A --- arch/x86/kernel/apic/apic.c | 2

[PATCH v6 02/29] x86/apic: Add irq_cfg::delivery_mode

2022-05-05 Thread Ricardo Neri
that of the APIC driver. Cc: Andi Kleen Cc: "Ravi V. Shankar" Cc: Stephane Eranian Cc: io...@lists.linux-foundation.org Cc: linuxppc-dev@lists.ozlabs.org Cc: x...@kernel.org Reviewed-by: Ashok Raj Reviewed-by: Tony Luck Signed-off-by: Ricardo Neri --- Changes since v5: * Updated i

[PATCH v6 01/29] irq/matrix: Expose functions to allocate the best CPU for new vectors

2022-05-05 Thread Ricardo Neri
d-by: Tony Luck Signed-off-by: Ricardo Neri --- Changes since v5: * Introduced this patch. Changes since v4: * N/A Changes since v3: * N/A Changes since v2: * N/A Changes since v1: * N/A --- include/linux/irq.h | 4 kernel/irq/matrix.c | 32 +++- 2 files c

[PATCH v6 00/29] x86: Implement an HPET-based hardlockup detector

2022-05-05 Thread Ricardo Neri
adead.org https://lore.kernel.org/all/tip-dea978632e8400b84888bad20df0cd91c18f0...@git.kernel.org/t/ [13]. https://lore.kernel.org/lkml/20190623132340.463097...@linutronix.de/ Ricardo Neri (29): irq/matrix: Expose functions to allocate the best CPU for new vectors x86/apic: Add irq_cfg::deli

Re: [PATCH v5 6/6] sched/fair: Consider SMT in ASYM_PACKING load balance

2021-10-01 Thread Ricardo Neri
s: > > revert: PASS > > verify: PASS > > > > Parameters: > > Tree: next > > URL: > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > > Branch: master > > Target: rk3328-rock64 > > CPU arch: arm64 > > Lab:lab-

Re: [PATCH v5 6/6] sched/fair: Consider SMT in ASYM_PACKING load balance

2021-09-16 Thread Ricardo Neri
On Wed, Sep 15, 2021 at 05:43:44PM +0200, Vincent Guittot wrote: > On Sat, 11 Sept 2021 at 03:19, Ricardo Neri > wrote: > > > > When deciding to pull tasks in ASYM_PACKING, it is necessary not only to > > check for the idle state of the destination CPU, dst_cpu, but also

[PATCH v5 6/6] sched/fair: Consider SMT in ASYM_PACKING load balance

2021-09-10 Thread Ricardo Neri
: Srinivas Pandruvada Cc: Steven Rostedt Cc: Tim Chen Reviewed-by: Joel Fernandes (Google) Reviewed-by: Len Brown Signed-off-by: Ricardo Neri --- Changes since v4: * Use sg_lb_stats::sum_nr_running the idle state of a scheduling group. (Vincent, Peter) * Do not even idle CPUs in

[PATCH v5 4/6] sched/fair: Provide update_sg_lb_stats() with sched domain statistics

2021-09-10 Thread Ricardo Neri
Cc: Tim Chen Reviewed-by: Joel Fernandes (Google) Reviewed-by: Len Brown Originally-by: Peter Zijlstra (Intel) Signed-off-by: Peter Zijlstra (Intel) Signed-off-by: Ricardo Neri --- Changes since v4: * None Changes since v3: * None Changes since v2: * Introduced this patch. Changes

[PATCH v5 3/6] sched/fair: Optimize checking for group_asym_packing

2021-09-10 Thread Ricardo Neri
Eggemann Cc: Mel Gorman Cc: Quentin Perret Cc: Rafael J. Wysocki Cc: Srinivas Pandruvada Cc: Steven Rostedt Cc: Tim Chen Reviewed-by: Joel Fernandes (Google) Reviewed-by: Len Brown Signed-off-by: Ricardo Neri --- Changes since v4: * None Changes since v3: * Further rewording of the

[PATCH v5 2/6] sched/topology: Introduce sched_group::flags

2021-09-10 Thread Ricardo Neri
Cc: Quentin Perret Cc: Rafael J. Wysocki Cc: Srinivas Pandruvada Cc: Steven Rostedt Cc: Tim Chen Reviewed-by: Joel Fernandes (Google) Reviewed-by: Len Brown Originally-by: Peter Zijlstra (Intel) Signed-off-by: Peter Zijlstra (Intel) Signed-off-by: Ricardo Neri --- Changes since v4

[PATCH v5 1/6] x86/sched: Decrease further the priorities of SMT siblings

2021-09-10 Thread Ricardo Neri
Fernandes (Google) Cc: Mel Gorman Cc: Quentin Perret Cc: Rafael J. Wysocki Cc: Srinivas Pandruvada Cc: Steven Rostedt Cc: Tim Chen Originally-by: Len Brown Signed-off-by: Len Brown Signed-off-by: Ricardo Neri --- Changes since v4: * None Changes since v3: * Introduced this patch Changes

Re: [PATCH v4 6/6] sched/fair: Consider SMT in ASYM_PACKING load balance

2021-08-27 Thread Ricardo Neri
On Fri, Aug 27, 2021 at 12:13:42PM +0200, Vincent Guittot wrote: > On Tue, 10 Aug 2021 at 16:41, Ricardo Neri > wrote: > > @@ -9540,6 +9629,12 @@ static struct rq *find_busiest_queue(struct lb_env > > *env, > > nr_running == 1) > >

Re: [PATCH v4 6/6] sched/fair: Consider SMT in ASYM_PACKING load balance

2021-08-27 Thread Ricardo Neri
On Fri, Aug 27, 2021 at 05:17:22PM +0200, Vincent Guittot wrote: > On Fri, 27 Aug 2021 at 16:50, Peter Zijlstra wrote: > > > > On Fri, Aug 27, 2021 at 12:13:42PM +0200, Vincent Guittot wrote: > > > > +/** > > > > + * asym_smt_can_pull_tasks - Check whether the load balancing CPU can > > > > pull

[PATCH v4 6/6] sched/fair: Consider SMT in ASYM_PACKING load balance

2021-08-10 Thread Ricardo Neri
: Srinivas Pandruvada Cc: Steven Rostedt Cc: Tim Chen Reviewed-by: Joel Fernandes (Google) Reviewed-by: Len Brown Signed-off-by: Ricardo Neri --- Changes since v3: * Removed the arch_asym_check_smt_siblings() hook. Discussions with the powerpc folks showed that this patch should not impact

[PATCH v4 4/6] sched/fair: Provide update_sg_lb_stats() with sched domain statistics

2021-08-10 Thread Ricardo Neri
Cc: Tim Chen Reviewed-by: Joel Fernandes (Google) Reviewed-by: Len Brown Originally-by: Peter Zijlstra (Intel) Signed-off-by: Peter Zijlstra (Intel) Signed-off-by: Ricardo Neri --- Changes since v3: * None Changes since v2: * Introduced this patch. Changes since v1: * N/A --- kernel

[PATCH v4 3/6] sched/fair: Optimize checking for group_asym_packing

2021-08-10 Thread Ricardo Neri
Eggemann Cc: Mel Gorman Cc: Quentin Perret Cc: Rafael J. Wysocki Cc: Srinivas Pandruvada Cc: Steven Rostedt Cc: Tim Chen Reviewed-by: Joel Fernandes (Google) Reviewed-by: Len Brown Signed-off-by: Ricardo Neri --- Changes since v3: * Further rewording of the commit message. (Len

[PATCH v4 2/6] sched/topology: Introduce sched_group::flags

2021-08-10 Thread Ricardo Neri
Cc: Quentin Perret Cc: Rafael J. Wysocki Cc: Srinivas Pandruvada Cc: Steven Rostedt Cc: Tim Chen Reviewed-by: Joel Fernandes (Google) Reviewed-by: Len Brown Originally-by: Peter Zijlstra (Intel) Signed-off-by: Peter Zijlstra (Intel) Signed-off-by: Ricardo Neri --- Changes since v3

[PATCH v4 1/6] x86/sched: Decrease further the priorities of SMT siblings

2021-08-10 Thread Ricardo Neri
Fernandes (Google) Cc: Mel Gorman Cc: Quentin Perret Cc: Rafael J. Wysocki Cc: Srinivas Pandruvada Cc: Steven Rostedt Cc: Tim Chen Originally-by: Len Brown Signed-off-by: Len Brown Signed-off-by: Ricardo Neri --- Changes since v3: * Introduced this patch Changes since v2: * N/A Changes

[PATCH v4 0/6] sched/fair: Fix load balancing of SMT siblings with ASYM_PACKING

2021-08-10 Thread Ricardo Neri
== [1]. https://lore.kernel.org/lkml/20210406041108.7416-1-ricardo.neri-calde...@linux.intel.com/ [2]. https://lore.kernel.org/lkml/20210414020436.12980-1-ricardo.neri-calde...@linux.intel.com/ [3]. https://lore.kernel.org/lkml/20210513154909.6385-1-ricardo.neri-calde...@linux.intel.com/ Ri

[PATCH v4 5/6] sched/fair: Carve out logic to mark a group for asymmetric packing

2021-08-10 Thread Ricardo Neri
Zijlstra (Intel) Signed-off-by: Ricardo Neri --- Changes since v3: * Remove a redundant check for the local group in sched_asym(). (Dietmar) * Reworded commit message for clarity. (Len) Changes since v2: * Introduced this patch. Changes since v1: * N/A --- kernel/sched/fair.c | 20

Re: [PATCH v3 5/6] sched/fair: Consider SMT in ASYM_PACKING load balance

2021-05-18 Thread Ricardo Neri
On Fri, May 14, 2021 at 07:14:15PM -0700, Ricardo Neri wrote: > On Fri, May 14, 2021 at 11:47:45AM +0200, Peter Zijlstra wrote: > > On Thu, May 13, 2021 at 08:49:08AM -0700, Ricardo Neri wrote: > > > include/linux/sched/topology.h | 1 + > > > kernel/sc

[RFC PATCH v5 15/16] watchdog: Expose lockup_detector_reconfigure()

2021-05-04 Thread Ricardo Neri
ranian Cc: Suravee Suthikulpanit Cc: "Ravi V. Shankar" Cc: x...@kernel.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Ricardo Neri --- Changes since v4: * Switching to the perf-based lockup detector under the hood is hacky. Instead, reconfigure the whole lockup detector. Chang

[RFC PATCH v5 12/16] watchdog/hardlockup: Use parse_option_str() to handle "nmi_watchdog"

2021-05-04 Thread Ricardo Neri
their own options. Cc: "H. Peter Anvin" Cc: Ashok Raj Cc: Andi Kleen Cc: Tony Luck Cc: Nicholas Piggin Cc: Peter Zijlstra Cc: Andrew Morton Cc: Stephane Eranian Cc: Suravee Suthikulpanit Cc: "Ravi V. Shankar" Cc: x...@kernel.org Cc: linuxppc-dev@lists.ozlabs.org Signed-

[RFC PATCH v5 05/16] watchdog/hardlockup: Decouple the hardlockup detector from perf

2021-05-04 Thread Ricardo Neri
er Zijlstra Cc: Andrew Morton Cc: Stephane Eranian Cc: Suravee Suthikulpanit Cc: "Ravi V. Shankar" Cc: x...@kernel.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Ricardo Neri --- Changes since v4: * None Changes since v3: * Squashed into this patch a previous patch to make

[RFC PATCH v5 04/16] watchdog/hardlockup: Define a generic function to detect hardlockups

2021-05-04 Thread Ricardo Neri
Morton Cc: Stephane Eranian Cc: Suravee Suthikulpanit Cc: "Ravi V. Shankar" Cc: x...@kernel.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Ricardo Neri --- Changes since v4: * None Changes since v3: * None Changes since v2: * None Changes since v1: * None --- includ

[RFC PATCH v4 10/21] watchdog/hardlockup: Add function to enable NMI watchdog on all allowed CPUs at once

2019-05-23 Thread Ricardo Neri
Cc: Kai-Heng Feng Cc: Konrad Rzeszutek Wilk Cc: David Rientjes Cc: Stephane Eranian Cc: Suravee Suthikulpanit Cc: "Ravi V. Shankar" Cc: x...@kernel.org Cc: sparcli...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Ricardo Neri --- include/linux/nmi.h | 2 ++ k

[RFC PATCH v4 08/21] watchdog/hardlockup: Decouple the hardlockup detector from perf

2019-05-23 Thread Ricardo Neri
tephane Eranian Cc: Suravee Suthikulpanit Cc: "Ravi V. Shankar" Cc: x...@kernel.org Cc: sparcli...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Ricardo Neri --- include/linux/nmi.h | 5 - kernel/Makefile | 2 +- kernel/watchdog_hld.c | 32 +

[RFC PATCH v4 07/21] watchdog/hardlockup: Define a generic function to detect hardlockups

2019-05-23 Thread Ricardo Neri
Stephane Eranian Cc: Suravee Suthikulpanit Cc: "Ravi V. Shankar" Cc: x...@kernel.org Cc: sparcli...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Ricardo Neri --- include/linux/nmi.h | 1 + kernel/watchdog_hld.c | 18 +++--- 2 files changed, 12 insertions(

[RFC PATCH v3 10/21] watchdog/hardlockup: Add function to enable NMI watchdog on all allowed CPUs at once

2019-05-14 Thread Ricardo Neri
Cc: Kai-Heng Feng Cc: Konrad Rzeszutek Wilk Cc: David Rientjes Cc: Stephane Eranian Cc: Suravee Suthikulpanit Cc: "Ravi V. Shankar" Cc: x...@kernel.org Cc: sparcli...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Ricardo Neri --- include/linux/nmi.h | 2 ++ k

  1   2   >