Re: [PATCH] ehea: Fix: Remove adapter from adapter list in error path

2009-02-11 Thread Stefan Richter
apparently unsafely. There may be other unsafe accesses of adapter_list; that's just the first one which I spotted. -- Stefan Richter -=-==--= --=- -=-== http://arcgraph.de/sr/ ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org

dma_alloc_coherent() on PPC32: physical addresses above 2G possible?

2008-07-20 Thread Stefan Richter
be detrimental to other functions of the device. It's a TI TSB43AB22A FireWire controller. -- Stefan Richter -=-==--- -=== =-=-- http://arcgraph.de/sr/ ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc

Re: dma_alloc_coherent() on PPC32: physical addresses above 2G possible?

2008-07-20 Thread Stefan Richter
Arjan van de Ven wrote: On Sun, 20 Jul 2008 20:36:23 +0200 Stefan Richter [EMAIL PROTECTED] wrote: PS: I don't want to set the DMA mask of this device to DMA_31BIT_MASK because that would be detrimental to other functions of the device. It's a TI TSB43AB22A FireWire controller. Hi

Re: dma_alloc_coherent() on PPC32: physical addresses above 2G possible?

2008-07-20 Thread Stefan Richter
Arjan van de Ven wrote: On Sun, 20 Jul 2008 21:25:51 +0200 Stefan Richter [EMAIL PROTECTED] wrote: if (dev-needs_dma_mask_workaround) pci_set_consistent_dma_mask(pdev, DMA_31BIT_MASK); allocate_something_special; if (dev-needs_dma_mask_workaround

Re: [PATCH 1/2] firewire: endianess fix

2008-03-05 Thread Stefan Richter
and everything works, including suspend to RAM. The kernel is 2.6.25-rc4 plus additional pull from linux1394-2.6.git: 2.6.25-rc4-00032-g8d36ba4. That's great. Thanks for testing. -- Stefan Richter -=-==--- --== --==- http://arcgraph.de/sr

Re: [PATCH 1/2] firewire: endianess fix

2008-03-03 Thread Stefan Richter
patches... in theory. I wouldn't be surprised of until now unreported bugs or old reported but forgotten bugs though. -- Stefan Richter -=-==--- --== ---== http://arcgraph.de/sr/ ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org

Re: [PATCH 1/3] firewire: fw-ohci: PPC PMac platform code

2008-03-01 Thread Stefan Richter
with ohci1394. Why did nobody ever complain? I suppose the last two users of FireWire + Linux + UniNorth rev01 don't use cable power or don't suspend and resume. -- Stefan Richter -=-==--- --== = http://arcgraph.de/sr/ ___ Linuxppc-dev mailing

Re: [PATCH 3/3] firewire: fw-ohci: shut up false compiler warning on PPC32

2008-03-01 Thread Stefan Richter
Stephen Rothwell wrote: On Sat, 1 Mar 2008 02:50:44 +0100 (CET) Stefan Richter [EMAIL PROTECTED] wrote: Wasn't there a macro somewhere for this? Yes, uninitialized_var() in linux/compiler*.h Right. I actually did look into compiler.h and compiler-gcc.h but somehow didn't make it down

[PATCH 3/3 update] firewire: fw-ohci: shut up false compiler warning on PPC32

2008-03-01 Thread Stefan Richter
Shut up two may be used uninitialised in this function warnings due to PPC32's implementation of dma_alloc_coherent(). Signed-off-by: Stefan Richter [EMAIL PROTECTED] --- drivers/firewire/fw-ohci.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: linux-2.6.25-rc3/drivers

[PATCH 2/4] firewire: fw-ohci: refactor probe, remove, suspend, resume

2008-03-01 Thread Stefan Richter
Clean up shared code and variable names. Signed-off-by: Stefan Richter [EMAIL PROTECTED] --- drivers/firewire/fw-ohci.c | 100 ++--- 1 file changed, 42 insertions(+), 58 deletions(-) Index: linux/drivers/firewire/fw-ohci.c

[PATCH 1/4] firewire: fw-ohci: switch on bus power after resume on PPC PMac

2008-03-01 Thread Stefan Richter
-off-by: Stefan Richter [EMAIL PROTECTED] --- drivers/firewire/fw-ohci.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) Index: linux/drivers/firewire/fw-ohci.c === --- linux.orig/drivers/firewire/fw-ohci.c +++ linux

[PATCH 4/4] ieee1394: ohci1394: refactor probe, remove, suspend, resume

2008-03-01 Thread Stefan Richter
Clean up shared code and variable names. Signed-off-by: Stefan Richter [EMAIL PROTECTED] --- drivers/ieee1394/ohci1394.c | 113 +++- 1 file changed, 49 insertions(+), 64 deletions(-) Index: linux/drivers/ieee1394/ohci1394.c

Re: [PATCH 1/2] firewire: endianess fix

2008-03-01 Thread Stefan Richter
by default. However, this endianess bug was low-profile because there are currently no kernelspace or userspace drivers for the firewire stack which need to respond in split transactions. -- Stefan Richter -=-==--- --== = http://arcgraph.de/sr

Re: [PATCH 1/2] firewire: endianess fix

2008-02-29 Thread Stefan Richter
. On the weekend I'm going to attempt to put Linux on this PowerBook, at last. -- Stefan Richter -=-==--- --=- ===-= http://arcgraph.de/sr/ ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

[PATCH 0/3] firewire: PPC PMac updates

2008-02-29 Thread Stefan Richter
Next up: 1/3 firewire: fw-ohci: PPC PMac platform code 2/3 firewire: fw-ohci: Apple UniNorth 1st generation support 3/3 firewire: fw-ohci: shut up false compiler warning on PPC32 -- Stefan Richter -=-==--- --== = http://arcgraph.de/sr

[PATCH 1/3] firewire: fw-ohci: PPC PMac platform code

2008-02-29 Thread Stefan Richter
Copied from ohci1394.c. This code is necessary to prevent machine check exceptions when reloading or resuming the driver. Signed-off-by: Stefan Richter [EMAIL PROTECTED] --- drivers/firewire/fw-ohci.c | 50 + 1 file changed, 50 insertions(+) Index

[PATCH 2/3] firewire: fw-ohci: Apple UniNorth 1st generation support

2008-02-29 Thread Stefan Richter
Mostly copied from ohci1394.c. Necessary for some older Macs, e.g. PowerBook G3 Pismo and early PowerBook G4 Titanium. Signed-off-by: Stefan Richter [EMAIL PROTECTED] --- Since my TiBook has a broken FireWire PHY I was only able to test the byte order of self ID packets but not of the headers

[PATCH 3/3] firewire: fw-ohci: shut up false compiler warning on PPC32

2008-02-29 Thread Stefan Richter
Shut up two may be used uninitialised in this function warnings due to PPC32's implementation of dma_alloc_coherent(). Signed-off-by: Stefan Richter [EMAIL PROTECTED] --- Wasn't there a macro somewhere for this? Also, could this be better done in PPC32's dma_alloc_coherent()? At least this kind

Re: [PATCH 1/3] firewire: fw-ohci: PPC PMac platform code

2008-02-29 Thread Stefan Richter
I wrote: + struct device_node* ofn = pci_device_to_OF_node(dev); -ECOPYANDWASTE: struct device_node *ofn -- Stefan Richter -=-==--- --== = http://arcgraph.de/sr/ ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https

Re: [PATCH 1/2] firewire: endianess fix

2008-02-27 Thread Stefan Richter
Jarod Wilson wrote: Works just fine with the Apple UniNorth controller in my powerbook in cursory testing. Could you remove the OHCI1394_HCControl_postedWriteEnable flag from fw-ohci.c::ohci_enable() and test without and with the endianess patch? -- Stefan Richter

[PATCH 2/2] firewire: endianess annotations

2008-02-23 Thread Stefan Richter
-by: Stefan Richter [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] Cc: linuxppc-dev@ozlabs.org --- drivers/firewire/fw-ohci.c|4 ++-- drivers/firewire/fw-transaction.c |2 +- drivers/firewire/fw-transaction.h |6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) Index: linux/drivers

[PATCH 1/2] firewire: endianess fix

2008-02-23 Thread Stefan Richter
The generation of incoming requests was filled in in wrong byte order on machines with big endian CPU. Signed-off-by: Stefan Richter [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] Cc: linuxppc-dev@ozlabs.org --- This patch is a shot in the dark, based on a warning when building with C=1 CHECKFLAGS

Re: [PATCH 1/2] firewire: endianess fix

2008-02-23 Thread Stefan Richter
unified transactions, hence this test needs to be performed with other bridge chips.) -- Stefan Richter -=-==--- --=- =-=== http://arcgraph.de/sr/ ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: Sleep problems with kernels = 2.6.21 on powerpc

2007-09-05 Thread Stefan Richter
in this incident: I don't read all posts on LKML. But I typically catch everything where I am in the CC list thanks to the wonders of sieve. Andrew, thanks for putting me in the CCs. -- Stefan Richter -=-=-=== =--= --=-= http://arcgraph.de/sr

Re: Sleep problems with kernels = 2.6.21 on powerpc

2007-09-05 Thread Stefan Richter
would like to get the bug fixed :-) A trivial post -rc1 compatible fix is coming in a minute. -- Stefan Richter -=-=-=== =--= --=-= http://arcgraph.de/sr/ ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo

[PATCH] Re: Sleep problems with kernels = 2.6.21 on powerpc

2007-09-05 Thread Stefan Richter
From: Stefan Richter [EMAIL PROTECTED] Subject: firewire: fw-ohci: ignore failure of pci_set_power_state (fix suspend regression) Fixes Sleep problems with kernels = 2.6.21 on powerpc, http://lkml.org/lkml/2007/8/25/155. Like it was suggested earlier in http://lkml.org/lkml/2006/10/24/13, we do

Re: [PATCH] Re: Sleep problems with kernels = 2.6.21 on powerpc

2007-09-05 Thread Stefan Richter
don't work after resume unless you unload and reload the drivers. - The version in -mm restores everything but panics soon after resume on an APM notebook in combination with some SBP-2 targets. I have yet to try netconsole or so to gather more information. -- Stefan Richter

firewire in prebuilt kernel packages (was Re: Sleep problems with kernels = 2.6.21 on powerpc)

2007-09-05 Thread Stefan Richter
at http://wiki.linux1394.org/JujuMigration. -- Stefan Richter -=-=-=== =--= --=-= http://arcgraph.de/sr/ ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: Sleep problems with kernels = 2.6.21 on powerpc

2007-09-05 Thread Stefan Richter
On 5 Sep, Andrew Morton wrote: On Wed, 05 Sep 2007 19:47:42 +0200 Stefan Richter [EMAIL PROTECTED] wrote: Trying to free already-free IRQ 40 pci_set_power_state(): 0002:20:0e.0: state=3, current state=5 firewire_ohci: pci_set_power_state failed with -223pci_device_suspend(): pci_suspend

Re: [PATCH 2.6.22.y] ieee1394: revert sbp2: enforce 32bit DMA mapping

2007-08-06 Thread Stefan Richter
will simply go with what 2.6.23-rc has and what 2.6.21 had: No dma_set_mask anywhere in the 1394 subsystem. We can revisit this whenever an actual need arises. -- Stefan Richter -=-=-=== =--- --==- http://arcgraph.de/sr/ ___ Linuxppc-dev mailing list

Re: [PATCH 2.6.22.y] ieee1394: revert sbp2: enforce 32bit DMA mapping

2007-08-06 Thread Stefan Richter
Robert Hancock wrote: Stefan Richter wrote: So that's the story why that dma_set_mask went into sbp2: Sbp2 wants mappings in a _subset_ of the OHCI-1394 controllers DMA range. Anyway. For now I will simply go with what 2.6.23-rc has and what 2.6.21 had: No dma_set_mask anywhere

Re: [PATCH 2.6.22.y] ieee1394: revert sbp2: enforce 32bit DMA mapping

2007-08-06 Thread Stefan Richter
-layer software has this requirement. (Well, debugging and forensic tools rely on that mode too, notably BenH's firescope, but this software runs remote, hence it's a different beast from sbp2.) -- Stefan Richter -=-=-=== =--- --=== http://arcgraph.de/sr

Re: [PATCH 2.6.22.y] ieee1394: revert sbp2: enforce 32bit DMA mapping

2007-08-04 Thread Stefan Richter
(Adding Cc: linuxppc-dev, olh) Robert Hancock wrote: Stefan Richter wrote: Date: Wed, 1 Aug 2007 20:30:36 +0200 (CEST) From: Stefan Richter [EMAIL PROTECTED] Subject: ieee1394: revert sbp2: enforce 32bit DMA mapping Revert commit 0555659d63c285ceb7ead3115532e1b71b0f27a7 from 2.6.22-rc1