ODO list to use modern
alternative APIs to replace it (but not yet). If you know some
candidates for this purpose, it is really helpful to accomplish it.
Regards
Takashi Sakamoto
All of the changes in the patches look good to me, as the return value
seems not to be so effective for a long time (15 years or more) and
expected so for future.
Reviewed-by: Takashi Sakamoto
One of my concern is that we are mostly in the last week for v6.3
development. When taking influence of
.le = -1, .signd = -1,
},
Looks good to me.
Reviewed-by: Takashi Sakamoto
In next time to post any of your v2 patchset, it's better to add
commenters of v1 patchset to CC list, so that your patch reaches the
person who has practical interests in it.
I'm waiti
= 0, .signd = 0,
188 .silence = { 0x00, 0x08, 0x00, 0x00 },
189 },
-> 190 /* FIXME: this format is not defined properly yet */
191 [SNDRV_PCM_FORMAT_SPECIAL] = {
192 .le = -1, .signd = -1,
193 },
Regards
Takashi Sakamoto
On Nov 23 2017 08:44, Maciej S. Szmigiero wrote:
On 23.11.2017 00:27, Takashi Sakamoto wrote:
On Nov 23 2017 04:17, Maciej S. Szmigiero wrote:
(..)
--- a/include/uapi/sound/asound.h
+++ b/include/uapi/sound/asound.h
@@ -236,7 +236,11 @@ typedef int __bitwise snd_pcm_format_t;
#define
;f=src/pcm/pcm_misc.c;h=5420b1895713a3aec3624a5218794a7b49baf167;hb=HEAD
Regards
Takashi Sakamoto
