[PATCH v2][net-next] soc: fsl: dpio: Unsigned compared against 0 in qbman_swp_set_irq_coalescing()

2021-10-19 Thread Tim Gardner
ell as be more precise regarding the exact error. Fixes: ed1d2143fee5 ("soc: fsl: dpio: add support for irq coalescing per software portal") Cc: Ioana Ciornei Cc: Roy Pledge Cc: Li Yang Cc: linux-ker...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Cc: linux-arm-ker...@lists.i

[PATCH][linux-next] soc: fsl: dpio: Unsigned compared against 0 in qbman_swp_set_irq_coalescing()

2021-10-18 Thread Tim Gardner
Pledge Cc: Li Yang Cc: linux-ker...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Cc: linux-arm-ker...@lists.infradead.org Signed-off-by: Tim Gardner --- I'm not 100% sure this is the right way to fix the warning, but according to the pr_err() comments these values should never be 0.

Re: [PATCH] powerpc: define empty enable_kernel_vsx() when CONFIG_VSX=n

2015-09-09 Thread Tim Gardner
On 09/08/2015 08:13 PM, Michael Ellerman wrote: On Tue, 2015-09-08 at 17:19 -0600, Tim Gardner wrote: On 09/08/2015 04:47 PM, Paul Mackerras wrote: On Tue, Sep 08, 2015 at 12:13:11PM -0600, tim.gard...@canonical.com wrote: From: Tim Gardner commit 72cd7b44bc99 ("powerpc: Uncomment and

Re: [PATCH] powerpc: define empty enable_kernel_vsx() when CONFIG_VSX=n

2015-09-08 Thread Tim Gardner
On 09/08/2015 04:47 PM, Paul Mackerras wrote: > On Tue, Sep 08, 2015 at 12:13:11PM -0600, tim.gard...@canonical.com wrote: >> From: Tim Gardner >> >> commit 72cd7b44bc99 ("powerpc: Uncomment and make enable_kernel_vsx() >> routine available") neglected to d

[PATCH] powerpc: define empty enable_kernel_vsx() when CONFIG_VSX=n

2015-09-08 Thread tim . gardner
From: Tim Gardner commit 72cd7b44bc99 ("powerpc: Uncomment and make enable_kernel_vsx() routine available") neglected to define an empty inline replacement for enable_kernel_vsx() when CONFIG_VSX=n. Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Michael Ellerman Cc: Leonida

Re: [4.2-rc3] macintosh/ans-lcd.c: Missing include causes compile failure

2015-07-23 Thread Tim Gardner
On 07/23/2015 04:18 AM, Michael Ellerman wrote: On Mon, 2015-20-07 at 19:01:42 UTC, Tim Gardner wrote: From: Tim Gardner drivers/macintosh/ans-lcd.c:201:1: warning: data definition has no type or storage class module_init(anslcd_init); ^ drivers/macintosh/ans-lcd.c:201:1: error: type

[PATCH 4.2-rc3] macintosh/ans-lcd.c: Missing include causes compile failure

2015-07-20 Thread tim . gardner
From: Tim Gardner drivers/macintosh/ans-lcd.c:201:1: warning: data definition has no type or storage class module_init(anslcd_init); ^ drivers/macintosh/ans-lcd.c:201:1: error: type defaults to 'int' in declaration of 'module_init' [-Werror=implicit-int] gcc version

Re: [PATCH] cpufreq: ppc-corenet-cpu-freq: do_div use quotient

2014-06-06 Thread Tim Gardner
locks */ > + u64temp = 12ULL * NSEC_PER_SEC; > + do_div(u64temp, fsl_get_sys_freq()); > + policy->cpuinfo.transition_latency = u64temp + 1; > > of_node_put(np); > > Whoops, what was I thinking ? You should also add "Cc: sta...@