Re: [PATCH]: [MPC5200] Add ATA DMA support

2008-08-13 Thread Tim Yamin
_task.bd_size and this fixes the problem. Signed-off-by: Tim Yamin <[EMAIL PROTECTED]> diff -urp linux-2.6.26-rc6/arch/powerpc/sysdev/bestcomm/ata.h linux-2.6.26-rc6-ata/arch/powerpc/sysdev/bestcomm/ata.h --- linux-2.6.26-rc6/arch/powerpc/sysdev/bestcomm/ata.h 2008-04-17 03:49:44.0

Re: [PATCH]: [MPC5200] Add ATA DMA support

2008-08-12 Thread Tim Yamin
On Wed, Aug 13, 2008 at 7:02 AM, Grant Likely <[EMAIL PROTECTED]> wrote: > While on this topic; have you had a chance to address the comments you > received on v2 of your patch? I'm keen to get your change merged in, > but there are a few more things that need to be sorted out. I'm still trying t

Re: [PATCH]: [MPC5200] Add ATA DMA support

2008-08-12 Thread Tim Yamin
On Tue, Aug 12, 2008 at 6:30 PM, Daniel Schnell <[EMAIL PROTECTED]> wrote: > Hi Tim, > > Continuing the discussion on the mailing list ... > > Looking at the original patch I don't undestand why you had to duplicate > the bestcomm data structures and functions. The only apparent difference > is tha

Re: [PATCH]: [MPC5200] Add ATA DMA support

2008-08-06 Thread Tim Yamin
On Wed, Aug 6, 2008 at 12:58 PM, Daniel Schnell <[EMAIL PROTECTED]> wrote: > Hi, > > Sorry for testing this patch so late, but I get these if I apply your > patch to 2.6.24.7 and use it with my Sandisk Extreme IV 4GB card: Hi, What board are you using? DMA requires a few more signals to be routed

Re: [PATCH]: [MPC5200] (v2) Add ATA DMA support

2008-07-03 Thread Tim Yamin
stComm tasks, e.g. when downloading a large file over a LAN to disk. 3) The ATA BestComm driver uses bcom_ata_bd which is bigger than bcom_bd and this causes problems because the various bcom_... functions do not dereference the correct location. I've introduced bcom_get_bd which use

Re: [PATCH]: [MPC5200] (v2) Add ATA DMA support

2008-07-02 Thread Tim Yamin
0) { struct bcom_task_2 *tsk = pata_mpc52xx_ata_dma_task; if(bcom_buffer_done_2(tsk)) return 1; } return 0; (Save the return value to `flags`) Unlocking example: if(flags == 0) clear_bit(0, &pata_mpc52xx

Re: [PATCH] powerpc/mpc5200: Fix lite5200b suspend/resume

2008-07-02 Thread Tim Yamin
Hi Grant, This patch works fine for me. Cheers, Tim On Tue, Jul 1, 2008 at 10:12 PM, Grant Likely <[EMAIL PROTECTED]> wrote: > From: Tim Yamin <[EMAIL PROTECTED]> > > Suspend/resume ("echo mem > /sys/power/state") does not work with > vanilla kernels --

[PATCH]: [MPC5200] (v2) Add ATA DMA support

2008-06-27 Thread Tim Yamin
rse be very welcome. Thanks, Signed-off-by: Tim Yamin <[EMAIL PROTECTED]> diff -Nurp linux-2.6.26-rc6/arch/powerpc/sysdev/bestcomm/ata.h linux-2.6.26-rc6.new/arch/powerpc/sysdev/bestcomm/ata.h --- linux-2.6.26-rc6/arch/powerpc/sysdev/bestcomm/ata.h 2008-03-18 15:49:53.0 + +++ linux-

[PATCH]: [MPC5200] Fix lite5200b suspend/resume

2008-06-17 Thread Tim Yamin
are saved and restored, this fixes a kernel panic for me on resume. Signed-off-by: Tim Yamin <[EMAIL PROTECTED]> --- linux-2.6.26-rc6/arch/powerpc/platforms/52xx/lite5200_pm.c~ 2008-04-17 03:49:44.0 +0100 +++ linux-2.6.26-rc6/arch/powerpc/platforms/52xx/lite5200_pm.c 2008-06-16 15:40

[PATCH]: [MPC5200] Add ATA DMA support

2008-06-17 Thread Tim Yamin
clear_bit(0, &pata_mpc52xx_ata_dma_lock); Comments and testing would of course be very welcome. Thanks, Signed-off-by: Tim Yamin <[EMAIL PROTECTED]> This patch adds MDMA/UDMA support (using BestComm for DMA) on the MPC5200 platform. Based heavily on previous work by Freescale (Bernard Kuhn, John