Re: [PATCH 4/7] ECHI Platform: Merge ppc-of EHCI driver into the ehci-platform driver

2014-02-21 Thread Tony Prisk
On 22/02/14 00:48, Mark Rutland wrote: [Adding Tony Prisk to Cc] On Fri, Feb 21, 2014 at 06:31:30AM +, Alistair Popple wrote: Currently the ppc-of driver uses the compatibility string "usb-ehci". This means platforms that use device-tree and implement an EHCI compatible interfa

Re: [PATCH 2/2] clocksource: Make clocksource register functions void

2014-01-23 Thread Tony Prisk
- you are still returning a value on a function declared void, and the return is now from a function that doesn't return anything either ?!?! Doesn't this throw a compile-time warning?? Regards Tony Prisk ___ Linuxppc-dev mailing list Linuxppc-d

Re: [PATCH 2/2] clocksource: Make clocksource register functions void

2014-01-23 Thread Tony Prisk
On 23/01/14 20:58, Geert Uytterhoeven wrote: On Thu, Jan 23, 2014 at 8:45 AM, Tony Prisk wrote: -static inline int clocksource_register_hz(struct clocksource *cs, u32 hz) +static inline void clocksource_register_hz(struct clocksource *cs, u32 hz) { return