From: Xu Panda
Comparing pointer whith NULL instead of comparing pointer to 0.
Reported-by: Zeal Robot
Signed-off-by: Xu Panda
---
drivers/macintosh/windfarm_pm121.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/macintosh/windfarm_pm121.c
b/drivers/macintosh
From: ye xingchen
Return the value opal_npu_spa_clear_cache() directly instead of storing
it in another redundant variable.
Reported-by: Zeal Robot
Signed-off-by: ye xingchen
---
arch/powerpc/platforms/powernv/ocxl.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/
From: ye xingchen
Return the value set_msg_len() directly instead of storing it in another
redundant variable.
Reported-by: Zeal Robot
Signed-off-by: ye xingchen
---
drivers/crypto/nx/nx-aes-ccm.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/crypto/nx/nx-aes
From: Jinpeng Cui
Return value directly from set_msg_len() instead of
getting value from redundant variable rc.
Reported-by: Zeal Robot
Signed-off-by: Jinpeng Cui
---
drivers/crypto/nx/nx-aes-ccm.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/crypto/nx/nx-ae
From: ye xingchen
Return the value vas_register_coproc_api() directly instead of storing it
in another redundant variable.
Reported-by: Zeal Robot
Signed-off-by: ye xingchen
---
arch/powerpc/platforms/pseries/vas.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/arch/
From: ye xingchen
Use !E to replace the type of x == 0. This change is just to
simplify the code, no actual functional changes.
Reported-by: Zeal Robot
Signed-off-by: ye xingchen
---
drivers/macintosh/adb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/macintosh
From: Minghao Chi
Because clk_disable_unprepare/clk_prepare_enable already checked NULL clock
parameter, so the additional checks are unnecessary, just remove them.
Reported-by: Zeal Robot
Signed-off-by: Minghao Chi
---
v1->v2:
remove the check of audmux_clk before "clk_prepare_enable"
From: Minghao Chi
Because clk_disable_unprepare already checked NULL clock
parameter, so the additional checks are unnecessary, just remove them.
Reported-by: Zeal Robot
Signed-off-by: Minghao Chi
---
sound/soc/fsl/imx-audmux.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff
From: Lv Ruyi
This function fsl_msi_setup_hwirq() seems to return zero on success and
non-zero on failure, but it returns zero in error handing path.
Reported-by: Zeal Robot
Signed-off-by: Lv Ruyi
---
arch/powerpc/sysdev/fsl_msi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --
From: Minghao Chi
Using pm_runtime_resume_and_get() to replace pm_runtime_get_sync and
pm_runtime_put_noidle. This change is just to simplify the code, no
actual functional changes.
Reported-by: Zeal Robot
Signed-off-by: Minghao Chi
---
sound/soc/fsl/fsl_asrc.c | 6 ++
1 file changed, 2 i
From: Minghao Chi
Using pm_runtime_resume_and_get() to replace pm_runtime_get_sync and
pm_runtime_put_noidle. This change is just to simplify the code, no
actual functional changes.
Reported-by: Zeal Robot
Signed-off-by: Minghao Chi
---
sound/soc/fsl/fsl_sai.c | 6 ++
1 file changed, 2 in
From: Minghao Chi
Using pm_runtime_resume_and_get is more appropriate
for simplifing code
Reported-by: Zeal Robot
Signed-off-by: Minghao Chi
---
sound/soc/fsl/fsl_esai.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai
From: Lv Ruyi
of_find_compatible_node() returns node pointer with refcount incremented,
use of_node_put() on it when done.
Reported-by: Zeal Robot
Signed-off-by: Lv Ruyi
---
arch/powerpc/platforms/powernv/ultravisor.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/platforms/
From: Lv Ruyi
The of_find_compatible_node() function returns a node pointer with
refcount incremented, use of_node_put() on it when done.
Reported-by: Zeal Robot
Signed-off-by: Lv Ruyi
---
arch/powerpc/sysdev/xics/icp-opal.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/sys
From: Minghao Chi (CGEL ZTE)
Use of_device_get_match_data() to simplify the code.
Reported-by: Zeal Robot
Signed-off-by: Minghao Chi (CGEL ZTE)
---
arch/powerpc/sysdev/fsl_msi.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/arch/powerpc/sysdev/fsl_msi.c b/arch
From: Minghao Chi (CGEL ZTE)
Use of_device_get_match_data() to simplify the code.
v1->v2:
Add a judgment on the return value of the A function as NULL
Reported-by: Zeal Robot
Signed-off-by: Minghao Chi (CGEL ZTE)
---
arch/powerpc/platforms/83xx/suspend.c | 7 ++-
1 file chan
From: Minghao Chi (CGEL ZTE)
Use of_device_get_match_data() to simplify the code.
Reported-by: Zeal Robot
Signed-off-by: Minghao Chi (CGEL ZTE)
---
arch/powerpc/platforms/83xx/suspend.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/arch/powerpc/platforms/83xx
From: Minghao Chi
Return value from i2c_add_driver() directly instead
of taking this in another redundant variable.
Reported-by: Zeal Robot
Signed-off-by: Minghao Chi
Signed-off-by: CGEL ZTE
---
drivers/macintosh/ams/ams-i2c.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff
From: Changcheng Deng
Fix the following coccicheck warning:
./arch/powerpc/platforms/cell/axon_msi.c: 456: 0-23: WARNING: fops_msic
should be defined with DEFINE_DEBUGFS_ATTRIBUTE
DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file()
imposes some significant overhead as compared to
DEFINE_DEBUGFS_ATTR
From: Changcheng Deng
Fix the following coccicheck warning:
./arch/powerpc/platforms/cell/axon_msi.c: 456: 0-23: WARNING: fops_msic
should be defined with DEFINE_DEBUGFS_ATTRIBUTE
Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE for
debugfs files.
Reported-by: Zeal Robot
Signed
From: Minghao Chi
Return value from ocxl_context_attach() directly instead
of taking this in another redundant variable.
Reported-by: Zeal Robot
Signed-off-by: Minghao Chi
---
drivers/misc/ocxl/file.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/misc/ocxl/fil
From: Ye Guojin
This was found by coccicheck:
./sound/soc/fsl/imx-hdmi.c,209,1-7,ERROR missing put_device; call
of_find_device_by_node on line 119, but without a corresponding object
release within this function.
Reported-by: Zeal Robot
Signed-off-by: Ye Guojin
---
sound/soc/fsl/imx-hdmi.c |
From: Ye Guojin
The operands of the bitwise OR operator are duplicated, remove one of
them.
Reported-by: Zeal Robot
Signed-off-by: Ye Guojin
---
arch/powerpc/xmon/ppc-opc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/xmon/ppc-opc.c b/arch/powerpc/xmon/
From: Jing Yao
coccicheck complains about the use of snprintf() in sysfs show
functions:
WARNING use scnprintf or sprintf
Use sysfs_emit instead of scnprintf or sprintf makes more sense.
Reported-by: Zeal Robot
Signed-off-by: Jing Yao
---
drivers/scsi/ibmvscsi/ibmvfc.c | 16
From: Jing Yao
coccicheck complains about the use of snprintf() in sysfs show
functions:
WARNING use scnprintf or sprintf
Use sysfs_emit instead of scnprintf or sprintf makes more sense.
Reported-by: Zeal Robot
Signed-off-by: Jing Yao
---
drivers/scsi/ibmvscsi/ibmvfc.c | 12 ++--
1 f
From: Changcheng Deng
Fix the following coccicheck warning:
./arch/powerpc/xmon/xmon.c: 4064: 0-23: WARNING: xmon_dbgfs_ops should
be defined with DEFINE_DEBUGFS_ATTRIBUTE
Reported-by: Zeal Robot
Signed-off-by: Changcheng Deng
---
arch/powerpc/xmon/xmon.c | 2 +-
1 file changed, 1 insertion(
From: Jing Yao
Reported-by: Zeal Robot
Signed-off-by: Jing Yao
---
drivers/scsi/ibmvscsi/ibmvfc.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c
index d0eab5700dc5..9f20fefc2c02 100644
--- a/drive
From: Changcheng Deng
Fix the coccicheck warning:
WARNING: use scnprintf or sprintf
Use sysfs_emit instead of scnprintf or sprintf makes more sense.
Reported-by: Zeal Robot
Signed-off-by: Changcheng Deng
---
drivers/scsi/ibmvscsi/ibmvfc.c | 16 ++--
1 file changed, 6 insertions(+
From: Lv Ruyi
'asm/interrupt.h' included in 'interrupt.c' is duplicated.
Reported-by: Zeal Robot
Signed-off-by: Lv Ruyi
---
arch/powerpc/kernel/interrupt.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/powerpc/kernel/interrupt.c b/arch/powerpc/kernel/interrupt.c
index 21bbd615ca41..
From: yong yiran
'inttypes.h' included in 'tm-poison.c' is duplicated.
Remove all but the first include of inttypes.h from tm-poison.c.
Reported-by: Zeal Robot
Signed-off-by: yong yiran
---
tools/testing/selftests/powerpc/tm/tm-poison.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools
30 matches
Mail list logo