+ if (!diu_ops.set_pixel_clock) {
+ data-pixelclk_reg = of_iomap(np, 1);
+ if (!data-pixelclk_reg) {
+ dev_err(pdev-dev, Cannot map pixelclk registers,
please \
+ provide the diu_ops for pixclk setting
instead.\n);
Thanks, This has been fixed in the update version, please help to
review it at:
http://patchwork.ozlabs.org/patch/335225/
I forgot to add the V2 information in the subject in the update patch
so this may confuse the reviewer, sorry for that.
It is not fixed in that patch (or did you
jason@freescale.com wrote:
However, the DIU is already initialized in u-boot and we can rely
on the settings in u-boot for corenet platform,
I don't like that at all.
[Jason Jin-R64188] What's the potential issue of this? Most of the IPs
need the platform initialization in u-boot
On 03/26/2014 12:41 PM, Jason Jin wrote:
+ if (!diu_ops.set_pixel_clock) {
+ data-saved_pixel_clock = 0;
+ if (of_address_to_resource(ofdev-dev.of_node, 1, res))
+ pr_err(KERN_ERR No pixel clock set func and no pixel
node!\n);
+ else
On 03/26/2014 12:41 PM, Jason Jin wrote:
This board sepecific initialization mechanism is not feasible i for
corenet platform as the corenet platform file is a abstraction of
serveral platforms.
You can't make it 100% abstract. The DIU driver requires some sort of
board support. I
jason@freescale.com wrote:
[Jason Jin-R64188] It's not hackish, we can provide the pixel clock
register in the DIU node, I did not provide the dts update as this is
only tested on T1040 platform. For other platforms such as p1022 and 8610,
we still can use the pixel clock setting
