Re: [PATCH v12 66/84] KVM: LoongArch: Mark "struct page" pfn accessed before dropping mmu_lock

2024-08-08 Thread maobibo
On 2024/7/27 上午7:52, Sean Christopherson wrote: Mark pages accessed before dropping mmu_lock when faulting in guest memory so that LoongArch can convert to kvm_release_faultin_page() without tripping its lockdep assertion on mmu_lock being held. Signed-off-by: Sean Christopherson --- arch/

Re: [PATCH v12 64/84] KVM: LoongArch: Mark "struct page" pfns dirty only in "slow" page fault path

2024-08-08 Thread maobibo
On 2024/7/27 上午7:52, Sean Christopherson wrote: Mark pages/folios dirty only the slow page fault path, i.e. only when mmu_lock is held and the operation is mmu_notifier-protected, as marking a page/folio dirty after it has been written back can make some filesystems unhappy (backing KVM guests

Re: [PATCH v12 64/84] KVM: LoongArch: Mark "struct page" pfns dirty only in "slow" page fault path

2024-08-05 Thread maobibo
On 2024/8/6 上午7:22, Sean Christopherson wrote: On Sat, Aug 03, 2024, maobibo wrote: On 2024/8/3 上午3:32, Sean Christopherson wrote: On Fri, Aug 02, 2024, maobibo wrote: On 2024/7/27 上午7:52, Sean Christopherson wrote: Mark pages/folios dirty only the slow page fault path, i.e. only when

Re: [PATCH v12 64/84] KVM: LoongArch: Mark "struct page" pfns dirty only in "slow" page fault path

2024-08-02 Thread maobibo
On 2024/8/3 上午3:32, Sean Christopherson wrote: On Fri, Aug 02, 2024, maobibo wrote: On 2024/7/27 上午7:52, Sean Christopherson wrote: Mark pages/folios dirty only the slow page fault path, i.e. only when mmu_lock is held and the operation is mmu_notifier-protected, as marking a page/folio

Re: [PATCH v12 64/84] KVM: LoongArch: Mark "struct page" pfns dirty only in "slow" page fault path

2024-08-02 Thread maobibo via Linuxppc-dev
On 2024/7/27 上午7:52, Sean Christopherson wrote: Mark pages/folios dirty only the slow page fault path, i.e. only when mmu_lock is held and the operation is mmu_notifier-protected, as marking a page/folio dirty after it has been written back can make some filesystems unhappy (backing KVM guests

Re: [PATCH v12 65/84] KVM: LoongArch: Mark "struct page" pfns accessed only in "slow" page fault path

2024-08-02 Thread maobibo via Linuxppc-dev
On 2024/7/27 上午7:52, Sean Christopherson wrote: Mark pages accessed only in the slow path, before dropping mmu_lock when faulting in guest memory so that LoongArch can convert to kvm_release_faultin_page() without tripping its lockdep assertion on mmu_lock being held. Signed-off-by: Sean Chri

Re: [PATCH v2 4/6] KVM: Delete the now unused kvm_arch_sched_in()

2024-05-23 Thread maobibo
On 2024/5/22 上午9:40, Sean Christopherson wrote: Delete kvm_arch_sched_in() now that all implementations are nops. Signed-off-by: Sean Christopherson --- arch/arm64/include/asm/kvm_host.h | 1 - arch/loongarch/include/asm/kvm_host.h | 1 - arch/mips/include/asm/kvm_host.h | 1 -

Re: [PATCH 1/4] KVM: delete .change_pte MMU notifier callback

2024-04-08 Thread maobibo
On 2024/4/5 下午7:58, Paolo Bonzini wrote: The .change_pte() MMU notifier callback was intended as an optimization. The original point of it was that KSM could tell KVM to flip its secondary PTE to a new location without having to first zap it. At the time there was also an .invalidate_page() ca

Re: [PATCH 7/7] KVM: MIPS: clean up redundant kvm_run parameters in assembly

2020-04-20 Thread maobibo
On 04/19/2020 03:51 PM, Tianjia Zhang wrote: > In the current kvm version, 'kvm_run' has been included in the 'kvm_vcpu' > structure. Earlier than historical reasons, many kvm-related function > parameters retain the 'kvm_run' and 'kvm_vcpu' parameters at the same time. > This patch does a unifi