Re: [PATCH 2/2] powerpc/85xx: p1022ds: enable monitor switching via pixis indirect mode

2011-11-18 Thread Timur Tabi
Scott Wood wrote: What's wrong with doing it in setup_arch()? Well, I was hoping to encapsulate everything into one function -- the early_param() callback function. But I guess that's not going to work. -- Timur Tabi Linux kernel developer at Freescale

Re: [PATCH][v2] powerpc/85xx: Rework P1022DS device tree

2011-11-17 Thread Tabi Timur-B04825
-off-by: Kumar Gala ga...@kernel.crashing.org --- v2: fixed localbus reg property Acked-by: Timur Tabi ti...@freescale.com -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https

Re: [PATCH][v2] powerpc/85xx: Rework P1022DS device tree

2011-11-17 Thread Timur Tabi
Kumar Gala wrote: Acked-by: Timur Tabi ti...@freescale.com How about a Tested-by: I did test it. Tested-by: Timur Tabi ti...@freescale.com -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev

[PATCH 1/2] powerpc/85xx: add pixis indirect mode device tree node

2011-11-17 Thread Timur Tabi
-control child node of the localbus node that contains a 'reg' property for CS0 and CS1. This will produce the correct physical addresses for CS0 and CS1. Signed-off-by: Timur Tabi ti...@freescale.com --- arch/powerpc/boot/dts/p1022ds.dts | 14 ++ 1 files changed, 14 insertions(+), 0

[PATCH 2/2] powerpc/85xx: p1022ds: enable monitor switching via pixis indirect mode

2011-11-17 Thread Timur Tabi
of no longer requiring U-Boot to enable the DIU. Now Linux can enable the DIU all by itself. Signed-off-by: Timur Tabi ti...@freescale.com --- arch/powerpc/platforms/85xx/p1022_ds.c | 132 ++- 1 files changed, 110 insertions(+), 22 deletions(-) diff --git a/arch/powerpc

Re: [PATCH 2/2] powerpc/85xx: p1022ds: enable monitor switching via pixis indirect mode

2011-11-17 Thread Timur Tabi
on the error path). But I don't want multiple error path labels. The error path could only happen if someone passed in a broken device tree (i.e. pretty much never), so I'm not keen on complicating my code just to optimize something that will never be used. -- Timur Tabi Linux kernel developer

Re: [PATCH 2/2] powerpc/85xx: p1022ds: enable monitor switching via pixis indirect mode

2011-11-17 Thread Timur Tabi
we ship on the P1022DS board. We could just remove the NOR flash node from the DTS. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 2/2] powerpc/85xx: p1022ds: enable monitor switching via pixis indirect mode

2011-11-17 Thread Timur Tabi
the desired mode before entering the kernel, and provide an appropriate device tree. I can both of these features, but not in this patch. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org

Re: [RFC][PATCH 15/30] powerpc/85xx: Rework P1022DS device tree

2011-11-16 Thread Timur Tabi
0x0800 0x1 0x0 0xf 0xe000 0x0800 0x2 0x0 0x0 0xffa0 0x0004 ^^^ 0x3 0x0 0xf 0xffdf 0x8000; -- Timur Tabi Linux kernel developer at Freescale

Re: [RFC][PATCH 15/30] powerpc/85xx: Rework P1022DS device tree

2011-11-15 Thread Tabi Timur-B04825
. The reg property should look like this: reg = 0xf 0xffe05000 0 0x1000; ^^^ Do you want to fix this here, or do you want me to submit a patch that fixes the original p1022ds.dts? -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev

Re: [PATCH] P1021: set IReady in QE Microcode Upload

2011-11-15 Thread Tabi Timur-B04825
for conditionally including this code? I'll have to check. But this patch can't be applied as-is unless it's proven safe for all QE-enabled chips. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https

Re: [RFC PATCH 00/17] powerpc/e500: separate e500 from e500mc

2011-11-14 Thread Tabi Timur-B04825
Moffett, Kyle D wrote: the PPC Book-E spec documents that the pagesize is an even multiple of the cacheline size and the cachelines are always page-aligned. cachelines are page aligned? -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc

Re: [RFC PATCH 02/17] powerpc: Split up PHYS_64BIT config option to fix select issues

2011-11-11 Thread Tabi Timur-B04825
if you have a mismatched U-Boot and device tree, because it is so easy to mess that up. I would like nothing more than to abandon 32-bit for all e500, but I don't see Freescale allowing that any time soon. -- Timur Tabi Linux kernel developer at Freescale

Re: [PATCH] P1021: set IReady in QE Microcode Upload

2011-11-11 Thread Tabi Timur-B04825
. Will this code still work on other QE parts, like the MPC8323? -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [RFC PATCH 02/17] powerpc: Split up PHYS_64BIT config option to fix select issues

2011-11-10 Thread Timur Tabi
on true 64-bit kernels, and in those cases, we cannot build a kernel with 32-bit phys support, so the driver needs to handle it internally. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org

Re: [RFC PATCH 02/17] powerpc: Split up PHYS_64BIT config option to fix select issues

2011-11-10 Thread Timur Tabi
DTs for the P4080-class parts, and we don't have a U-Boot configuration option for building a 32-bit compatible U-Boot. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https

Re: [RFC][PATCH 15/30] powerpc/85xx: Rework P1022DS device tree

2011-11-10 Thread Tabi Timur-B04825
this will force all P boards to have the same CCSR address. I don't think so, because I didn't see it, but I just want to make sure. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https

Re: fpga driver on custom PPC target platform (P4080) ...

2011-11-04 Thread Tabi Timur-B04825
. If you look at other device trees, you'll see they only have one node for any particular I2C device. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 6/7] fsl_pmc: Add API to enable device as wakeup event source

2011-11-04 Thread Tabi Timur-B04825
to a device tree property. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] powerpc/usb: use unsigned long to type cast an address of ioremap

2011-11-03 Thread Tabi Timur-B04825
more sense: usb_sys_regs = (void *)dr_regs + USB_DR_SYS_OFFSET; -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] powerpc/usb: use unsigned long to type cast an address of ioremap

2011-11-03 Thread Tabi Timur-B04825
? If so, then that's something that gcc supports and that the kernel uses all over the place. A char* is incorrect because a char could be more than one byte, in theory. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list

Re: [PATCH] powerpc/usb: use unsigned long to type cast an address of ioremap

2011-11-03 Thread Timur Tabi
On Nov 3, 2011, at 7:16 AM, David Laight david.lai...@aculab.com wrote: Arithmetic on 'void *' should not be done. I know some versions of gcc allow it (provided some warning level/option is enabled) but that doesn't mean it is valid. My suspicions are that is was allowed due to the way 'void

[PATCH] powerpc/85xx: do not force PHYS_64BIT on Freescale reference boards

2011-11-03 Thread Timur Tabi
-by: Timur Tabi ti...@freescale.com --- arch/powerpc/configs/corenet32_smp_defconfig |1 + arch/powerpc/platforms/85xx/Kconfig |5 - 2 files changed, 1 insertions(+), 5 deletions(-) diff --git a/arch/powerpc/configs/corenet32_smp_defconfig b/arch/powerpc/configs

Re: [PATCH] powerpc/85xx: do not force PHYS_64BIT on Freescale reference boards

2011-11-03 Thread Timur Tabi
board doesn't sound like the best way to enforce this. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH] [v3] powerpc/fsl_msi: add support for the fsl, msi property in PCI nodes

2011-10-31 Thread Timur Tabi
for that device. If it exists, then as we are looping over all MSI devices, we skip the ones that don't have a matching phandle. Signed-off-by: Timur Tabi ti...@freescale.com --- v3: added check for invalid fsl,msi phandles arch/powerpc/sysdev/fsl_msi.c | 39

[PATCH] powerpc/fsl_msi: add support for the fsl, msi property in PCI nodes

2011-10-26 Thread Timur Tabi
for that device. If it exists, then as we are looping over all MSI devices, we skip the ones that don't have a matching phandle. Signed-off-by: Timur Tabi ti...@freescale.com --- arch/powerpc/sysdev/fsl_msi.c | 33 + 1 files changed, 33 insertions(+), 0 deletions

[PATCH] [v2] powerpc/fsl_msi: add support for the fsl, msi property in PCI nodes

2011-10-26 Thread Timur Tabi
for that device. If it exists, then as we are looping over all MSI devices, we skip the ones that don't have a matching phandle. Signed-off-by: Timur Tabi ti...@freescale.com --- arch/powerpc/sysdev/fsl_msi.c | 33 + arch/powerpc/sysdev/fsl_msi.h |3 +++ 2

Re: [PATCH 03/11] powerpc/85xx: Rework PCI nodes on P1020RDB

2011-10-24 Thread Timur Tabi
Kumar Gala wrote: I would have hoped the bindings had made it clear already what was board info vs what was SoC. When it comes to device trees, I never assume anything is clear. If not, they should be clarify that in the binding specs. I'm okay with that. -- Timur Tabi Linux kernel

Re: [PATCH 03/11] powerpc/85xx: Rework PCI nodes on P1020RDB

2011-10-23 Thread Tabi Timur-B04825
; #interrupt-cells = 1; I suppose it's obvious that 'reg' and 'ranges' should be defined, so this isn't the best example. But we should document if any other properties should be defined. For example, the SSI nodes contain a bunch of SOC- and board-specific properties. -- Timur Tabi Linux kernel

Re: [PATCH] powerpc/fsl_msi: add support for msi-address-64 property

2011-10-21 Thread Tabi Timur-B04825
files changed, 57 insertions(+), 8 deletions(-) applied Applied where, exactly? You don't have a repo on kernel.org, and your repo on github.org is over a month old. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc

Re: [RFC][PATCH 2/2] powerpc/85xx: Introduce a P1020 SoC device tree

2011-10-20 Thread Tabi Timur-B04825
On Thu, Oct 20, 2011 at 2:24 AM, Kumar Gala ga...@kernel.crashing.org wrote:  arch/powerpc/boot/dts/p1020soc.dtsi |  262 +++ All of the other dtsi files are of the format ___si.dtsi. Why does this one use ___soc.dtsi? -- Timur Tabi Linux kernel developer

Re: [RFC][PATCH 1/2] powerpc/85xx: create dts components to build up an SoC

2011-10-20 Thread Tabi Timur-B04825
; +       reg = 0x4500 0x100; +       clock-frequency = 0; +       interrupts = 42 2 0 0; +}; How about we put all serial devices into one pq3-duart.dtsi file, and let the parent dtsi file reference just the ones that it needs? -- Timur Tabi Linux kernel developer at Freescale

Re: [RFC][PATCH 1/2] powerpc/85xx: create dts components to build up an SoC

2011-10-20 Thread Timur Tabi
-enable them? -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] uio: Support 36-bit physical addresses on 32-bit systems

2011-10-13 Thread Tabi Timur-B04825
This isn't really an answer to the question. This just says that phys_addr_t can be 64-bit. I don't see anywhere in the kernel that we *enforce* or *require* that sizeof(phys_addr_t) = sizeof(void *). -- Timur Tabi Linux kernel developer at Freescale

Re: [PATCH] powerpc/85xx: fix PHYS_64BIT selection for P1022DS

2011-10-13 Thread Tabi Timur-B04825
changed, 1 insertions(+), 1 deletions(-) applied Why did you apply this patch? Both Scott and I rejected it. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo

Re: [PATCH] uio: Support 36-bit physical addresses on 32-bit systems

2011-10-13 Thread Timur Tabi
Geert Uytterhoeven wrote: You deleted this part: config PHYS_ADDR_T_64BIT def_bool 64BIT || ARCH_PHYS_ADDR_T_64BIT which enforces that PHYS_ADDR_T_64BIT is enabled if 64BIT is set. Ok, I didn't catch that before, but it makes sense now. Thanks. -- Timur Tabi Linux kernel

Re: [PATCH][v2] uio: Support 36-bit physical addresses on 32-bit systems

2011-10-13 Thread Tabi Timur-B04825
phys_addr_t for a virtual pointer. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH][v2] uio: Support 36-bit physical addresses on 32-bit systems

2011-10-13 Thread Timur Tabi
to the structure definition. I don't think that's asking a lot. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] powerpc/85xx: fix PHYS_64BIT selection for P1022DS

2011-10-13 Thread Timur Tabi
understand why you couldn't do that when you applied the patch. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] powerpc/85xx: fix PHYS_64BIT selection for P1022DS

2011-10-13 Thread Timur Tabi
. This is my problem with the patch. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: Enabling MBX in MPC5121

2011-10-05 Thread Tabi Timur-B04825
? There may be some support for the GPU in the BSP for the MPC5121, but I don't think there's anything in the mainline kernel. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https

Re: Handling multiple GPIO controllers in 8xxx GPIO driver

2011-09-29 Thread Tabi Timur-B04825
chained handler? If the chained handler returns IRQ_NONE, the interrupt code just gives up? Why is it called a chained handler? Where's the chain? I'm trying to understand the core interrupt code, and I can't seem to find any descriptions of it. -- Timur Tabi Linux kernel developer at Freescale

Re: Handling multiple GPIO controllers in 8xxx GPIO driver

2011-09-28 Thread Tabi Timur-B04825
handler? -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] powerpc/85xx: fix PHYS_64BIT selection for P1022DS

2011-09-26 Thread Timur Tabi
they like to keep 32-bit and 36-bit environments for both, and why they default to 32-bit. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] powerpc/85xx: fix PHYS_64BIT selection for P1022DS

2011-09-25 Thread Tabi Timur-B04825
. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH] powerpc/fsl_msi: add support for msi-address-64 property

2011-09-23 Thread Timur Tabi
redefined from an actual address to just an offset, but the fields were not renamed accordingly. These fields are replace with a single field, msiir_offset, to reflect the new meaning. Signed-off-by: Timur Tabi ti...@freescale.com --- This patch is necessary, but not sufficient, for MSI support

Re: [PATCH] drivers/tty: don't use the byte channel handle as a parameter in ehv_bytechan.c

2011-09-22 Thread Timur Tabi
Greg KH wrote: This patch doesn't apply at all to my tty tree, what was it made against? An internal repository that supposed to be in-sync with the latest and greatest. What's the URL for your tty-next repo? -- Timur Tabi Linux kernel developer at Freescale

Re: [PATCH] drivers/tty: don't use the byte channel handle as a parameter in ehv_bytechan.c

2011-09-22 Thread Tabi Timur-B04825
patch apply to linux-next? It does not, and I see why now. Looks like the internal tree is not in sync after all. I will post a V2 shortly. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org

[PATCH] [v2] drivers/tty: don't use the byte channel handle as a parameter in ehv_bytechan.c

2011-09-22 Thread Timur Tabi
variable. Signed-off-by: Timur Tabi ti...@freescale.com --- drivers/tty/ehv_bytechan.c |7 ++- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/tty/ehv_bytechan.c b/drivers/tty/ehv_bytechan.c index f733718..1595dba 100644 --- a/drivers/tty/ehv_bytechan.c +++ b/drivers

[PATCH] drivers/tty: don't use the byte channel handle as a parameter in ehv_bytechan.c

2011-09-20 Thread Timur Tabi
eliminate the code altogether. Signed-off-by: Timur Tabi ti...@freescale.com --- drivers/tty/ehv_bytechan.c |7 ++- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/tty/ehv_bytechan.c b/drivers/tty/ehv_bytechan.c index e67f70b..b24e6f7 100644 --- a/drivers/tty

Re: [PATCH] fsl-diu-fb: remove the ioctl interface

2011-09-20 Thread Tabi Timur-B04825
Anatolij, I'm sorry to resurrect an old thread, but ... On Wed, Jun 22, 2011 at 3:11 PM, Anatolij Gustschin ag...@denx.de wrote: On Tue, 21 Jun 2011 23:13:11 + Tabi Timur-B04825 b04...@freescale.com wrote: Anatolij Gustschin wrote: No! We are using ioctl interface of this driver

WARNING: vmlinux.o (.PPC.EMB.apuinfo): unexpected non-allocatable section.

2011-09-19 Thread Timur Tabi
counter support, it just stops at the Mount-cache hash table entries: 256 line. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] [v2] powerpc/85xx: clean up FPGA device tree nodes for Freecsale QorIQ boards

2011-09-15 Thread Timur Tabi
Kumar Gala wrote: What happened to looking at pixis vs ngpixis ? Doh, I knew I was forgetting something. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo

Re: [PATCH] [v2] powerpc/85xx: clean up FPGA device tree nodes for Freecsale QorIQ boards

2011-09-15 Thread Timur Tabi
Gala Kumar-B11780 wrote: I pulling the p3060qds bit out so drop that change from next patch. Ok, I'm thinking it should look like this: compatible = fsl,p3060qds-fpga, fsl,fpga-qixis; -- Timur Tabi Linux kernel developer at Freescale

Re: [PATCH] [v2] powerpc/85xx: clean up FPGA device tree nodes for Freecsale QorIQ boards

2011-09-15 Thread Timur Tabi
. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH] [v3] powerpc/85xx: clean up FPGA device tree nodes for Freecsale QorIQ boards

2011-09-15 Thread Timur Tabi
, however, since that particular function doesn't work anyway. When the DIU is active, the PIXIS is in indirect mode, and so cannot be accessed as a memory-mapped device. Signed-off-by: Timur Tabi ti...@freescale.com --- v3: added ngpixis to list v2: removed references to the CPLD This patch only

Re: [PATCH 3/4] powerpc/p3060qds: Add support for P3060QDS board

2011-09-14 Thread Tabi Timur-B04825
if these are the right numbers, but the 2 line is missing. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH] [v2] powerpc/85xx: clean up FPGA device tree nodes for Freecsale QorIQ boards

2011-09-14 Thread Timur Tabi
of the functionality is the same, so it makes sense to create common compatibility strings. Signed-off-by: Timur Tabi ti...@freescale.com --- v2: removed references to the CPLD This patch applies on top of [PATCH 3/4] powerpc/p3060qds: Add support for P3060QDS board, but it also assumes that the 'ranges' property

[PATCH] powerpc/fsl_msi: fix support for multiple MSI ranges

2011-09-13 Thread Timur Tabi
Commit 6820fead (powerpc/fsl_msi: Handle msi-available-ranges better) added support for multiple ranges in the msi-available-ranges property, but it miscalculated the MSIR index when multiple ranges are used. Signed-off-by: Timur Tabi ti...@freescale.com --- arch/powerpc/sysdev/fsl_msi.c |8

Re: [PATCH] powerpc/fsl_msi: Handle msi-available-ranges better

2011-09-07 Thread Tabi Timur-B04825
incremented in the loop, and cascade_data-index is set to the sum of the two. Perhaps you meant this: err = fsl_msi_setup_hwirq(msi, dev, offset, j); -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc

[PATCH] powerpc/5200: enable audio in the defconfig

2011-09-01 Thread Timur Tabi
Audio support for the MPC5200 exists, so enable it by default. Signed-off-by: Timur Tabi ti...@freescale.com --- There was a bug in the audio drivers related to the of_platform changes that was never discovered because these drivers were never compiled by default. This patch should make sure

Re: [PATCH 1/4] powerpc/85xx: Rename PowerPC core nodes to match other e500mc based .dts

2011-09-01 Thread Tabi Timur-B04825
not using the generic names recommendation? Is the PowerPC vendor string still appropriate here, or should we use fsl? And what about a compatible property? -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev

Re: [PATCH 1/4] powerpc/85xx: Rename PowerPC core nodes to match other e500mc based .dts

2011-09-01 Thread Tabi Timur-B04825
trees in one shot, instead of just the P4080? -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] powerpc/fsl_msi: clean up and document calculation of MSIIR address

2011-08-30 Thread Tabi Timur-B04825
Timur Tabi wrote: Commit 3da34aae (powerpc/fsl: Support unique MSI addresses per PCIe Root Complex) redefined the meanings of msi-msi_addr_hi and msi-msi_addr_lo to be an offset rather than an address. To help clarify the code, we make the following changes: Kumar, I'm going to merge

Re: [PATCH] powerpc/85xx: clean up FPGA device tree nodes for Freecsale QorIQ boards

2011-08-30 Thread Tabi Timur-B04825
pixis on MPC8544DS, MPC8572DS, MPC8536DS. Ok. Also fpga-cpld makes no sense if we keep this. You are either a CPLD or FPGA not both. Then I don't understand what the CPLD is. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev

Re: [PATCH] powerpc/85xx: clean up FPGA device tree nodes for Freecsale QorIQ boards

2011-08-30 Thread Tabi Timur-B04825
Kumar Gala wrote: On Aug 30, 2011, at 9:51 PM, Tabi Timur-B04825 wrote: Kumar Gala wrote: Do we really want the generic fsl,fpga-cpld fsl,fpga-pixis? This seems to vague. Yes, the PIXIS is generally register compatible across all boards. There may be some minor differences

[PATCH] powerpc/85xx: clean up FPGA device tree nodes for Freecsale QorIQ boards

2011-08-29 Thread Timur Tabi
to create common compatibility strings. Signed-off-by: Timur Tabi ti...@freescale.com --- Changes for other Freescale boards will be made in future patches. .../devicetree/bindings/powerpc/fsl/board.txt | 30 arch/powerpc/boot/dts/p1010rdb.dts | 10

[PATCH] powerpc/fsl_msi: clean up and document calculation of MSIIR address

2011-08-26 Thread Timur Tabi
. 2) Rename msi_addr_lo to ccsr_msiir_offset, to indicate that it's an offset relative to the beginning of CCSR. 3) Calculate 64-bit addresses using actual 64-bit math. 4) Document some of the code and assumptions we make. Signed-off-by: Timur Tabi ti...@freescale.com --- arch/powerpc/sysdev

Re: linux-next: build failure after merge of the final tree (tty tree related)

2011-08-25 Thread Timur Tabi
On Aug 25, 2011, at 9:08 AM, Greg KH g...@kroah.com wrote: On Thu, Aug 25, 2011 at 04:18:43PM +1000, Stephen Rothwell wrote: Thanks for the report. Timur, care to send a fixup patch for this so this gets resolved? Yes, I will do it ASAP, probably within the next two hours

Re: linux-next: build failure after merge of the final tree (tty tree related)

2011-08-25 Thread Timur Tabi
Greg KH wrote: MSR_GS is defined in arch/powerpc/include/asm/reg_booke.h which is included by arch/powerpc/include/asm/reg.h but only when defined (CONFIG_BOOKE) || defined(CONFIG_40x). Thanks for the report. Timur, care to send a fixup patch for this so this gets resolved

[PATCH] [v4] tty/powerpc: introduce the ePAPR embedded hypervisor byte channel driver

2011-08-25 Thread Timur Tabi
, which is used to handle user-space input and output. The byte channel used for the console is designated as the default tty. Signed-off-by: Timur Tabi ti...@freescale.com --- arch/powerpc/include/asm/udbg.h |1 + arch/powerpc/kernel/udbg.c |2 + drivers/tty/Kconfig | 34

Re: [PATCH] [v4] tty/powerpc: introduce the ePAPR embedded hypervisor byte channel driver

2011-08-25 Thread Timur Tabi
Greg KH wrote: No, this doesn't work, I need just a fix, as I took your previous patch already. Sorry, coming right up. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https

[PATCH] tty/powerpc: fix build break with ehv_bytechan.c on allyesconfig

2011-08-25 Thread Timur Tabi
The Kconfig for the ePAPR hypervisor byte channel driver has a depends on PPC, which means it would compile on all PowerPC platforms, even though it's only been tested on Freescale platforms. Change the Kconfig to depend on FSL_SOC instead. Signed-off-by: Timur Tabi ti...@freescale.com

Re: [PATCH] tty/powerpc: fix build break with ehv_bytechan.c on allyesconfig

2011-08-25 Thread Timur Tabi
? I've made a few changes, and it builds on all PPC now. I'll post a new patch. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH] [v2] tty/powerpc: fix build break with ehv_bytechan.c on allyesconfig

2011-08-25 Thread Timur Tabi
The ePAPR hypervisor byte channel driver is supposed to work on all ePAPR-compliant embedded PowerPC systems, but it had a reference to the MSR_GS bit, which is available only on Book-E systems. Also fix a couple integer-to-pointer typecast problems. Signed-off-by: Timur Tabi ti...@freescale.com

Re: [PATCH] tty/powerpc: fix build break with ehv_bytechan.c on allyesconfig

2011-08-25 Thread Timur Tabi
platform. So I'm not removing this code just to fix the build break. It really should never have been there in the first place. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https

Re: [PATCH] xics/icp_natives: add __init to marker icp_native_init()

2011-08-25 Thread Timur Tabi
-common.c' by xics_init() which is itself marked with __init. = not built-tested = Reported-by: Timur Tabi ti...@freescale.com Signed-off-by: Arnaud Lacombe lacom...@gmail.com Acked-by: Timur Tabi ti...@freescale.com This warning still appears, though: WARNING: arch/powerpc/sysdev/built-in.o

Re: [PATCH] powerpc: fixup QE_General4 errata

2011-08-23 Thread Timur Tabi
Joakim Tjernlund wrote: QE_General4 should only round up the divisor iff divisor is 3. Rounding up lower divisors makes the error too big, causing USB on MPC832x to fail. Signed-off-by: Joakim Tjernlund joakim.tjernl...@transmode.se Acked-by: Timur Tabi ti...@freescale.com -- Timur Tabi

Re: [PATCH 8/9] arch/powerpc/sysdev/ehv_pic.c: add missing kfree

2011-08-23 Thread Timur Tabi
Julia Lawall wrote: At this point, ehv_pic has been allocated but not stored anywhere, so it should be freed before leaving the function. Acked-by: Timur Tabi ti...@freescale.com FYI, Ashish is no longer with Freescale, so I've taken over maintainership of ehv_pic. -- Timur Tabi Linux kernel

Re: [PATCH 8/9] arch/powerpc/sysdev/ehv_pic.c: add missing kfree

2011-08-23 Thread Timur Tabi
missing something? irq_alloc_host() calls of_node_get(): host-of_node = of_node_get(of_node); so doesn't that mean that the caller of irq_alloc_host() should release the device node pointer? -- Timur Tabi Linux kernel developer at Freescale

Re: [PATCH] sound/soc/fsl/fsl_dma.c: add missing of_node_put

2011-08-22 Thread Timur Tabi
== dma_channel_np) return ssi_np; np = of_parse_phandle(ssi_np, fsl,capture-dma, 0); + of_node_put(np); if (np == dma_channel_np) return ssi_np; } return NULL; -- Timur Tabi Linux kernel developer

[PATCH] [v2] sound/soc/fsl/fsl_dma.c: add missing of_node_put

2011-08-22 Thread Timur Tabi
of_parse_phandle increments the reference count of np, so this should be decremented before trying the next possibility. Since we don't actually use np, we can decrement the reference count immediately. Reported-by: Julia Lawall ju...@diku.dk Signed-off-by: Timur Tabi ti...@freescale.com

[PATCH] powerpc/85xx: remove left-over printks in p1022_ds.c

2011-08-18 Thread Timur Tabi
Two debugging prinkts were accidentally included in the last patch to arch/powerpc/platforms/85xx/p1022_ds.c. Signed-off-by: Timur Tabi ti...@freescale.com --- arch/powerpc/platforms/85xx/p1022_ds.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/platforms

[PATCH] ASoC: claim the IRQ when the fsl_ssi device is probed, not opened

2011-08-16 Thread Timur Tabi
. Instead, we should claim the IRQ when the device is probed. Signed-off-by: Timur Tabi ti...@freescale.com --- arch/powerpc/configs/mpc85xx_defconfig |1 + arch/powerpc/configs/mpc85xx_smp_defconfig |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/powerpc/configs

[PATCH] powerpc/85xx: enable the audio drivers in the defconfigs

2011-08-16 Thread Timur Tabi
Enable the audio drivers in the non-corenet 85xx defconfigs so that audio is enabled on the Freescale P1022DS reference board. Signed-off-by: Timur Tabi ti...@freescale.com --- sound/soc/fsl/fsl_ssi.c | 61 -- 1 files changed, 37 insertions(+), 24

Re: [PATCH] powerpc/85xx: enable the audio drivers in the defconfigs

2011-08-16 Thread Tabi Timur-B04825
Timur Tabi wrote: Enable the audio drivers in the non-corenet 85xx defconfigs so that audio is enabled on the Freescale P1022DS reference board. Signed-off-by: Timur Tabiti...@freescale.com Ugh, somehow I got my patches criss-crossed. Ignore this, please. I'll post a V2 in just a minute

Re: [PATCH] ASoC: claim the IRQ when the fsl_ssi device is probed, not opened

2011-08-16 Thread Tabi Timur-B04825
Timur Tabi wrote: The PowerPC Freescale SSI driver is claiming the IRQ when the IRQ when the device is opened, which means that the /proc/interrupts entry for the SSI exists only during playback or capture. This also meant that the user won't know that the IRQ number is wrong until he tries

[PATCH] [v2] powerpc/85xx: enable the audio drivers in the defconfigs

2011-08-16 Thread Timur Tabi
Enable the audio drivers in the non-corenet 85xx defconfigs so that audio is enabled on the Freescale P1022DS reference board. Signed-off-by: Timur Tabi ti...@freescale.com --- arch/powerpc/configs/mpc85xx_defconfig |1 + arch/powerpc/configs/mpc85xx_smp_defconfig |1 + 2 files

[PATCH] [v2] ASoC: claim the IRQ when the fsl_ssi device is probed, not opened

2011-08-16 Thread Timur Tabi
. Instead, we should claim the IRQ when the device is probed. Signed-off-by: Timur Tabi ti...@freescale.com --- sound/soc/fsl/fsl_ssi.c | 61 -- 1 files changed, 37 insertions(+), 24 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl

Re: [PATCH 8/9] arch/powerpc/sysdev/ehv_pic.c: add missing kfree

2011-08-15 Thread Tabi Timur-B04825
= of_node_get(of_node); so doesn't that mean that the caller of irq_alloc_host() should release the device node pointer? -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org

[PATCH] drivers/misc: introduce Freescale Data Collection Manager driver

2011-08-01 Thread Timur Tabi
). Signed-off-by: Timur Tabi ti...@freescale.com --- Grant, could you please review the way I instantiate the platform driver and call the .probe function? Documentation/misc-devices/fsl_dcm.txt | 50 +++ drivers/misc/Kconfig | 14 + drivers/misc/Makefile

Re: [PATCH] drivers/misc: introduce Freescale Data Collection Manager driver

2011-08-01 Thread Tabi Timur-B04825
Mark Brown wrote: On Mon, Aug 01, 2011 at 04:48:54PM -0500, Timur Tabi wrote: The Data Collection Manager (DCM) is a feature of the FPGA on some Freescale PowerPC reference boards that can read temperature, current, and voltage settings from the sensors on those boards. This driver exposes

Re: [PATCH] drivers/misc: introduce Freescale Data Collection Manager driver

2011-08-01 Thread Tabi Timur-B04825
that doesn't make any sense. I would have to use a custom interface to start monitoring and then another interface to stop it. Then I would query the results use the hwmon interface, but the results would be static. That just seems silly. -- Timur Tabi Linux kernel developer at Freescale

Re: GPIO IRQ on P1022

2011-07-31 Thread Tabi Timur-B04825
to need to debug this a little more. Where exactly is the freeze? Are you sure the interrupt handler is being called only once? Perhaps you're not clearing the interrupt status and your handler is being called repeatedly? -- Timur Tabi Linux kernel developer at Freescale

Re: [RFC PATCH] powerpc: 85xx: Make e500/e500v2 depend on !E500MC

2011-07-28 Thread Tabi Timur-B04825
doesn't seem to do that. It might be necessary to split the entire menu into two parts, one for e500v2 parts and one for e500mc parts. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https

Re: [RFC PATCH] powerpc: 85xx: Make e500/e500v2 depend on !E500MC

2011-07-28 Thread Timur Tabi
arch/powerpc/platforms/85xx/Kconfig:176:symbol P2040_RDB depends on PPC_E500MC -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 2/5] hugetlb: add phys addr to struct huge_bootmem_page

2011-07-24 Thread Tabi Timur-B04825
for HIGHMEM pages, I allocate bootmem to store the early data structure that stores information about the hugepage (this happens in arch-specific code in alloc_bootmem_huge_page). I would put this text in a comment in the code. -- Timur Tabi Linux kernel developer at Freescale

Re: [PATCH] [v3] tty/powerpc: introduce the ePAPR embedded hypervisor byte channel driver

2011-07-22 Thread Tabi Timur-B04825
On Fri, Jul 8, 2011 at 7:06 PM, Timur Tabi ti...@freescale.com wrote: The ePAPR embedded hypervisor specification provides an API for byte channels, which are serial-like virtual devices for sending and receiving streams of bytes.  This driver provides Linux kernel support for byte channels

Re: [PATCH 1/4] powerpc/85xx: fix interrupt number of memory-controller for P4080

2011-07-21 Thread Tabi Timur-B04825
On Thu, Jul 21, 2011 at 5:24 AM, Shaohui Xie shaohui@freescale.com wrote: Signed-off-by: Shaohui Xie shaohui@freescale.com --- Can you provide an explanation as to why the current numbers are wrong? -- Timur Tabi Linux kernel developer at Freescale

Re: [PATCH 3/4] powerpc/85xx: Merge PCI/PCI Express error management registers

2011-07-21 Thread Tabi Timur-B04825
On Thu, Jul 21, 2011 at 5:29 AM, Shaohui Xie shaohui@freescale.com wrote: +                                       /* - PCIE has no this register */ I don't understand this sentence. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc

<    1   2   3   4   5   6   7   8   9   10   >