Re: [PATCH] powerpc: i2c-mpc: make speed registers configurable via FDT

2008-07-31 Thread Timur Tabi
;i2c2_clk = gd->i2c1_clk; We need this ugliness in U-Boot. Let's take advantage of this and do something clean and elegant in the device tree. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] powerpc: i2c-mpc: make speed registers configurable via FDT

2008-07-31 Thread Timur Tabi
clock-frequency = <0xblablabla>; <-- added by U-Boot }; Note that the dfsrr property already differentiates between 8xxx and 52xx, so maybe we don't need any other device tree changes. -- Timur Tabi Linux kernel developer at Freescale ___

Re: [PATCH] powerpc: i2c-mpc: make speed registers configurable via FDT

2008-07-31 Thread Timur Tabi
perty does not exist. > I'd like to move towards a more generic uboot that gets the processor > minimally running and then use the device tree to customize as many > things as possible. But that's just my opinion. U-Boot needs to configure the I2C bus speed because U-Boot uses the

Re: [PATCH] powerpc: i2c-mpc: make speed registers configurable via FDT

2008-07-31 Thread Timur Tabi
Scott Wood wrote: > Timur Tabi wrote: >> Grant Likely wrote: >> >>> No it doesn't, it depends on the register interface to decide >>> compatibility. Clock interface is part of that. >> I don't think so. The interface for programming the cloc

Re: [PATCH] powerpc: i2c-mpc: make speed registers configurable via FDT

2008-07-31 Thread Timur Tabi
Scott Wood wrote: > Timur Tabi wrote: >> Scott Wood wrote: >>> A clock-frequency property is OK, and is in line with what we do in >>> other types of nodes. However, in the long run it might be nice to >>> introduce some sort of clock binding where, for examp

Re: [PATCH] powerpc: i2c-mpc: make speed registers configurable via FDT

2008-07-31 Thread Timur Tabi
Scott Wood wrote: > Timur Tabi wrote: >> True, but I'd rather we have a real clock-frequency property that contains >> the >> calculated I2C input frequency, than a divider. It's more consistent with >> other >> properties, > > Right, I wasn&

Re: [PATCH] powerpc: i2c-mpc: make speed registers configurable via FDT

2008-07-31 Thread Timur Tabi
e the real > source clock frequency somehow. We may introduce the SOC property > "i2c-clock-frequency", which could be fixed up by U-Boot or a pre-loader > (in case U-Boot is not used). Like for other frequency properties as well. That's what I'm proposing, but drop the &

Re: [PATCH] powerpc: i2c-mpc: make speed registers configurable via FDT

2008-07-31 Thread Timur Tabi
uld need to create another variable in the gd_t to store the divider? No thanks. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] powerpc: i2c-mpc: make speed registers configurable via FDT

2008-07-31 Thread Timur Tabi
the I2C device, but I'm pretty sure the divider is a very simple circuit that's located just outside the I2C circuitry, but it still unique to the I2C device. There is no "I2C clock" running through the SOC. -- Timur Tabi Linux kernel developer at Freescale _

Re: [PATCH] powerpc: i2c-mpc: make speed registers configurable via FDT

2008-07-31 Thread Timur Tabi
ut any undo hardship on non-U-Boot methods, I would say that it is the preferred method. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] powerpc: i2c-mpc: make speed registers configurable via FDT

2008-07-31 Thread Timur Tabi
Wolfgang Grandegger wrote: > Is it not exactly that? For me it's not a per I2C device property, at least. Of course it's a per-I2C device property. The input frequency to the I2C device is only seen by the I2C device, and no other device. -- Timur Tabi Linux kernel developer

Re: [PATCH] powerpc: i2c-mpc: make speed registers configurable via FDT

2008-07-31 Thread Timur Tabi
;current" shouldn't be in a property string. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] powerpc: i2c-mpc: make speed registers configurable via FDT

2008-07-31 Thread Timur Tabi
->i2c2_clk = gd->i2c1_clk; I think the whole point is to eliminate duplicating this code in the Linux driver. It's hideously ugly, so it should be limited as much as possible. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] powerpc: i2c-mpc: make speed registers configurable via FDT

2008-07-31 Thread Timur Tabi
be looked up. > a > shared register setting? or a register setting within the i2c device? The I2C device itself has no idea what the divider is. It only sees the result of the divider. -- Timur Tabi Linux kernel developer at Freescale ___ Lin

Re: [PATCH] powerpc: i2c-mpc: make speed registers configurable via FDT

2008-07-31 Thread Timur Tabi
e platform driver because U-Boot will put the final result in the device tree! That way, we won't need to update the platform driver *and* U-Boot for any new SOC. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing li

Re: [PATCH] powerpc: i2c-mpc: make speed registers configurable via FDT

2008-07-31 Thread Timur Tabi
uencies. Keeping it in the I2C node allows the I2C driver to reference a property directly in the node that its probing. > Aren't we talking about the /2 or /3 or /1 divider that appears to be > randomly implemented on various members of the mpc8xxx family? Yes. -- Timur Tabi Lin

Re: [PATCH] powerpc: i2c-mpc: make speed registers configurable via FDT

2008-07-31 Thread Timur Tabi
need to be exposed at all if > you'd just put that ugly code snippet into your platform driver. That's why I don't think the divider belongs in the device tree. Just put the actual resulting clock frequency in the device tree. Besides, putting that snippet in the platfo

Re: [PATCH] powerpc: i2c-mpc: make speed registers configurable via FDT

2008-07-31 Thread Timur Tabi
initializes several fields and creates several properties in the FDT today, so what's wrong with adding another one? The clock frequencies have always been calculated by U-Boot, because putting them in the device tree is a bad idea. -- Timur Tabi Linux kernel devel

Re: [i2c] [PATCH] powerpc: i2c-mpc: make speed registers configurable via FDT

2008-08-01 Thread Timur Tabi
ght I had all 8[356]xx boards covered. Did I miss some? -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [i2c] [PATCH] powerpc: i2c-mpc: make speed registers configurable via FDT

2008-08-01 Thread Timur Tabi
here to look. > Is this register in a system register bank or an i2c one? > gur->pordevsr2 & MPC85xx_PORDEVSR2_SEC_CFG That should be "guts->" I think. The global utilities is a block of miscellaneous registers, one per SOC. It&

Re: [i2c] [PATCH] powerpc: i2c-mpc: make speed registers configurable via FDT

2008-08-01 Thread Timur Tabi
Jon Smirl wrote: What about the Efika which is mpc5200 based and doesn't use uboot? How does the Efika handle the dozen other properties that U-Boot normally initializes in the device tree? -- Timur Tabi Linux Kernel Developer @ Free

Re: [i2c] [PATCH] powerpc: i2c-mpc: make speed registers configurable via FDT

2008-08-01 Thread Timur Tabi
clk; #elif defined(CONFIG_MPC831X) i2c1_clk = enc_clk; #elif defined(CONFIG_MPC837X) i2c1_clk = sdhc_clk; #endif #if !defined(CONFIG_MPC832X) i2c2_clk = csb_clk; /* i2c-2 clk is equal to csb clk */ #endif -- Timur Tabi Linux kernel developer at Freesc

Re: [PATCH] usb: add Freescale QE/CPM USB peripheral controller driver

2008-08-06 Thread Timur Tabi
(u32)(buffer)) Delete all of these. Don't use these silly macros at all. Reference the structure fields directly, and use the in_ and out_ functions directly. Using macros like these encourages unnecessary typecasts. "struct qe_bd" has been defined

Re: [RFC/PATCH 2/3] of: add of_lookup_stdout() utility function

2008-08-06 Thread Timur Tabi
nux,stdout-path property in the chosen node. I thought linux,stdout-path is deprecated are we're supposed to be using the aliases node instead? -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlab

[PATCH] powerpc: add SSI-to-DMA properties to Freescale MPC8610 HPCD device tree

2008-08-06 Thread Timur Tabi
version of the Freescale MPC8610 device drivers are merged into the mainline. Signed-off-by: Timur Tabi <[EMAIL PROTECTED]> --- Documentation/powerpc/dts-bindings/fsl/ssi.txt | 15 +++ arch/powerpc/boot/dts/mpc8610_hpcd.dts |8 +--- 2 files changed, 20 insertions

Re: [RFC/PATCH 2/3] of: add of_lookup_stdout() utility function

2008-08-07 Thread Timur Tabi
lients for input vs. output. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [RFC/PATCH 2/3] of: add of_lookup_stdout() utility function

2008-08-07 Thread Timur Tabi
Milton Miller wrote: > Why should what the hvc driver support have any effect on > what the binding should be? Because my hypervisor console driver uses the hypervisor console/tty subsystem. If the subsystem assumes one stdout/stdin device, then I must abide by that. -- Timur Tabi

Re: [RFC/PATCH 2/3] of: add of_lookup_stdout() utility function

2008-08-13 Thread Timur Tabi
nd on Sparc decoding the ihandle with the expectation that there will be further refinements to be made. Ack. -- Timur Tabi Linux Kernel Developer @ Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/lin

Re: [PATCH V2] DTC: Remove support for the legacy DTS source file format.

2008-08-15 Thread Timur Tabi
re plenty of device trees out there, especially on our BSPs, that haven't been updated yet. How about just printing a warning and saying that the device tree should be updated with the conversion tool? -- Timur Tabi Linux kernel developer at Freescale __

[PATCH] powerpc: fix memory leaks in QE library

2008-08-18 Thread Timur Tabi
Fix two memory leaks in the Freescale QE library: add a missing kfree() in ucc_fast_init() if the ioremap() fails, and update ucc_fast_free() to call iounmap() on uf_regs. Based on a patch from Tony Breeds <[EMAIL PROTECTED]>. Signed-off-by: Timur Tabi <[EMAIL PROTECTED]> ---

Re: [PATCH] powerpc: fix memory leaks in QE library

2008-08-20 Thread Timur Tabi
sweep o the QE code just to make sure there aren't even more. Of course, it would have been nice if someone had looked up the maintainer of the QE library in the MAINTAINERS file and notified me about these bugs. -- Timur Tabi Linux kernel developer at Freescale ___

[PATCH v2] powerpc: fix memory leaks in QE library

2008-08-20 Thread Timur Tabi
Fix two memory leaks in the Freescale QE library: add a missing kfree() in ucc_fast_init() and ucc_slow_init() if the ioremap() fails, and update ucc_fast_free() and ucc_slow_free() to call iounmap() if necessary. Based on a patch from Tony Breeds <[EMAIL PROTECTED]>. Signed-off-by: Timu

Re: [PATCH] powerpc: add SSI-to-DMA properties to Freescale MPC8610 HPCD device tree

2008-09-04 Thread Timur Tabi
On Wed, Aug 6, 2008 at 11:48 AM, Timur Tabi <[EMAIL PROTECTED]> wrote: > Add the fsl,playback-dma and fsl,capture-dma properties to the Freescale > MPC8610 HPCD device tree. These properties connect the SSI nodes to the > DMA nodes for the DMA channels that the SSI should use.

Re: [PATCH] Pass actual dev ptr to dma_* in ucc and cpm_uart serial

2008-09-09 Thread Timur Tabi
lized in the CPM UART driver? (P.S. Becky - please CC: me on any UCC UART or QE LIB patches) -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

[PATCH] powerpc: fix interrupt values for DMA2 in MPC8610 HPCD device tree

2008-09-09 Thread Timur Tabi
The interrupt values in a device tree must be 16 greater than the actual interrupt number for a given device. The interrupt property for the DMA channels for DMA2 in the MPC8610 HPCD device tree was using the raw values, not the adjusted ones. Signed-off-by: Timur Tabi <[EMAIL PROTEC

[PATCH v2] powerpc: fix interrupt values for DMA2 in MPC8610 HPCD device tree

2008-09-09 Thread Timur Tabi
from 0. In the MPC8610 HPCD device tree, the interrupt properties for the DMA channels for DMA2 were not the adjusted values. This patch fixes that. Signed-off-by: Timur Tabi <[EMAIL PROTECTED]> --- I have no idea how this was missed for so long, but this patch is a must-fix for 2.6.27. (c

Re: [PATCH V2] Pass actual dev ptr to dma_* in ucc and cpm_uart serial

2008-09-12 Thread Timur Tabi
On Fri, Sep 12, 2008 at 10:42 AM, Becky Bruce <[EMAIL PROTECTED]> wrote: > Signed-off-by: Becky Bruce <[EMAIL PROTECTED]> Acked-By: Timur Tabi <[EMAIL PROTECTED]> The changelog could be a little beefier, though. I'm not a fan of having the changelog be an ex

Re: [git pull] Please pull powerpc.git merge branch

2008-09-18 Thread Timur Tabi
t;channels for DMA2 were not the adjusted values. This fixes that. Did you edit this patch when you pulled it from Kumar's repo? The commit in Kumar's repo says "This patch fixes that.", which is what I wrote. However, in your tree, the word "patch&quo

[PATCH] fsl-dma: allow Freescale Elo DMA driver to be compiled as a module

2008-09-19 Thread Timur Tabi
although we can call of_platform_bus_probe() to probe the DMA channels, there is no of_platform_bus_remove(). Therefore, the DMA channels must be manually probed. Signed-off-by: Timur Tabi <[EMAIL PROTECTED]> --- (Reposting because I forgot to CC: the maintainers) This patch is for the 2.6.28

[PATCH] powerpc: remove support for bootmem-allocated memory for the DIU driver

2008-09-23 Thread Timur Tabi
Early versions of the Freescale DIU framebuffer driver depended on a bootmem allocation of memory for the video buffer. The need for this feature was removed in commit 6b51d51a, so now we can remove the platform-specific code that allocated that memory. Signed-off-by: Timur Tabi <[EM

Re: Merge linuxppc-embedded with linuxppc-dev

2008-09-23 Thread Timur Tabi
> I also vote to kill the separate embedded list. It has such low traffic, > and it seems like a lot of messages end up cross-posted to linuxppc-dev, > anyway. I also agree that we should kill linuxppc-embedded. -- Timur Tabi Linux kernel developer at

Re: [PATCH V2] powerpc: Fix Book-E watchdog timer interval setting

2008-09-23 Thread Timur Tabi
lt;30)|(((63-63)&0x3c)<<15))", which is equal to 0. Shouldn't WDTP_MASK be equal to "(3 << 30) | (15 << 15)"? -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

[PATCH] fsldma: remove internal self-test from Freescale Elo DMA driver

2008-09-23 Thread Timur Tabi
e (dmatest), the internal self-test code is not useful anyway. It is extremely unlikely that the test will fail in normal usage. It may have been helpful during development, but not any more. Signed-off-by: Timur Tabi <[EMAIL PROTECTED]> --- This patch is for 2.6.28. drivers/dma

Re: [PATCH v2] powerpc: enforce sane MAX_ORDER

2008-09-24 Thread Timur Tabi
On Wed, Sep 24, 2008 at 9:29 AM, Johannes Berg <[EMAIL PROTECTED]> wrote: > Indeed, it makes little sense to allow you to set more than the address > space, so here's a version with max 64. Acked-by: Timur Tabi <[EMAIL PROTECTED]> However, the max is actually less than

Re: [PATCH] fsl-dma: allow Freescale Elo DMA driver to be compiled as a module

2008-09-24 Thread Timur Tabi
Kumar Gala wrote: > Dan, any update on this patch? I'm going to post a new version. This whole thing is more complicated than I thought. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.o

[PATCH v2] fsl-dma: allow Freescale Elo DMA driver to be compiled as a module

2008-09-24 Thread Timur Tabi
although we can call of_platform_bus_probe() to probe the DMA channels, there is no of_platform_bus_remove(). Instead, the DMA channels are manually probed, similar to what fsl_elbc_nand.c does. Signed-off-by: Timur Tabi <[EMAIL PROTECTED]> --- v2: updated per comments This patch is for the

Re: [PATCH v2] fsl-dma: allow Freescale Elo DMA driver to be compiled as a module

2008-09-25 Thread Timur Tabi
-kernel, this code is initialized before most drivers, so it's ready when the drivers are loaded. > Acked-by: Li Yang <[EMAIL PROTECTED]> Thanks. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-d

Re: [PATCH v2] fsl-dma: allow Freescale Elo DMA driver to be compiled as a module

2008-09-25 Thread Timur Tabi
e the probability that fsldma is already present when DMA clients are loaded/initialized and register. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH v2] fsl-dma: allow Freescale Elo DMA driver to be compiled as a module

2008-09-25 Thread Timur Tabi
tion, please. Technically, it doesn't *matter* in that nothing will break, but so what? It's nicer if the DMA driver is already available when the client drivers load, so that they can use the DMA facilities right away. -- Timur Tabi

[PATCH] powerpc: remove CHRP and PMAC support from defconfigs, fix Kconfigs

2008-09-26 Thread Timur Tabi
The Kconfig files for PowerPC CHRP and PMAC support had "default=y" for some Kconfig options, and this caused support for CHRP and PMAC platforms to be enabled incorrectly for several platforms. Fix the Kconfigs and the affected defconfigs. Signed-off-by: Timur Tabi <[EMAIL PROTECTE

[PATCH] powerpc: fix conflict with Elo DMA driver in MPC8610 device tree

2008-09-26 Thread Timur Tabi
o "fsl,ssi-dma-channel". This works because the sound drivers don't actually check the compatible property when it grabs DMA channels. Also update dma.txt and ssi.txt with this information. Signed-off-by: Timur Tabi <[EMAIL PROTECTED]> --- Documentation/powerpc/

[PATCH] powerpc: make Freescale QE support a selectable Kconfig option

2008-10-02 Thread Timur Tabi
(like UCC GETH). Fortunately, all the current relevant defconfigs do that already. Signed-off-by: Timur Tabi <[EMAIL PROTECTED]> --- This patch should be applied to Kumar's branch for 2.6.28 patches. arch/powerpc/platforms/83xx/Kconfig |4 arch/powerpc/platforms/Kconfig

Re: [PATCH] powerpc: make Freescale QE support a selectable Kconfig option

2008-10-03 Thread Timur Tabi
Is that intentional? -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] powerpc: make Freescale QE support a selectable Kconfig option

2008-10-03 Thread Timur Tabi
ee now: [*] Networking support ---> Device Drivers ---> File systems ---> [*] QE GPIO support Library routines ---> Kernel hacking ---> -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@

[PATCH v2] powerpc: make Freescale QE support a selectable Kconfig option

2008-10-03 Thread Timur Tabi
(like UCC GETH). Fortunately, all the current relevant defconfigs do that already. Signed-off-by: Timur Tabi <[EMAIL PROTECTED]> --- This patch should be applied to Kumar's branch for 2.6.28 patches. arch/powerpc/platforms/83xx/Kconfig |5 - arch/powerpc/platforms/85xx/Kco

Re: [PATCH] powerpc: make Freescale QE support a selectable Kconfig option

2008-10-03 Thread Timur Tabi
config |2 -- > arch/powerpc/platforms/Kconfig | 36 > > arch/powerpc/sysdev/qe_lib/Kconfig | 35 --- > 3 files changed, 36 insertions(+), 37 deletions(-) > delete mode 100644 arch/powerpc/s

Re: [PATCH v2] powerpc: make Freescale QE support a selectable Kconfig option

2008-10-03 Thread Timur Tabi
t for bootmem-allocated memory for the DIU driver -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] powerpc: remove CHRP and PMAC support from defconfigs, fix Kconfigs

2008-10-06 Thread Timur Tabi
On Fri, Sep 26, 2008 at 12:19 PM, Timur Tabi <[EMAIL PROTECTED]> wrote: > The Kconfig files for PowerPC CHRP and PMAC support had "default=y" for some > Kconfig options, and this caused support for CHRP and PMAC platforms to be > enabled incorrectly for several platforms.

Re: [PATCH] powerpc: remove CHRP and PMAC support from defconfigs, fix Kconfigs

2008-10-08 Thread Timur Tabi
On Fri, Sep 26, 2008 at 12:19 PM, Timur Tabi <[EMAIL PROTECTED]> wrote: > The Kconfig files for PowerPC CHRP and PMAC support had "default=y" for some > Kconfig options, and this caused support for CHRP and PMAC platforms to be > enabled incorrectly for several platforms.

Re: [PATCH] powerpc: remove CHRP and PMAC support from defconfigs, fix Kconfigs

2008-10-08 Thread Timur Tabi
to keep it in, please send another one that does the above. Ok. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

[PATCH] powerpc: remove default=y from PMAC and CHRP Kconfigs

2008-10-08 Thread Timur Tabi
Remove the "default y" from the Kconfig options for CHRP, PMAC, and PMAC64 platforms. This patch is a follow-up to "remove CHRP and PMAC support from defconfigs, fix Kconfigs", which was applied incompletely. Signed-off-by: Timur Tabi <[EMAIL PROTECTED]> --- Ben, i

Re: [PATCH] powerpc: remove default=y from PMAC and CHRP Kconfigs

2008-10-08 Thread Timur Tabi
atch. The defconfig changes are just to clean up the mess that "default y" left behind. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] powerpc: remove default=y from PMAC and CHRP Kconfigs

2008-10-09 Thread Timur Tabi
x27;s a good thing? -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] powerpc: remove default=y from PMAC and CHRP Kconfigs

2008-10-09 Thread Timur Tabi
HRP and PMAC aren't following the rules that everyone else is following. Why? -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: Compact Flash on 8349mITX

2008-10-09 Thread Timur Tabi
ou try using the latest BSP kernel and see if the problem is present there? Sometimes the BSP has a hacked-up kernel that addresses hardware issues, but these patches aren't pushed upstream, so the mainline kernel has problems. -- Timur Tabi Linux kernel developer at Freescale _

Re: [PATCH] powerpc: remove default=y from PMAC and CHRP Kconfigs

2008-10-09 Thread Timur Tabi
guaranteed to get a kernel > binary somewhere in the tree that would work on all of them :) Again, not relevant. One giant kernel that works on a Freescale embedded system *and* an IBM mainframe is useless. No one would actually ever do that. > Genesi, Manager, Developer Relation

Re: Compact Flash on 8349mITX

2008-10-09 Thread Timur Tabi
On Thu, Oct 9, 2008 at 12:00 PM, Jeff Borlin <[EMAIL PROTECTED]> wrote: > > Can you point me to where that can be found? It's on the CD that came with the board. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mail

Re: [PATCH] powerpc: remove default=y from PMAC and CHRP Kconfigs

2008-10-09 Thread Timur Tabi
hat embedded platforms aren't as important as the exalted CHRP is bollocks. All platforms should be treated equally. And like I said earlier, PMAC platforms aren't even being built any more, so it's ridiculous to consider that the default. -- Ti

Re: [PATCH] powerpc: remove default=y from PMAC and CHRP Kconfigs

2008-10-09 Thread Timur Tabi
Sven Luther wrote: > You just turn it on by default for 64bit and idsable it for 32bit :) That hack might work for now, but it will break once we have 64-bit embedded systems. Regardless, it doesn't address the core issue - there should be no default platform for PowerPC. -- Timur Ta

Re: [PATCH] powerpc: remove default=y from PMAC and CHRP Kconfigs

2008-10-09 Thread Timur Tabi
means updating > configs will pick up platforms they dont want. As far as I know, CHRP and PMAC are the only PowerPC platforms that default to Y. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

[PATCH] powerpc: disable CHRP and PMAC support in various defconfigs

2008-10-10 Thread Timur Tabi
Because CHRP and PMAC are by default enabled, several non-CHRP and non-PMAC PowerPC defconfigs will have these Kconfig options set erroneously. Signed-off-by: Timur Tabi <[EMAIL PROTECTED]> --- arch/powerpc/configs/83xx/asp8347_defconfig |2 ++ arch/powerpc/config

[PATCH] powerpc: reserve two DMA channels for audio in MPC8610 HPCD device tree

2008-10-10 Thread Timur Tabi
or general purpose use. We change the compatible properties for these channels "fsl,ssi-dma-channel". This works because the sound drivers don't actually check the compatible property when it grabs channels. Signed-off-by: Timur Tabi <[EMAIL PROTECTED]> --- arch/powerpc/boot/dts/

[PATCH] powerpc: document the "fsl, ssi-dma-channel" compatible property

2008-10-10 Thread Timur Tabi
the sound drivers. Signed-off-by: Timur Tabi <[EMAIL PROTECTED]> --- Documentation/powerpc/dts-bindings/fsl/dma.txt | 13 +++-- Documentation/powerpc/dts-bindings/fsl/ssi.txt | 20 ++-- 2 files changed, 25 insertions(+), 8 deletions(-) diff --git a/Documenta

Re: Please pull from 'for-2.6.28' branch

2008-10-21 Thread Timur Tabi
has changed since then, but what's the point of having a merge window if you don't actually merge the code? -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH v2 5/7] powerpc/85xx: Add MChk handler for SRIO port

2010-08-03 Thread Timur Tabi
sl_rio.c:248: error: (Each undeclared identifier is reported only once arch/powerpc/sysdev/fsl_rio.c:248: error: for each function it appears in.) make[1]: *** [arch/powerpc/sysdev/fsl_rio.o] Error 1 -- Timur Tabi Linux kernel developer at Freescale ___

[PATCH] asoc/multi-component: fsl: add support for disabled SSI nodes

2010-08-04 Thread Timur Tabi
Add support for adding "status = disabled" to an SSI node to incidate that it is not wired on the board. This replaces the not-so-intuitive previous method of omitting a codec-handle property. Signed-off-by: Timur Tabi --- Kumar, would you please ACK the device-tree portion of this

Re: [PATCH 3/3] powerpc/85xx: Cleanup QE initialization for MPC85xxMDS boards

2010-08-18 Thread Timur Tabi
eally testing mpc85xx_[smp_]defconfig, since there are now *two* failures (this one, and CONFIG_RAPIDIO) with these defconfig files. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] of/device: Replace struct of_device with struct of_platform

2010-08-19 Thread Timur Tabi
soc/fsl from this commit. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH] powerpc/p1022: add probing for individual DMA channels, not just DMA controllers

2010-08-19 Thread Timur Tabi
Like the MPC8610 HPCD, the P1022DS ASoC DMA driver probes on individual DMA channel nodes, so the DMA controller nodes' compatible string must be listed in p1022_ds_ids[] to work. Signed-off-by: Timur Tabi --- This is for -next. I don't know why I forgot to include this change in th

Re: [PATCH] of/device: Replace struct of_device with struct of_platform

2010-08-19 Thread Timur Tabi
Grant Likely wrote: > On Thu, Aug 19, 2010 at 2:36 PM, Timur Tabi wrote: >> On Sun, Aug 1, 2010 at 2:57 AM, Grant Likely >> wrote: >> >>> sound/soc/fsl/mpc8610_hpcd.c |4 +- >> >> This file is/was significantly rewritten for 2.6.

[PATCH] hvc_console: fix dropping of characters when output byte channel is full

2010-08-20 Thread Timur Tabi
st of the buffer. So change hvc_console_print() to just loop and call put_chars() again if it returns a 0 return code. This change makes hvc_console_print() behave more like hvc_push(), which does check for a 0 return code and re-schedules itself. Signed-off-by: Timur Tabi --- drivers

Re: [PATCH 1/2] powerpc: Make rwsem use "long" type

2010-08-23 Thread Timur Tabi
On Fri, Aug 20, 2010 at 12:14 AM, Benjamin Herrenschmidt wrote: >  static inline int rwsem_is_locked(struct rw_semaphore *sem) >  { > -       return (sem->count != 0); > +       return sem->count != 0; >  } Does this change make the code do anything different? -- Ti

Re: [PATCH] powerpc/fsl_soc: Search all global-utilities nodes for rstccr

2010-08-28 Thread Timur Tabi
f_iomap() fails, we jump to the next global-utilities node? Perhaps you need a 'break' after the printk()? > +       } > + > +       if (!rstcr && ppc_md.restart == fsl_rstcr_restart) Wouldn't it make more sense to assign fsl_rstcr_restart to ppc_md.res

Re: [PATCH 5/7] arch/powerpc/sysdev/qe_lib/qe.c: Add of_node_put to avoid memory leak

2010-08-30 Thread Timur Tabi
Julia Lawall wrote: > Add a call to of_node_put in the error handling code following a call to > of_find_compatible_node. Acked-by: Timur Tabi Thanks, Julia. Your work in finding these kinds of bugs is very much appreciated. ___ Linuxp

Re: [PATCH] powerpc/fsl_soc: Search all global-utilities nodes for rstccr

2010-08-31 Thread Timur Tabi
find a valid fsl,has-rstcr property? > > Again I'm not entirely sure, I left this as it was before. Is there another > way to reset the board if the rstcr node was not found correctly? Not on our 85xx boards. On 83xx, there's mpc83xx_restart(). I just don't like "ppc_

Re: [linuxppc-release] [PATCH 1/2] powerpc/mm: Assume first cpu is boot_cpuid not 0

2010-09-01 Thread Timur Tabi
Matthew McClintock wrote: > +#ifndef CONFIG_SMP > stale_map[0] = alloc_bootmem(CTX_MAP_SIZE); > +#else > + stale_map[boot_cpuid] = alloc_bootmem(CTX_MAP_SIZE); So you're saying that even on a non-SMP kernel, boot_cpuid might not be zero? ___ L

Re: [PATCH v2] powerpc/fsl_soc: Search all global-utilities nodes for rstccr

2010-09-01 Thread Timur Tabi
Matthew McClintock wrote: > The first global-utilities node might not contain the rstcr > property, so we should search all the nodes > > Signed-off-by: Matthew McClintock Acked-by: Timur Tabi ___ Linuxppc-dev mailing list

Re: [PATCH 1/4] drivers/serial/ucc_uart.c: Add of_node_put to avoid memory leak

2010-09-01 Thread Timur Tabi
possible first to jump to code that frees qe_port > and then to jump to code that also puts np. Acked-by: Timur Tabi Thanks, Julia. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@list

[PATCH 1/2] powerpc/85xx: add ngPIXIS FPGA device tree node to the P1022DS board

2010-09-09 Thread Timur Tabi
The device tree for Freescale's P1022DS reference board is missing the node for the ngPIXIS FPGA. Signed-off-by: Timur Tabi --- arch/powerpc/boot/dts/p1022ds.dts |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/arch/powerpc/boot/dts/p1022ds.dts b/arch/po

[PATCH 2/2] powerpc/85xx: add DIU support to the Freecale P1022DS reference board

2010-09-09 Thread Timur Tabi
The Freescale P1022DS has an on-chip video controller called the DIU, and a driver for this device already exists. Update the platform file for the P1022DS reference board to enable the driver, and update the defconfig for Freescale MPC85xx boards to add the driver. Signed-off-by: Timur Tabi

Re: CONFIG_PROVE_LOCKING broken on 83xx (and all of powerpc?)

2010-09-09 Thread Timur Tabi
These two config options are related. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: CONFIG_PROVE_LOCKING broken on 83xx (and all of powerpc?)

2010-09-09 Thread Timur Tabi
; > I don't know if this is a U-Boot problem or a Linux problem. I have no > idea how to fix the bug. I wonder if this patch that I wrote for U-Boot will fix the problem: http://lists.denx.de/pipermail/u-boot/2010-May/071822.html -- Timur Tabi Linu

Re: CONFIG_PROVE_LOCKING broken on 83xx (and all of powerpc?)

2010-09-09 Thread Timur Tabi
that is mapped? If so, that means that Linux can't even access all of its BSS at this point. Somehow, I doubt that. Can you try increasing the size of CONFIG_SYS_BOOTMAPSZ? Combined with my always-relocate-fdt, I think this will force the FDT to be placed higher in memory.

Re: CONFIG_PROVE_LOCKING broken on 83xx (and all of powerpc?)

2010-09-09 Thread Timur Tabi
the FDT was located between 8MB and 16MB, and if so, my patch would have made a difference. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: CONFIG_PROVE_LOCKING broken on 83xx (and all of powerpc?)

2010-09-09 Thread Timur Tabi
Boot creates for the kernel. When the kernel initializes the MMU for its own purposes, does it limit anything to 16MB? I seriously doubt it. > You'll see that your patch now relocated the FDT. It didn't cause any > problems. I'll post to the thread on the U-Boot ML. Yes, ple

Re: [PATCH v2 3/3][MTD] P4080/mtd: Fix the freescale lbc issue with 36bit mode

2010-09-13 Thread Timur Tabi
sized integer types (like u8, u16, u32). If you want an integer of a specific size, you should use a sized integer type. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs

Re: [PATCH v2 3/3][MTD] P4080/mtd: Fix the freescale lbc issue with 36bit mode

2010-09-13 Thread Timur Tabi
. Obviously, you have to make some assumptions about sizeof(int), but that assumption should be nothing more than "it should be big enough for these small numbers that I'm using". > I see people use u32 and the friends too much. I agree with that. -- Tim

Re: [PATCH v2 3/3][MTD] P4080/mtd: Fix the freescale lbc issue with 36bit mode

2010-09-13 Thread Timur Tabi
can't say that sizeof(int) == 4, and you can't say that sizeof(int) > 4, then you certainly can't say that sizeof(int) >= 4. -- Timur Tabi Linux kernel developer at Freescale ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.or

Re: [PATCH v2 3/3][MTD] P4080/mtd: Fix the freescale lbc issue with 36bit mode

2010-09-14 Thread Timur Tabi
t should >> be u32. > But the return of this value is ONLY used for br comparing. It is big endia. > Thanks. No, Scott is right. The return value is native-endian (NE). You've converted it from BE to NE already. -- Timur Tabi Linux kernel developer at Freescale ___

Re: [PATCH] hvc_console: fix dropping of characters when output byte channel is full

2010-09-14 Thread Timur Tabi
Andrew, Would you please take a moment to review this patch I sent last month? I'd like for it to be incorporated into 2.6.37, but I'm having a hard time finding someone to consider it. Thanks. On Fri, Aug 20, 2010 at 1:45 PM, Timur Tabi wrote: > hvc_console_print() calls t

<    1   2   3   4   5   6   7   8   9   10   >