Re: [BUG] fec_mpc52xx: Don't call mpc52xx_fec_reset() in ISR

2008-08-15 Thread Wolfram Sang
Hello Wolfgang (and all), On Wed, Aug 13, 2008 at 04:12:17PM +0200, Wolfgang Grandegger wrote: > ...but I prepared a patch to do the reset in the process context. Would be > nice if you could give the patch below a try. Will do later. Thanks! Still, I think it might be useful to discuss if a com

Re: [BUG] fec_mpc52xx: Don't call mpc52xx_fec_reset() in ISR

2008-08-13 Thread Wolfgang Grandegger
Hi Jürgen, Juergen Beisert wrote: On Donnerstag, 10. Juli 2008, Grant Likely wrote: On Thu, Jul 10, 2008 at 02:39:09PM +0200, Wolfram Sang wrote: Hello, today, I was debugging a kernel crash on a board with a MPC5200B using 2.6.26-rc9. I found the following code in drivers/net/fec_mpc52xx.c:

Re: [BUG] fec_mpc52xx: Don't call mpc52xx_fec_reset() in ISR

2008-08-13 Thread Juergen Beisert
On Donnerstag, 10. Juli 2008, Grant Likely wrote: > On Thu, Jul 10, 2008 at 02:39:09PM +0200, Wolfram Sang wrote: > > Hello, > > > > today, I was debugging a kernel crash on a board with a MPC5200B using > > 2.6.26-rc9. I found the following code in drivers/net/fec_mpc52xx.c: > > > > > I assume th

Re: [BUG] fec_mpc52xx: Don't call mpc52xx_fec_reset() in ISR

2008-07-26 Thread Grant Likely
On Thu, Jul 10, 2008 at 02:39:09PM +0200, Wolfram Sang wrote: > Hello, > > today, I was debugging a kernel crash on a board with a MPC5200B using > 2.6.26-rc9. I found the following code in drivers/net/fec_mpc52xx.c: > > static irqreturn_t mpc52xx_fec_interrupt(int irq, void *dev_id) > { > [...]

Re: [BUG] fec_mpc52xx: Don't call mpc52xx_fec_reset() in ISR

2008-07-10 Thread Grant Likely
On Thu, Jul 10, 2008 at 02:39:09PM +0200, Wolfram Sang wrote: > Hello, > > today, I was debugging a kernel crash on a board with a MPC5200B using > 2.6.26-rc9. I found the following code in drivers/net/fec_mpc52xx.c: > I assume the proper thing to do is to set a flag in the ISR and handle > the s

[BUG] fec_mpc52xx: Don't call mpc52xx_fec_reset() in ISR

2008-07-10 Thread Wolfram Sang
Hello, today, I was debugging a kernel crash on a board with a MPC5200B using 2.6.26-rc9. I found the following code in drivers/net/fec_mpc52xx.c: static irqreturn_t mpc52xx_fec_interrupt(int irq, void *dev_id) { [...] /* on fifo error, soft-reset fec */ if (ievent & (FEC_IEVENT_R