Re: [PATCH, net] ibmvnic: fix firmware version when no firmware level has been provided by the VIOS server

2018-02-02 Thread Tyrel Datwyler
On 02/02/2018 06:37 AM, Desnes Augusto Nunes do Rosário wrote: > Hello Tyrel, > > I concur with your observations, but since this patch has already been > merged, I'll address them in another patch. Fair enough. I didn't realize David had already merged it till after I sent my review. -Tyrel

Re: [PATCH, net] ibmvnic: fix firmware version when no firmware level has been provided by the VIOS server

2018-02-02 Thread Desnes Augusto Nunes do Rosário
Hello Tyrel, I concur with your observations, but since this patch has already been merged, I'll address them in another patch. Thank you for your review, On 02/01/2018 07:02 PM, Tyrel Datwyler wrote: On 02/01/2018 10:04 AM, Desnes Augusto Nunes do Rosario wrote: Older versions of VIOS serv

Re: [PATCH, net] ibmvnic: fix firmware version when no firmware level has been provided by the VIOS server

2018-02-02 Thread Desnes Augusto Nunes do Rosário
Hello David, Thank you for your review and the heads up about protocol. On 02/01/2018 05:59 PM, David Miller wrote: From: Desnes Augusto Nunes do Rosario Date: Thu, 1 Feb 2018 16:04:30 -0200 Older versions of VIOS servers do not send the firmware level in the VPD buffer for the ibmvnic driv

Re: [PATCH, net] ibmvnic: fix firmware version when no firmware level has been provided by the VIOS server

2018-02-01 Thread Tyrel Datwyler
On 02/01/2018 10:04 AM, Desnes Augusto Nunes do Rosario wrote: > Older versions of VIOS servers do not send the firmware level in the VPD > buffer for the ibmvnic driver. Thus, not only the current message is mis- > leading but the firmware version in the ethtool will be NULL. Therefore, > this pat

Re: [PATCH, net] ibmvnic: fix firmware version when no firmware level has been provided by the VIOS server

2018-02-01 Thread David Miller
From: Desnes Augusto Nunes do Rosario Date: Thu, 1 Feb 2018 16:04:30 -0200 > Older versions of VIOS servers do not send the firmware level in the VPD > buffer for the ibmvnic driver. Thus, not only the current message is mis- > leading but the firmware version in the ethtool will be NULL. Theref

[PATCH, net] ibmvnic: fix firmware version when no firmware level has been provided by the VIOS server

2018-02-01 Thread Desnes Augusto Nunes do Rosario
Older versions of VIOS servers do not send the firmware level in the VPD buffer for the ibmvnic driver. Thus, not only the current message is mis- leading but the firmware version in the ethtool will be NULL. Therefore, this patch fixes the firmware string and its warning. Fixes: 4e6759be28e4 ("ib