Changes from previous version:
- Add FIFO status error checking code before a DMA transaction starts
and after it is completed.
- Fix an incorrect check in the previous patch causing spurious "dma
table too small" errors.
Tim
This patch adds MDMA/UDMA support (using BestComm for DMA) on the MPC52
Hi,
Against which kernel is this patch against ?
Regards,
Daniel.
Tim Yamin wrote:
> Changes from previous version:
>
> - Add FIFO status error checking code before a DMA transaction starts
> and after it is completed.
> - Fix an incorrect check in the previous patch causing spurious "dma
On Fri, Jun 27, 2008 at 01:44:08PM +0100, Tim Yamin wrote:
> diff -Nurp linux-2.6.26-rc6/arch/powerpc/sysdev/bestcomm/bestcomm.c
> linux-2.6.26-rc6.new/arch/powerpc/sysdev/bestcomm/bestcomm.c
> --- linux-2.6.26-rc6/arch/powerpc/sysdev/bestcomm/bestcomm.c 2008-03-18
> 15:49:53.0 +
> +
Hi Grant,
Thanks for the feedback. New version is attached.
> Is this a bug fix? If so, please put it into a separate patch.
I suppose so, yes. If Ethernet has higher priority than ATA, you can
get a deadlock if you try and download a large file over a LAN to
disk, for example. But given that n
On Wed, Jul 02, 2008 at 01:48:39PM +0100, Tim Yamin wrote:
> Hi Grant,
>
> Thanks for the feedback. New version is attached.
Your welcome. The patch is looking pretty good. Some more comments
below.
> > > -#define BCOM_IPR_ATA_RX 4
> > > -#define BCOM_IPR_ATA_TX 3
> > > +#def
On Wed, Jul 2, 2008 at 6:30 PM, Grant Likely <[EMAIL PROTECTED]> wrote:
> I know that only ATA uses this; but it is nice to have fixes to things
> that are obviously wrong in existing code to be split into their own
> patches. That way, even if the ATA patch gets backed out, the bug fix
> will rem
On Thu, 2008-07-03 at 16:35 +0100, Tim Yamin wrote:
> >> +static void
> >> +mpc52xx_bmdma_start(struct ata_queued_cmd *qc)
> >> +{
> >> + struct ata_port *ap = qc->ap;
> >> + struct mpc52xx_ata_priv *priv = ap->host->private_data;
> >> +
> >> + /* LocalBus lock */
> >> + while (test
On Fri, Jul 04, 2008 at 09:47:03AM +1000, Benjamin Herrenschmidt wrote:
> On Thu, 2008-07-03 at 16:35 +0100, Tim Yamin wrote:
> > >> +static void
> > >> +mpc52xx_bmdma_start(struct ata_queued_cmd *qc)
> > >> +{
> > >> + struct ata_port *ap = qc->ap;
> > >> + struct mpc52xx_ata_priv *priv =
On Thu, Jul 03, 2008 at 04:35:27PM +0100, Tim Yamin wrote:
> There's also what I believe to be a hardware bug if you have high levels
> of BestComm ATA DMA activity along with heavy LocalPlus Bus activity;
> the address bus seems to sometimes get corrupted with ATA commands while
> the LocalPlus Bu
