RE: [PATCH] [POWERPC] Fix return value check logic

2008-06-15 Thread Medve Emilian
Hello Paul, You're right, thanks for checking. In that case: Acked-by: Michael Ellerman [EMAIL PROTECTED] I wonder what did you decide about this patch? Cheer, Emil. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org

RE: [PATCH] [POWERPC] Fix return value check logic

2008-05-23 Thread Medve Emilian
Hello Michael, That won't work if CONFIG_DEBUG_FS is not defined, because in that case debugfs_create_file() returns -ENODEV. Will respin. Thanks, Emil. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org

RE: [PATCH] [POWERPC] Fix return value check logic

2008-05-23 Thread Medve Emilian
Hello Michael, That won't work if CONFIG_DEBUG_FS is not defined, because in that case debugfs_create_file() returns -ENODEV. Will respin. At a second glance in arch/powerpc/Kconfig.debug, VIRQ_DEBUG depends on DEBUG_FS so I think that the patch should work as is. Cheers, Emil.

RE: [PATCH] [POWERPC] Fix return value check logic

2008-05-23 Thread Michael Ellerman
On Fri, 2008-05-23 at 07:39 -0700, Medve Emilian wrote: Hello Michael, That won't work if CONFIG_DEBUG_FS is not defined, because in that case debugfs_create_file() returns -ENODEV. Will respin. At a second glance in arch/powerpc/Kconfig.debug, VIRQ_DEBUG depends on

[PATCH] [POWERPC] Fix return value check logic

2008-05-22 Thread Emil Medve
debugfs_create_file() return a non-NULL (non-zero) value in case of success This fixes this non-critical boot-time debuging error message: [1.316386] calling irq_debugfs_init+0x0/0x50 [1.316399] initcall irq_debugfs_init+0x0/0x50 returned -12 after 0 msecs [1.316411] initcall

Re: [PATCH] [POWERPC] Fix return value check logic

2008-05-22 Thread Michael Ellerman
On Thu, 2008-05-22 at 14:49 -0500, Emil Medve wrote: debugfs_create_file() return a non-NULL (non-zero) value in case of success This fixes this non-critical boot-time debuging error message: [1.316386] calling irq_debugfs_init+0x0/0x50 [1.316399] initcall