Re: [PATCH] [POWERPC] i2c: fix build breakage introduced by OF helpers

2008-04-19 Thread David Miller
From: Paul Mackerras [EMAIL PROTECTED] Date: Sat, 19 Apr 2008 15:22:37 +1000 David Miller writes: From: Paul Mackerras [EMAIL PROTECTED] Date: Sat, 19 Apr 2008 14:04:32 +1000 It's OK if this breaks the sparc64 allmodconfig build, I'll take care of this once it's merged in. It

Re: [PATCH] [POWERPC] i2c: fix build breakage introduced by OF helpers

2008-04-19 Thread Jean Delvare
On Fri, 18 Apr 2008 23:11:28 -0700 (PDT), David Miller wrote: From: Paul Mackerras [EMAIL PROTECTED] Date: Sat, 19 Apr 2008 15:22:37 +1000 David Miller writes: From: Paul Mackerras [EMAIL PROTECTED] Date: Sat, 19 Apr 2008 14:04:32 +1000 It's OK if this breaks the sparc64

Re: [PATCH] [POWERPC] i2c: fix build breakage introduced by OF helpers

2008-04-19 Thread David Miller
From: Jean Delvare [EMAIL PROTECTED] Date: Sat, 19 Apr 2008 11:09:34 +0200 Guys, you're doing things the wrong way around. Breaking things to fix them later is not OK, it's a pain for testers and also when bisecting the kernel. Everything should still work after merging the powerpc tree.

Re: [PATCH] [POWERPC] i2c: fix build breakage introduced by OF helpers

2008-04-19 Thread Paul Mackerras
Jean Delvare writes: Guys, you're doing things the wrong way around. Breaking things to fix them later is not OK, it's a pain for testers and also when bisecting the kernel. Everything should still work after merging the powerpc tree. Dave, if you need to loosen the dependency, you should do

[PATCH] [POWERPC] i2c: fix build breakage introduced by OF helpers

2008-04-18 Thread Jochen Friedrich
Fix build breakage introduced in commit [POWERPC] i2c: OF helpers for the i2c API. If i2c-core is compiled as module, the helper needs to be compiled as module, as well. Rename i2c.c to of_i2c.c to avoid name space conflict. Signed-off-by: Jochen Friedrich [EMAIL PROTECTED] ---

Re: [PATCH] [POWERPC] i2c: fix build breakage introduced by OF helpers

2008-04-18 Thread Paul Mackerras
Jochen Friedrich writes: Fix build breakage introduced in commit [POWERPC] i2c: OF helpers for the i2c API. If i2c-core is compiled as module, the helper needs to be compiled as module, as well. Rename i2c.c to of_i2c.c to avoid name space conflict. Actually, since only powerpc has

Re: [PATCH] [POWERPC] i2c: fix build breakage introduced by OF helpers

2008-04-18 Thread David Miller
From: Paul Mackerras [EMAIL PROTECTED] Date: Sat, 19 Apr 2008 14:04:32 +1000 Jochen Friedrich writes: Fix build breakage introduced in commit [POWERPC] i2c: OF helpers for the i2c API. If i2c-core is compiled as module, the helper needs to be compiled as module, as well. Rename i2c.c

Re: [PATCH] [POWERPC] i2c: fix build breakage introduced by OF helpers

2008-04-18 Thread Paul Mackerras
David Miller writes: From: Paul Mackerras [EMAIL PROTECTED] Date: Sat, 19 Apr 2008 14:04:32 +1000 Jochen Friedrich writes: Fix build breakage introduced in commit [POWERPC] i2c: OF helpers for the i2c API. If i2c-core is compiled as module, the helper needs to be compiled as