[PATCH] [POWERPC] qe_lib: fix few fluffy negligences (was: Re: [PATCH 1/5] [POWERPC] qe_lib and users: get rid of most device_types and model)

2008-02-04 Thread Anton Vorontsov
On Tue, Feb 05, 2008 at 12:13:18AM +1100, Stephen Rothwell wrote: > Hi Anton, > > I know this is late, but a couple of comments anyway. > > On Thu, 24 Jan 2008 18:39:59 +0300 Anton Vorontsov <[EMAIL PROTECTED]> wrote: > > > > +++ b/arch/powerpc/sysdev/qe_lib/qe.c > > @@ -65,17 +65,22 @@ static ph

Re: [PATCH] [POWERPC] qe_lib: fix few fluffy negligences (was: Re: [PATCH 1/5] [POWERPC] qe_lib and users: get rid of most device_types and model)

2008-02-04 Thread Stephen Rothwell
On Mon, 4 Feb 2008 16:46:17 +0300 Anton Vorontsov <[EMAIL PROTECTED]> wrote: > > On Tue, Feb 05, 2008 at 12:13:18AM +1100, Stephen Rothwell wrote: > > > > If you don't care about the returned length (argument three to > > of_get_property), you can just pass NULL (and dispense with "size"). > > Als

Re: [PATCH] [POWERPC] qe_lib: fix few fluffy negligences (was: Re: [PATCH 1/5] [POWERPC] qe_lib and users: get rid of most device_types and model)

2008-02-05 Thread Kumar Gala
> > From: Anton Vorontsov <[EMAIL PROTECTED]> > Subject: [POWERPC] qe_lib: fix few fluffy negligences > > One is intoduced by me (of_node_put() absence) and another was > present already (not checking for NULL). > > Found by Stephen Rothwell. > > Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> >