Re: [PATCH] ALSA: ppc: remove redundant checks in PS3 driver probe

2020-11-28 Thread Takashi Iwai
On Fri, 27 Nov 2020 16:22:59 +0100, Leonard Goehrs wrote: > > The check for the FW_FEATURE_PS3_LV1 firmware feature is already performed > in ps3_system_bus_init() before registering the driver. So if the probe > function is actually used, this feature is already known to be available. > > The ch

[PATCH] ALSA: ppc: remove redundant checks in PS3 driver probe

2020-11-27 Thread Leonard Goehrs
The check for the FW_FEATURE_PS3_LV1 firmware feature is already performed in ps3_system_bus_init() before registering the driver. So if the probe function is actually used, this feature is already known to be available. The check for the match id is also superfluous; the condition is always true

Re: [PATCH] ALSA: ppc: remove redundant checks in PS3 driver probe

2020-11-27 Thread Geoff Levand
On 11/27/20 7:22 AM, Leonard Goehrs wrote: > The check for the FW_FEATURE_PS3_LV1 firmware feature is already performed > in ps3_system_bus_init() before registering the driver. So if the probe > function is actually used, this feature is already known to be available. > > The check for the match

Re: [PATCH] ALSA: ppc: remove redundant checks in PS3 driver probe

2020-11-27 Thread Uwe Kleine-König
Hallo Leonard, On Fri, Nov 27, 2020 at 04:22:59PM +0100, Leonard Goehrs wrote: > The check for the FW_FEATURE_PS3_LV1 firmware feature is already performed > in ps3_system_bus_init() before registering the driver. So if the probe > function is actually used, this feature is already known to be ava