Re: [PATCH] ASoC: fsl_sai: Use physical format width

2023-04-03 Thread Emil Abildgaard Svendsen
On 3/31/23 16:34, Mark Brown wrote: > On Fri, Mar 31, 2023 at 02:26:33PM +, Emil Abildgaard Svendsen wrote: >> On 3/31/23 04:55, Shengjiu Wang wrote: > >>> There are different requirements for this slot width. Some need physical >>> width, >>> Some need format width. We need to be careful

Re: [PATCH] ASoC: fsl_sai: Use physical format width

2023-03-31 Thread Mark Brown
On Fri, Mar 31, 2023 at 02:26:33PM +, Emil Abildgaard Svendsen wrote: > On 3/31/23 04:55, Shengjiu Wang wrote: > > There are different requirements for this slot width. Some need physical > > width, > > Some need format width. We need to be careful about change here. > I might be wrong but

Re: [PATCH] ASoC: fsl_sai: Use physical format width

2023-03-31 Thread Emil Abildgaard Svendsen
On 3/31/23 04:55, Shengjiu Wang wrote: > On Thu, Mar 30, 2023 at 4:30 PM Emil Abildgaard Svendsen < > e...@bang-olufsen.dk> wrote: > >> Slot width should follow the physical width of the format instead of the >> data width. >> >> This is needed for formats like SNDRV_PCM_FMTBIT_S24_LE where

Re: [PATCH] ASoC: fsl_sai: Use physical format width

2023-03-30 Thread Shengjiu Wang
On Thu, Mar 30, 2023 at 4:30 PM Emil Abildgaard Svendsen < e...@bang-olufsen.dk> wrote: > Slot width should follow the physical width of the format instead of the > data width. > > This is needed for formats like SNDRV_PCM_FMTBIT_S24_LE where physical > width is 32 and data width is 24. By using

[PATCH] ASoC: fsl_sai: Use physical format width

2023-03-30 Thread Emil Abildgaard Svendsen
Slot width should follow the physical width of the format instead of the data width. This is needed for formats like SNDRV_PCM_FMTBIT_S24_LE where physical width is 32 and data width is 24. By using the physical width, data won't get misaligned. Signed-off-by: Emil Svendsen ---