Re: [PATCH] Add MPC837xEMDS PCIE RC mode support

2007-12-02 Thread Li Li
On Fri, 2007-11-30 at 22:57 +0800, Gala Kumar wrote: > > On Nov 30, 2007, at 3:37 AM, Li Li wrote: > > > On Fri, 2007-11-30 at 17:05 +0800, Gala Kumar wrote: > > + > > + [EMAIL PROTECTED] { > > I agree w/Olof. This should be [EMAIL PROTECTED] > > > > +

Re: [PATCH] Add MPC837xEMDS PCIE RC mode support

2007-11-30 Thread Scott Wood
On Fri, Nov 30, 2007 at 08:57:33AM -0600, Kumar Gala wrote: > On Nov 30, 2007, at 3:37 AM, Li Li wrote: > > If do it standard, a 256M config space, at least 256M mem space and > > 16M > > io space are needed for each PCIE controller. > > To allocate PCIE window, the window size only can be 512M o

Re: [PATCH] Add MPC837xEMDS PCIE RC mode support

2007-11-30 Thread Scott Wood
On Thu, Nov 29, 2007 at 10:14:04PM -0600, Olof Johansson wrote: > On Fri, Nov 30, 2007 at 11:45:34AM +0800, Li Li wrote: > > + help > > + Enables MPC837x PCI express RC mode > > Why have a separate config option for this? To save code size when it isn't needed? > For systems where you don'

Re: [PATCH] Add MPC837xEMDS PCIE RC mode support

2007-11-30 Thread Kumar Gala
On Nov 30, 2007, at 3:37 AM, Li Li wrote: > On Fri, 2007-11-30 at 17:05 +0800, Gala Kumar wrote: > + > + [EMAIL PROTECTED] { I agree w/Olof. This should be [EMAIL PROTECTED] > > + interrupt-map-mask = ; > + msi-available-ranges = <43 4 51

Re: [PATCH] Add MPC837xEMDS PCIE RC mode support

2007-11-30 Thread Li Li
On Fri, 2007-11-30 at 17:05 +0800, Gala Kumar wrote: > >>> + > >>> + [EMAIL PROTECTED] { > >> > >> I agree w/Olof. This should be [EMAIL PROTECTED] > >>> > >>> + interrupt-map-mask = ; > >>> + msi-available-ranges = <43 4 51 52 56 57 58 59>; > >>> + i

Re: [PATCH] Add MPC837xEMDS PCIE RC mode support

2007-11-30 Thread Kumar Gala
>>> + >>> + [EMAIL PROTECTED] { >> >> I agree w/Olof. This should be [EMAIL PROTECTED] >>> >>> + interrupt-map-mask = ; >>> + msi-available-ranges = <43 4 51 52 56 57 58 59>; >>> + interrupt-map = < >>> + 0 0 1 &ipic 1 8 >>> +

Re: [PATCH] Add MPC837xEMDS PCIE RC mode support

2007-11-30 Thread Li Li
On Fri, 2007-11-30 at 15:37 +0800, Gala Kumar wrote: > > On Nov 29, 2007, at 9:45 PM, Li Li wrote: > > > The PCIE controller is initiated in u-boot. > > > > This patch is based on Leo`s mpc837xe patches. > > > > > > Signed-off-by: Tony Li <[EMAIL PROTECTED]> > > --- > > arch/powerpc/boot/d

Re: [PATCH] Add MPC837xEMDS PCIE RC mode support

2007-11-29 Thread Kumar Gala
On Nov 29, 2007, at 9:45 PM, Li Li wrote: > The PCIE controller is initiated in u-boot. > > This patch is based on Leo`s mpc837xe patches. > > > Signed-off-by: Tony Li <[EMAIL PROTECTED]> > --- > arch/powerpc/boot/dts/mpc8377_mds.dts | 56 -- > arch/powerpc/boot/dts/mpc8378_mds.dts

Re: [PATCH] Add MPC837xEMDS PCIE RC mode support

2007-11-29 Thread Li Li
On Fri, 2007-11-30 at 12:14 +0800, Olof Johansson wrote: > Hi, > > On Fri, Nov 30, 2007 at 11:45:34AM +0800, Li Li wrote: > > > + [EMAIL PROTECTED] { > > Why call it pci2@ (and pci3@ below)? They are clearly identifiable > with > their unit addresses anyway. > > > +config PPC_MPC83XX_PCIE

Re: [PATCH] Add MPC837xEMDS PCIE RC mode support

2007-11-29 Thread Olof Johansson
Hi, On Fri, Nov 30, 2007 at 11:45:34AM +0800, Li Li wrote: > + [EMAIL PROTECTED] { Why call it pci2@ (and pci3@ below)? They are clearly identifiable with their unit addresses anyway. > +config PPC_MPC83XX_PCIE > + bool "MPC837X PCI Express support" > + depends on PCIEPORTBUS && PP

[PATCH] Add MPC837xEMDS PCIE RC mode support

2007-11-29 Thread Li Li
The PCIE controller is initiated in u-boot. This patch is based on Leo`s mpc837xe patches. Signed-off-by: Tony Li <[EMAIL PROTECTED]> --- arch/powerpc/boot/dts/mpc8377_mds.dts | 56 -- arch/powerpc/boot/dts/mpc8378_mds.dts | 56 -- arch/powerpc/platforms/83xx/Kconfig