[PATCH] Add idle power save for ppc 4xx

2008-03-31 Thread Jerone Young
# HG changeset patch # User Jerone Young <[EMAIL PROTECTED]> # Date 1206969060 18000 # Node ID 10aea37177130bbe5de7bee6ec06d9010bc5da1f # Parent 1506aa38ddabb0bf73fff3ac3f3db5f9ef6458cc Add idle power save for ppc 4xx This patch sets the wait state MSR when power_save is called in cpu_idle loop

Re: [PATCH] Add idle power save for ppc 4xx

2008-03-31 Thread Josh Boyer
On Mon, 2008-03-31 at 08:12 -0500, Jerone Young wrote: > # HG changeset patch > # User Jerone Young <[EMAIL PROTECTED]> > # Date 1206969060 18000 > # Node ID 10aea37177130bbe5de7bee6ec06d9010bc5da1f > # Parent 1506aa38ddabb0bf73fff3ac3f3db5f9ef6458cc > Add idle power save for ppc 4xx > > This pat

Re: [PATCH] Add idle power save for ppc 4xx

2008-03-31 Thread Josh Boyer
On Mon, 31 Mar 2008 12:07:17 -0500 Josh Boyer <[EMAIL PROTECTED]> wrote: > On Mon, 2008-03-31 at 08:12 -0500, Jerone Young wrote: > > # HG changeset patch > > # User Jerone Young <[EMAIL PROTECTED]> > > # Date 1206969060 18000 > > # Node ID 10aea37177130bbe5de7bee6ec06d9010bc5da1f > > # Parent 15

Re: [PATCH] Add idle power save for ppc 4xx

2008-03-31 Thread Jerone Young
On Mon, 2008-03-31 at 13:05 -0500, Josh Boyer wrote: > On Mon, 31 Mar 2008 12:07:17 -0500 > Josh Boyer <[EMAIL PROTECTED]> wrote: > > > On Mon, 2008-03-31 at 08:12 -0500, Jerone Young wrote: > > > # HG changeset patch > > > # User Jerone Young <[EMAIL PROTECTED]> > > > # Date 1206969060 18000 > >

Re: [PATCH] Add idle power save for ppc 4xx

2008-03-31 Thread Jerone Young
On Mon, 2008-03-31 at 12:07 -0500, Josh Boyer wrote: > On Mon, 2008-03-31 at 08:12 -0500, Jerone Young wrote: > > # HG changeset patch > > # User Jerone Young <[EMAIL PROTECTED]> > > # Date 1206969060 18000 > > # Node ID 10aea37177130bbe5de7bee6ec06d9010bc5da1f > > # Parent 1506aa38ddabb0bf73fff3a

Re: [PATCH] Add idle power save for ppc 4xx

2008-03-31 Thread Josh Boyer
On Mon, 2008-03-31 at 13:23 -0500, Jerone Young wrote: > > > diff --git a/arch/powerpc/kernel/idle_4xx.c > > > b/arch/powerpc/kernel/idle_4xx.c > > > new file mode 100644 > > > --- /dev/null > > > +++ b/arch/powerpc/kernel/idle_4xx.c > > > > Can this be added to sysdev/ppc4xx_soc.c instead? > >

Re: [PATCH] Add idle power save for ppc 4xx

2008-03-31 Thread Hollis Blanchard
On Mon, 31 Mar 2008 13:05:18 -0500, Josh Boyer wrote: > On Mon, 31 Mar 2008 12:07:17 -0500 > Josh Boyer <[EMAIL PROTECTED]> wrote: > >> On Mon, 2008-03-31 at 08:12 -0500, Jerone Young wrote: >> > # HG changeset patch >> > # User Jerone Young <[EMAIL PROTECTED]> # Date 1206969060 18000 >> > # Node

Re: [PATCH] Add idle power save for ppc 4xx

2008-03-31 Thread Josh Boyer
On Mon, 2008-03-31 at 19:24 +, Hollis Blanchard wrote: > On Mon, 31 Mar 2008 13:05:18 -0500, Josh Boyer wrote: > > > On Mon, 31 Mar 2008 12:07:17 -0500 > > Josh Boyer <[EMAIL PROTECTED]> wrote: > > > >> On Mon, 2008-03-31 at 08:12 -0500, Jerone Young wrote: > >> > # HG changeset patch > >> >

Re: [PATCH] Add idle power save for ppc 4xx

2008-03-31 Thread Hollis Blanchard
On Mon, 2008-03-31 at 15:28 -0500, Josh Boyer wrote: > On Mon, 2008-03-31 at 19:24 +, Hollis Blanchard wrote: > > On Mon, 31 Mar 2008 13:05:18 -0500, Josh Boyer wrote: > > > > > On Mon, 31 Mar 2008 12:07:17 -0500 > > > Josh Boyer <[EMAIL PROTECTED]> wrote: > > > > > >> On Mon, 2008-03-31 at 0

Re: [PATCH] Add idle power save for ppc 4xx

2008-03-31 Thread Michael Ellerman
On Mon, 2008-03-31 at 13:19 -0500, Jerone Young wrote: > On Mon, 2008-03-31 at 13:05 -0500, Josh Boyer wrote: > > On Mon, 31 Mar 2008 12:07:17 -0500 > > Josh Boyer <[EMAIL PROTECTED]> wrote: > > > > > On Mon, 2008-03-31 at 08:12 -0500, Jerone Young wrote: > > > > # HG changeset patch > > > > # Use

Re: [PATCH] Add idle power save for ppc 4xx

2008-03-31 Thread Josh Boyer
On Tue, 2008-04-01 at 12:04 +1100, Michael Ellerman wrote: > > > > I'm assuming you pass a dtb to the virtual guest when you start it up. > > > > Could you define a property in the CPU node there that can be parsed to > > > > use the power_save function instead of always making it the default? > >

Re: [PATCH] Add idle power save for ppc 4xx

2008-03-31 Thread Michael Ellerman
On Mon, 2008-03-31 at 22:15 -0500, Josh Boyer wrote: > On Tue, 2008-04-01 at 12:04 +1100, Michael Ellerman wrote: > > > > > I'm assuming you pass a dtb to the virtual guest when you start it up. > > > > > Could you define a property in the CPU node there that can be parsed > > > > > to > > > > > u

Re: [PATCH] Add idle power save for ppc 4xx

2008-03-31 Thread Paul Mackerras
Josh Boyer writes: > Actually, you probably don't want this as a property in the device > tree. It doesn't describe hardware. A Kconfig option might be > warranted though. In general it is valid to have properties in the device tree that describe the hypervisor or the kernel's interface to it,

Re: [PATCH] Add idle power save for ppc 4xx

2008-04-01 Thread Josh Boyer
On Tue, 1 Apr 2008 15:00:38 +1100 Paul Mackerras <[EMAIL PROTECTED]> wrote: > Josh Boyer writes: > > > Actually, you probably don't want this as a property in the device > > tree. It doesn't describe hardware. A Kconfig option might be > > warranted though. > > In general it is valid to have p

Re: [kvm-ppc-devel] [PATCH] Add idle power save for ppc 4xx

2008-03-31 Thread Hollis Blanchard
On Mon, 2008-03-31 at 08:12 -0500, Jerone Young wrote: > # HG changeset patch > # User Jerone Young <[EMAIL PROTECTED]> > # Date 1206969060 18000 > # Node ID 10aea37177130bbe5de7bee6ec06d9010bc5da1f > # Parent 1506aa38ddabb0bf73fff3ac3f3db5f9ef6458cc > Add idle power save for ppc 4xx > > This pat

Re: [kvm-ppc-devel] [PATCH] Add idle power save for ppc 4xx

2008-03-31 Thread Jerone Young
On Mon, 2008-03-31 at 11:27 -0500, Hollis Blanchard wrote: > On Mon, 2008-03-31 at 08:12 -0500, Jerone Young wrote: > > # HG changeset patch > > # User Jerone Young <[EMAIL PROTECTED]> > > # Date 1206969060 18000 > > # Node ID 10aea37177130bbe5de7bee6ec06d9010bc5da1f > > # Parent 1506aa38ddabb0bf7

Re: [kvm-ppc-devel] [PATCH] Add idle power save for ppc 4xx

2008-03-31 Thread Josh Boyer
On Mon, 31 Mar 2008 11:52:02 -0500 Jerone Young <[EMAIL PROTECTED]> wrote: > > void ppc4xx_idle(void) > > > > > +{ > > > + unsigned long msr_save; > > > + > > > + /* set wait state MSR */ > > > + local_irq_enable(); > > > + msr_save = mfmsr(); > > > + mtmsr(msr_save|MSR_WE); > > > > Why don't yo

Re: [kvm-ppc-devel] [PATCH] Add idle power save for ppc 4xx

2008-04-01 Thread Jimi Xenidis
On Mar 31, 2008, at 11:15 PM, Josh Boyer wrote: On Tue, 2008-04-01 at 12:04 +1100, Michael Ellerman wrote: I'm assuming you pass a dtb to the virtual guest when you start it up. Could you define a property in the CPU node there that can be parsed to use the power_save function instead of al

Re: [kvm-ppc-devel] [PATCH] Add idle power save for ppc 4xx

2008-04-01 Thread Josh Boyer
On Tue, 2008-04-01 at 08:01 -0400, Jimi Xenidis wrote: > On Mar 31, 2008, at 11:15 PM, Josh Boyer wrote: > > > On Tue, 2008-04-01 at 12:04 +1100, Michael Ellerman wrote: > > I'm assuming you pass a dtb to the virtual guest when you start > > it up. > > Could you define a property in

Re: [kvm-ppc-devel] [PATCH] Add idle power save for ppc 4xx

2008-04-01 Thread Arnd Bergmann
On Monday 31 March 2008, Jerone Young wrote: > > > > > +{ > > > +   unsigned long msr_save; > > > + > > > +   /* set wait state MSR */ > > > +   local_irq_enable(); > > > +   msr_save = mfmsr(); > > > +   mtmsr(msr_save|MSR_WE); > > > > Why don't you |MSR_WE|MSR_EE at the same time? > > You tech