Re: [PATCH] Device tree bindings for Xilinx devices

2007-10-11 Thread David Gibson
On Wed, Oct 10, 2007 at 11:27:14PM -0600, Grant Likely wrote: > On 10/10/07, David Gibson <[EMAIL PROTECTED]> wrote: > > > My main concern is that I don't like the implicit numbering that > > > occurs simply based on the order of devices in the device tree. If > > > the probe algorithm ever change

Re: [PATCH] Device tree bindings for Xilinx devices

2007-10-10 Thread Grant Likely
On 10/10/07, David Gibson <[EMAIL PROTECTED]> wrote: > > My main concern is that I don't like the implicit numbering that > > occurs simply based on the order of devices in the device tree. If > > the probe algorithm ever changes to parse in reverse order or > > something reorders the tree, then t

Re: [PATCH] Device tree bindings for Xilinx devices

2007-10-10 Thread David Gibson
On Wed, Oct 10, 2007 at 10:58:25PM -0600, Grant Likely wrote: > On 10/10/07, David Gibson <[EMAIL PROTECTED]> wrote: > > On Wed, Oct 10, 2007 at 10:18:50PM -0600, Grant Likely wrote: > > > On 10/10/07, David Gibson <[EMAIL PROTECTED]> wrote: > > > > On Wed, Oct 10, 2007 at 08:25:36PM -0600, Grant L

Re: [PATCH] Device tree bindings for Xilinx devices

2007-10-10 Thread Grant Likely
On 10/10/07, David Gibson <[EMAIL PROTECTED]> wrote: > On Wed, Oct 10, 2007 at 10:18:50PM -0600, Grant Likely wrote: > > On 10/10/07, David Gibson <[EMAIL PROTECTED]> wrote: > > > On Wed, Oct 10, 2007 at 08:25:36PM -0600, Grant Likely wrote: > > > > On 10/10/07, David Gibson <[EMAIL PROTECTED]> wro

Re: [PATCH] Device tree bindings for Xilinx devices

2007-10-10 Thread David Gibson
On Wed, Oct 10, 2007 at 10:18:50PM -0600, Grant Likely wrote: > On 10/10/07, David Gibson <[EMAIL PROTECTED]> wrote: > > On Wed, Oct 10, 2007 at 08:25:36PM -0600, Grant Likely wrote: > > > On 10/10/07, David Gibson <[EMAIL PROTECTED]> wrote: > > > > We've used 'cell-index' for similar purposes on o

Re: [PATCH] Device tree bindings for Xilinx devices

2007-10-10 Thread Grant Likely
On 10/10/07, David Gibson <[EMAIL PROTECTED]> wrote: > On Wed, Oct 10, 2007 at 08:25:36PM -0600, Grant Likely wrote: > > On 10/10/07, David Gibson <[EMAIL PROTECTED]> wrote: > > > We've used 'cell-index' for similar purposes on other 4xx. > > > > Unfortunately, 'cell' has been used in the sense of

Re: [PATCH] Device tree bindings for Xilinx devices

2007-10-10 Thread David Gibson
On Wed, Oct 10, 2007 at 08:25:36PM -0600, Grant Likely wrote: > On 10/10/07, David Gibson <[EMAIL PROTECTED]> wrote: > > On Wed, Oct 10, 2007 at 03:38:02PM -0500, Josh Boyer wrote: [snip] > > > "number" seems a bit to generic to me. logical-number seems a bit more > > > descriptive. > > > > We've

Re: [PATCH] Device tree bindings for Xilinx devices

2007-10-10 Thread Grant Likely
On 10/10/07, David Gibson <[EMAIL PROTECTED]> wrote: > On Wed, Oct 10, 2007 at 03:38:02PM -0500, Josh Boyer wrote: > > On Mon, 2007-10-08 at 01:53 -0600, Grant Likely wrote: > > > From: Grant Likely <[EMAIL PROTECTED]> > > > > > > Signed-off-by: Grant Likely <[EMAIL PROTECTED]> > > > --- > > > > >

Re: [PATCH] Device tree bindings for Xilinx devices

2007-10-10 Thread David Gibson
On Wed, Oct 10, 2007 at 03:38:02PM -0500, Josh Boyer wrote: > On Mon, 2007-10-08 at 01:53 -0600, Grant Likely wrote: > > From: Grant Likely <[EMAIL PROTECTED]> > > > > Signed-off-by: Grant Likely <[EMAIL PROTECTED]> > > --- > > > > This is a first draft, please review and comment. > > I'll start

Re: [PATCH] Device tree bindings for Xilinx devices

2007-10-10 Thread Josh Boyer
On Mon, 2007-10-08 at 01:53 -0600, Grant Likely wrote: > From: Grant Likely <[EMAIL PROTECTED]> > > Signed-off-by: Grant Likely <[EMAIL PROTECTED]> > --- > > This is a first draft, please review and comment. I'll start off with the fact that I hardly consider myself a DT expert, so take what I s

Re: [PATCH] Device tree bindings for Xilinx devices

2007-10-10 Thread Grant Likely
Anybody have any comments on this? Segher? David? Cheers, g. On 10/8/07, Grant Likely <[EMAIL PROTECTED]> wrote: > From: Grant Likely <[EMAIL PROTECTED]> > > Signed-off-by: Grant Likely <[EMAIL PROTECTED]> > --- > > This is a first draft, please review and comment. > > On a side node, I think b

[PATCH] Device tree bindings for Xilinx devices

2007-10-08 Thread Grant Likely
From: Grant Likely <[EMAIL PROTECTED]> Signed-off-by: Grant Likely <[EMAIL PROTECTED]> --- This is a first draft, please review and comment. On a side node, I think booting-without-of.txt could get really unwieldly in the near future. Perhaps the device tree bindings should be organized differe