Re: [PATCH] Implement GET_IP/SET_IP for powerpc architecture.

2012-02-02 Thread Benjamin Herrenschmidt
On Thu, 2012-02-02 at 11:28 -0500, Mike Frysinger wrote: > On Thursday 02 February 2012 09:41:25 Srikar Dronamraju wrote: > > +#define GET_FP(regs) (0) > > +#define SET_FP(regs, val) > > ppc doesn't have a standard FP location ? Not really no, it's the sp (r1). r31 might be consider

Re: [PATCH] Implement GET_IP/SET_IP for powerpc architecture.

2012-02-02 Thread Mike Frysinger
On Thursday 02 February 2012 11:36:59 Srikar Dronamraju wrote: > * Mike Frysinger [2012-02-02 11:28:46]: > > On Thursday 02 February 2012 09:41:25 Srikar Dronamraju wrote: > > > +#define profile_pc(regs) GET_IP(regs) > > > > pretty sure you don't need this as asm-generic/ptrace.h already has a >

Re: [PATCH] Implement GET_IP/SET_IP for powerpc architecture.

2012-02-02 Thread Srikar Dronamraju
* Mike Frysinger [2012-02-02 11:28:46]: > On Thursday 02 February 2012 09:41:25 Srikar Dronamraju wrote: > > +#define GET_FP(regs) (0) > > +#define SET_FP(regs, val) > > ppc doesn't have a standard FP location ? > > > +#define profile_pc(regs) GET_IP(regs) > > pretty sure you don

Re: [PATCH] Implement GET_IP/SET_IP for powerpc architecture.

2012-02-02 Thread Mike Frysinger
On Thursday 02 February 2012 09:41:25 Srikar Dronamraju wrote: > +#define GET_FP(regs) (0) > +#define SET_FP(regs, val) ppc doesn't have a standard FP location ? > +#define profile_pc(regs) GET_IP(regs) pretty sure you don't need this as asm-generic/ptrace.h already has a definition for

[PATCH] Implement GET_IP/SET_IP for powerpc architecture.

2012-02-02 Thread Srikar Dronamraju
With this change, helpers such as instruction_pointer() et al, get defined in the generic header in terms of GET_IP Signed-off-by: Srikar Dronamraju Signed-off-by: Ananth N Mavinakayanahalli --- arch/powerpc/include/asm/ptrace.h | 22 ++ 1 files changed, 14 insertions(+),