Every time I build cxl I see the following warnings:
/scratch/dja/linux-capi/drivers/misc/cxl/pci.c: In function ‘sanitise_afu_regs’:
/scratch/dja/linux-capi/drivers/misc/cxl/pci.c:712:6: warning: suggest explicit
braces to avoid ambiguous ‘else’ [-Wparentheses]
if (reg & CXL_PSL_DSISR_TRANS)
Daniel Axtens writes:
> Every time I build cxl I see the following warnings:
>
> /scratch/dja/linux-capi/drivers/misc/cxl/pci.c: In function
> ‘sanitise_afu_regs’:
> /scratch/dja/linux-capi/drivers/misc/cxl/pci.c:712:6: warning: suggest
> explicit braces to avoid ambiguous ‘else’ [-Wparentheses
On 31/07/15 08:35, Daniel Axtens wrote:
> Every time I build cxl I see the following warnings:
>
> /scratch/dja/linux-capi/drivers/misc/cxl/pci.c: In function
> ‘sanitise_afu_regs’:
> /scratch/dja/linux-capi/drivers/misc/cxl/pci.c:712:6: warning: suggest
> explicit braces to avoid ambiguous ‘els
Hi Andreas,
On Fri, 2015-07-31 at 11:16 +0200, Andreas Schwab wrote:
> Daniel Axtens writes:
>
> > Every time I build cxl I see the following warnings:
> >
> > /scratch/dja/linux-capi/drivers/misc/cxl/pci.c: In function
> > ‘sanitise_afu_regs’:
> > /scratch/dja/linux-capi/drivers/misc/cxl/pci.c
On Mon, 2015-08-03 at 10:36 +1000, Daniel Axtens wrote:
> Hi Andreas,
>
> On Fri, 2015-07-31 at 11:16 +0200, Andreas Schwab wrote:
> > Daniel Axtens writes:
> >
> > > Every time I build cxl I see the following warnings:
> > >
> > > /scratch/dja/linux-capi/drivers/misc/cxl/pci.c: In function
> >
> This should be a static inline, not a #define.
>
I'm changing them to static inlines at the moment. Would you prefer a v3
of the EEH patches, or a new patch on top?
--
Regards,
Daniel
signature.asc
Description: This is a digitally signed message part
_
On Mon, 2015-08-03 at 10:47 +1000, Daniel Axtens wrote:
> > This should be a static inline, not a #define.
> >
> I'm changing them to static inlines at the moment. Would you prefer a v3
> of the EEH patches, or a new patch on top?
Without looking closer I think a v3.
ie. before you change the lo
