Re: [PATCH] cxl: Fix error path on bad ioctl

2017-06-07 Thread Michael Ellerman
Frederic Barrat writes: > Le 06/06/2017 à 11:20, Michael Ellerman a écrit : >> Frederic Barrat writes: >> >>> Fix error path if we can't copy user structure on >>> CXL_IOCTL_START_WORK ioctl. >> >> To be clear the error is that returning

Re: [PATCH] cxl: Fix error path on bad ioctl

2017-06-06 Thread Frederic Barrat
Le 06/06/2017 à 11:20, Michael Ellerman a écrit : Frederic Barrat writes: Fix error path if we can't copy user structure on CXL_IOCTL_START_WORK ioctl. To be clear the error is that returning via the out label will unlock cxl->status_mutex, which has not been

Re: [PATCH] cxl: Fix error path on bad ioctl

2017-06-06 Thread Michael Ellerman
Frederic Barrat writes: > Fix error path if we can't copy user structure on > CXL_IOCTL_START_WORK ioctl. To be clear the error is that returning via the out label will unlock cxl->status_mutex, which has not been locked. Please spell it out for me :) This should

Re: [PATCH] cxl: Fix error path on bad ioctl

2017-06-04 Thread Andrew Donnellan
On 03/06/17 02:15, Frederic Barrat wrote: Fix error path if we can't copy user structure on CXL_IOCTL_START_WORK ioctl. Signed-off-by: Frederic Barrat Cc: sta...@vger.kernel.org Reviewed-by: Andrew Donnellan -- Andrew Donnellan

Re: [PATCH] cxl: Fix error path on bad ioctl

2017-06-02 Thread Vaibhav Jain
Hi Fred, Good catch. Frederic Barrat writes: > Fix error path if we can't copy user structure on > CXL_IOCTL_START_WORK ioctl. > > Signed-off-by: Frederic Barrat > Cc: sta...@vger.kernel.org > --- > drivers/misc/cxl/file.c | 6 ++ >

[PATCH] cxl: Fix error path on bad ioctl

2017-06-02 Thread Frederic Barrat
Fix error path if we can't copy user structure on CXL_IOCTL_START_WORK ioctl. Signed-off-by: Frederic Barrat Cc: sta...@vger.kernel.org --- drivers/misc/cxl/file.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/misc/cxl/file.c