[PATCH] cxl: Fix refcount leak in cxl_calc_capp_routing

2022-06-04 Thread Miaoqian Lin
of_get_next_parent() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. This function only calls of_node_put() in normal path, missing it in the error path. Add missing of_node_put() to avoid refcount leak. Fixes: f24be42aab37 ("cxl: Add psl9

Re: [PATCH] cxl: Fix refcount leak in cxl_calc_capp_routing

2022-11-14 Thread Christophe Leroy
Should this be applied by Bjorn as most recent changes to that file ? Le 14/06/2022 à 12:12, Andrew Donnellan a écrit : > On Sun, 2022-06-05 at 10:00 +0400, Miaoqian Lin wrote: >> of_get_next_parent() returns a node pointer with refcount >> incremented, >> we should use of_node_put() on it when n

Re: [PATCH] cxl: Fix refcount leak in cxl_calc_capp_routing

2022-11-21 Thread Andrew Donnellan
On Mon, 2022-11-14 at 12:42 +, Christophe Leroy wrote: > Should this be applied by Bjorn as most recent changes to that file ? We usually take cxl patches through powerpc, though sometimes Greg picks them up through char-misc. -- Andrew DonnellanOzLabs, ADL Canberra a...@linux.ibm.com

Re: [PATCH] cxl: Fix refcount leak in cxl_calc_capp_routing

2022-11-30 Thread Michael Ellerman
On Sun, 5 Jun 2022 10:00:38 +0400, Miaoqian Lin wrote: > of_get_next_parent() returns a node pointer with refcount incremented, > we should use of_node_put() on it when not need anymore. > This function only calls of_node_put() in normal path, > missing it in the error path. > Add missing of_node_p

Re: [PATCH] cxl: Fix refcount leak in cxl_calc_capp_routing

2022-06-07 Thread Frederic Barrat
On 05/06/2022 08:00, Miaoqian Lin wrote: of_get_next_parent() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. This function only calls of_node_put() in normal path, missing it in the error path. Add missing of_node_put() to avoid refco

Re: [PATCH] cxl: Fix refcount leak in cxl_calc_capp_routing

2022-06-14 Thread Andrew Donnellan
On Sun, 2022-06-05 at 10:00 +0400, Miaoqian Lin wrote: > of_get_next_parent() returns a node pointer with refcount > incremented, > we should use of_node_put() on it when not need anymore. > This function only calls of_node_put() in normal path, > missing it in the error path. > Add missing of_node