Re: [PATCH] cxl: Set the valid bit in PE for dedicated mode

2017-08-30 Thread Michael Ellerman
Vaibhav Jain writes: > Hi Mpe, > > Thanks for reviewing the patch > > Michael Ellerman writes: > >>> + ctx->elem->software_state = cpu_to_be32(CXL_PE_SOFTWARE_STATE_V); >>> + /* Make sure the changes to the PE are visible to the card */ >> >> A barrier orders something vs something else. So

Re: [PATCH] cxl: Set the valid bit in PE for dedicated mode

2017-08-30 Thread Vaibhav Jain
Hi Mpe, Thanks for reviewing the patch Michael Ellerman writes: >> +ctx->elem->software_state = cpu_to_be32(CXL_PE_SOFTWARE_STATE_V); >> +/* Make sure the changes to the PE are visible to the card */ > > A barrier orders something vs something else. So what's the something > else in thi

Re: [PATCH] cxl: Set the valid bit in PE for dedicated mode

2017-08-28 Thread Michael Ellerman
Vaibhav Jain writes: > Make sure to set the valid-bit in software-state field of the > populated PE. This was earlier missing for dedicated mode AFUs, hence > was causing a PSL freeze when the AFU was activated. > > Signed-off-by: Vaibhav Jain > --- > drivers/misc/cxl/native.c | 4 > 1 fil

Re: [PATCH] cxl: Set the valid bit in PE for dedicated mode

2017-08-28 Thread Frederic Barrat
Le 28/08/2017 à 06:15, Vaibhav Jain a écrit : Make sure to set the valid-bit in software-state field of the populated PE. This was earlier missing for dedicated mode AFUs, hence was causing a PSL freeze when the AFU was activated. Signed-off-by: Vaibhav Jain --- Acked-by: Frederic Barrat

Re: [PATCH] cxl: Set the valid bit in PE for dedicated mode

2017-08-28 Thread christophe lombard
Le 28/08/2017 à 06:15, Vaibhav Jain a écrit : Make sure to set the valid-bit in software-state field of the populated PE. This was earlier missing for dedicated mode AFUs, hence was causing a PSL freeze when the AFU was activated. Acked-by: Christophe Lombard Signed-off-by: Vaibhav Jain --

Re: [PATCH] cxl: Set the valid bit in PE for dedicated mode

2017-08-27 Thread Andrew Donnellan
On 28/08/17 14:15, Vaibhav Jain wrote: Make sure to set the valid-bit in software-state field of the populated PE. This was earlier missing for dedicated mode AFUs, hence was causing a PSL freeze when the AFU was activated. Signed-off-by: Vaibhav Jain Acked-by: Andrew Donnellan --- drive

[PATCH] cxl: Set the valid bit in PE for dedicated mode

2017-08-27 Thread Vaibhav Jain
Make sure to set the valid-bit in software-state field of the populated PE. This was earlier missing for dedicated mode AFUs, hence was causing a PSL freeze when the AFU was activated. Signed-off-by: Vaibhav Jain --- drivers/misc/cxl/native.c | 4 1 file changed, 4 insertions(+) diff --git