Re: [PATCH] fs_enet: restore promiscuous and multicast settings in restart()

2008-06-26 Thread Laurent Pinchart
Hi, On Friday 20 June 2008 10:55, Matvejchikov Ilya wrote: > >> > diff --git a/drivers/net/fs_enet/mac-fcc.c b/drivers/net/fs_enet/mac-fcc.c > >> > index ce40cf9..1a95cf1 100644 > >> > --- a/drivers/net/fs_enet/mac-fcc.c > >> > +++ b/drivers/net/fs_enet/mac-fcc.c > >> > @@ -464,6 +464,9 @@ static

Re: [PATCH] fs_enet: restore promiscuous and multicast settings in restart()

2008-06-20 Thread Bill Fink
On Fri, 20 Jun 2008, Laurent Pinchart wrote: > On Friday 20 June 2008 05:01, Bill Fink wrote: > > On Wed, 18 Jun 2008, Laurent Pinchart wrote: > > > > > The restart() function is called when the link state changes and resets > > > multicast and promiscous settings. This patch restores those setti

Re: [PATCH] fs_enet: restore promiscuous and multicast settings in restart()

2008-06-20 Thread Matvejchikov Ilya
>> > diff --git a/drivers/net/fs_enet/mac-fcc.c b/drivers/net/fs_enet/mac-fcc.c >> > index ce40cf9..1a95cf1 100644 >> > --- a/drivers/net/fs_enet/mac-fcc.c >> > +++ b/drivers/net/fs_enet/mac-fcc.c >> > @@ -464,6 +464,9 @@ static void restart(struct net_device *dev) >> > C32(fccp, fcc_fp

Re: [PATCH] fs_enet: restore promiscuous and multicast settings in restart()

2008-06-20 Thread Laurent Pinchart
On Friday 20 June 2008 05:01, Bill Fink wrote: > On Wed, 18 Jun 2008, Laurent Pinchart wrote: > > > The restart() function is called when the link state changes and resets > > multicast and promiscous settings. This patch restores those settings at the > > end of restart(). > > > > Signed-off-by

Re: [PATCH] fs_enet: restore promiscuous and multicast settings in restart()

2008-06-19 Thread Bill Fink
On Wed, 18 Jun 2008, Laurent Pinchart wrote: > The restart() function is called when the link state changes and resets > multicast and promiscous settings. This patch restores those settings at the > end of restart(). > > Signed-off-by: Laurent Pinchart <[EMAIL PROTECTED]> > --- > drivers/net/fs

Re: [PATCH] fs_enet: restore promiscuous and multicast settings in restart()

2008-06-19 Thread Matvejchikov Ilya
Yes, please. =) 2008/6/19 Vitaly Bordug <[EMAIL PROTECTED]>: > On Wed, 18 Jun 2008 22:45:57 +0400 > "Matvejchikov Ilya" <[EMAIL PROTECTED]> wrote: > >> I'm glad that you have corrected it. Half a year ago I pointed out >> that there was such a mistake: >> http://patchwork.ozlabs.org/linuxppc/patch

Re: [PATCH] fs_enet: restore promiscuous and multicast settings in restart()

2008-06-19 Thread Olof Johansson
On Jun 19, 2008, at 1:47 PM, Jon Loeliger wrote: We should merge the -embedded list into -dev and retire the -embedded list finally. I used to be an opponent to this given the amount of "help my board doesn't work" questions on -embedded, but the volume isn't that great, and much lower tha

Re: [PATCH] fs_enet: restore promiscuous and multicast settings in restart()

2008-06-19 Thread Jon Loeliger
Vitaly Bordug wrote: On Wed, 18 Jun 2008 22:45:57 +0400 "Matvejchikov Ilya" <[EMAIL PROTECTED]> wrote: I'm glad that you have corrected it. Half a year ago I pointed out that there was such a mistake: http://patchwork.ozlabs.org/linuxppc/patch?id=10700 You've used -embedded ML, and patch wasn'

Re: [PATCH] fs_enet: restore promiscuous and multicast settings in restart()

2008-06-19 Thread Vitaly Bordug
On Wed, 18 Jun 2008 22:45:57 +0400 "Matvejchikov Ilya" <[EMAIL PROTECTED]> wrote: > I'm glad that you have corrected it. Half a year ago I pointed out > that there was such a mistake: > http://patchwork.ozlabs.org/linuxppc/patch?id=10700 > You've used -embedded ML, and patch wasn't noticed... I c

Re: [PATCH] fs_enet: restore promiscuous and multicast settings in restart()

2008-06-18 Thread Matvejchikov Ilya
I'm glad that you have corrected it. Half a year ago I pointed out that there was such a mistake: http://patchwork.ozlabs.org/linuxppc/patch?id=10700 Thanks. 2008/6/18 Laurent Pinchart <[EMAIL PROTECTED]>: > The restart() function is called when the link state changes and resets > multicast and p

[PATCH] fs_enet: restore promiscuous and multicast settings in restart()

2008-06-18 Thread Laurent Pinchart
The restart() function is called when the link state changes and resets multicast and promiscous settings. This patch restores those settings at the end of restart(). Signed-off-by: Laurent Pinchart <[EMAIL PROTECTED]> --- drivers/net/fs_enet/mac-fcc.c |3 +++ 2 files changed, 4 insertion