[PATCH] i2c: Remove unneeded xxx_set_drvdata(..., NULL) calls

2013-02-15 Thread Doug Anderson
There is simply no reason to be manually setting the private driver data to NULL in the remove/fail to probe cases. This is just extra cruft code that can be removed. A few notes: * Nothing relies on drvdata being set to NULL. * The __device_release_driver() function eventually calls dev_set_dr

Re: [PATCH] i2c: Remove unneeded xxx_set_drvdata(..., NULL) calls

2013-02-16 Thread Jean Delvare
On Fri, 15 Feb 2013 15:18:35 -0800, Doug Anderson wrote: > There is simply no reason to be manually setting the private driver > data to NULL in the remove/fail to probe cases. This is just extra > cruft code that can be removed. > > A few notes: > * Nothing relies on drvdata being set to NULL. >

Re: [PATCH] i2c: Remove unneeded xxx_set_drvdata(..., NULL) calls

2013-02-17 Thread Peter Korsgaard
> "Doug" == Doug Anderson writes: Doug> There is simply no reason to be manually setting the private driver Doug> data to NULL in the remove/fail to probe cases. This is just extra Doug> cruft code that can be removed. Doug> A few notes: Doug> * Nothing relies on drvdata being set to N

Re: [PATCH] i2c: Remove unneeded xxx_set_drvdata(..., NULL) calls

2013-02-18 Thread Mika Westerberg
On Fri, Feb 15, 2013 at 03:18:35PM -0800, Doug Anderson wrote: > There is simply no reason to be manually setting the private driver > data to NULL in the remove/fail to probe cases. This is just extra > cruft code that can be removed. > > A few notes: > * Nothing relies on drvdata being set to N

Re: [PATCH] i2c: Remove unneeded xxx_set_drvdata(..., NULL) calls

2013-02-18 Thread Marek Vasut
Dear Doug Anderson, > There is simply no reason to be manually setting the private driver > data to NULL in the remove/fail to probe cases. This is just extra > cruft code that can be removed. > > A few notes: > * Nothing relies on drvdata being set to NULL. > * The __device_release_driver() fun

Re: [PATCH] i2c: Remove unneeded xxx_set_drvdata(..., NULL) calls

2013-02-21 Thread Wolfram Sang
On Fri, Feb 15, 2013 at 03:18:35PM -0800, Doug Anderson wrote: > There is simply no reason to be manually setting the private driver > data to NULL in the remove/fail to probe cases. This is just extra > cruft code that can be removed. > > A few notes: > * Nothing relies on drvdata being set to N