Re: [PATCH] i2c: let the core register devices from devicetree

2012-06-20 Thread Barry Song
2012/6/14 Wolfram Sang : > Currently, every driver has to do it on its own, but it should be done > in the core, like we already do with board_info structs. > > Signed-off-by: Wolfram Sang Acked-by: Barry Song > --- > > Based on v3.5-rc2. Only build tested, I don't have a OF based device > arou

Re: [PATCH] i2c: let the core register devices from devicetree

2012-06-14 Thread Linus Walleij
On Wed, Jun 13, 2012 at 11:12 PM, Wolfram Sang wrote: > Currently, every driver has to do it on its own, but it should be done > in the core, like we already do with board_info structs. > > Signed-off-by: Wolfram Sang Acked-by: Linus Walleij Lee might be able to test this with his DT bindings

Re: [PATCH] i2c: let the core register devices from devicetree

2012-06-14 Thread Benjamin Herrenschmidt
On Thu, 2012-06-14 at 11:14 +0200, Wolfram Sang wrote: > On Thu, Jun 14, 2012 at 07:33:37AM +1000, Benjamin Herrenschmidt wrote: > > On Wed, 2012-06-13 at 23:12 +0200, Wolfram Sang wrote: > > > Currently, every driver has to do it on its own, but it should be done > > > in the core, like we already

Re: [PATCH] i2c: let the core register devices from devicetree

2012-06-14 Thread Jean Delvare
Hi Wolfram, On Wed, 13 Jun 2012 23:12:10 +0200, Wolfram Sang wrote: > Currently, every driver has to do it on its own, but it should be done > in the core, like we already do with board_info structs. > > Signed-off-by: Wolfram Sang > --- > > Based on v3.5-rc2. Only build tested, I don't have a

Re: [PATCH] i2c: let the core register devices from devicetree

2012-06-14 Thread Pawel Moll
On Wed, 2012-06-13 at 23:12 +0200, Wolfram Sang wrote: > Currently, every driver has to do it on its own, but it should be done > in the core, like we already do with board_info structs. > > Signed-off-by: Wolfram Sang > --- > drivers/i2c/busses/i2c-versatile.c |1 - > drivers/i2c/i

Re: [PATCH] i2c: let the core register devices from devicetree

2012-06-14 Thread Wolfram Sang
On Thu, Jun 14, 2012 at 07:33:37AM +1000, Benjamin Herrenschmidt wrote: > On Wed, 2012-06-13 at 23:12 +0200, Wolfram Sang wrote: > > Currently, every driver has to do it on its own, but it should be done > > in the core, like we already do with board_info structs. > > > > Signed-off-by: Wolfram Sa

Re: [PATCH] i2c: let the core register devices from devicetree

2012-06-14 Thread viresh kumar
On Wed, Jun 13, 2012 at 10:12 PM, Wolfram Sang wrote: > Currently, every driver has to do it on its own, but it should be done > in the core, like we already do with board_info structs. > > Signed-off-by: Wolfram Sang > --- > diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c > b/drivers

Re: [PATCH] i2c: let the core register devices from devicetree

2012-06-14 Thread Peter Korsgaard
> "Wolfram" == Wolfram Sang writes: Wolfram> Currently, every driver has to do it on its own, but it should Wolfram> be done in the core, like we already do with board_info Wolfram> structs. Wolfram> Signed-off-by: Wolfram Sang Wolfram> --- Wolfram> Based on v3.5-rc2. Only build test

Re: [PATCH] i2c: let the core register devices from devicetree

2012-06-13 Thread Grant Likely
On Wed, 13 Jun 2012 23:12:10 +0200, Wolfram Sang wrote: > Currently, every driver has to do it on its own, but it should be done > in the core, like we already do with board_info structs. > > Signed-off-by: Wolfram Sang FWIW, and without any actual compiling or testing: Acked-by: Grant Likely

Re: [PATCH] i2c: let the core register devices from devicetree

2012-06-13 Thread Stephen Warren
On 06/13/2012 03:12 PM, Wolfram Sang wrote: > Currently, every driver has to do it on its own, but it should be done > in the core, like we already do with board_info structs. At least on Tegra this works fine, Tested-by: Stephen Warren ___ Linuxppc-dev

Re: [PATCH] i2c: let the core register devices from devicetree

2012-06-13 Thread Benjamin Herrenschmidt
On Wed, 2012-06-13 at 23:12 +0200, Wolfram Sang wrote: > Currently, every driver has to do it on its own, but it should be done > in the core, like we already do with board_info structs. > > Signed-off-by: Wolfram Sang > --- > > Based on v3.5-rc2. Only build tested, I don't have a OF based devic

[PATCH] i2c: let the core register devices from devicetree

2012-06-13 Thread Wolfram Sang
Currently, every driver has to do it on its own, but it should be done in the core, like we already do with board_info structs. Signed-off-by: Wolfram Sang --- Based on v3.5-rc2. Only build tested, I don't have a OF based device around at the moment. @Peter: Why does ocores do the device regist