On Mon, 2008-07-07 at 16:47 -0700, Grant Erickson wrote:
>
> Would you prefer?
>
> +#define RGMII_FER_MII(idx) RGMII_FER_GMII(idx)
>
> Having the "extra" mnemonic makes the code end up looking less like a typo
> and more like a conscious decision: "Yes, we know MII and GMII are the same
On 7/7/08 4:40 PM, Benjamin Herrenschmidt wrote:
> On Mon, 2008-07-07 at 16:31 -0700, Grant Erickson wrote:
>> #define RGMII_FER_GMII(idx)(0x7 << ((idx) * 4))
>> +#define RGMII_FER_MII(idx) (0x7 << ((idx) * 4))
>
> Hrm... the setting of the register is exactly the same right ?
>
> Do we
On Mon, 2008-07-07 at 16:31 -0700, Grant Erickson wrote:
> #define RGMII_FER_GMII(idx)(0x7 << ((idx) * 4))
> +#define RGMII_FER_MII(idx) (0x7 << ((idx) * 4))
Hrm... the setting of the register is exactly the same right ?
Do we -really- need that ?
Ben.
This patch adds support to the RGMII handler in the EMAC driver for
the MII PHY mode such that device tree entries of the form `phy-mode = "mii";'
are recognized and handled appropriately.
While logically, in software, "gmii" and "mii" modes are the same,
they are wired differently, so it makes se
