Re: [PATCH] macintosh: macio_asic: fix resource_size.cocci warnings

2022-04-25 Thread Uwe Kleine-König
Hello Michael, On Fri, Apr 22, 2022 at 04:44:24PM +1000, Michael Ellerman wrote: > Yihao Han writes: > > - if (index == 0 && (res->end - res->start) > 0xfff) > > + if (index == 0 && (resource_size(res)) > 0xfff) > > res->end = res->start + 0xfff; > > -

Re: [PATCH] macintosh: macio_asic: fix resource_size.cocci warnings

2022-04-22 Thread Michael Ellerman
Yihao Han writes: > drivers/macintosh/macio_asic.c:219:26-29: WARNING: > Suspicious code. resource_size is maybe missing with res > drivers/macintosh/macio_asic.c:221:26-29: WARNING: > Suspicious code. resource_size is maybe missing with res > > Use resource_size function on resource object

Re: [PATCH] macintosh: macio_asic: fix resource_size.cocci warnings

2022-04-19 Thread Uwe Kleine-König
On Thu, Apr 14, 2022 at 07:02:42AM -0700, Yihao Han wrote: > drivers/macintosh/macio_asic.c:219:26-29: WARNING: > Suspicious code. resource_size is maybe missing with res > drivers/macintosh/macio_asic.c:221:26-29: WARNING: > Suspicious code. resource_size is maybe missing with res For log

[PATCH] macintosh: macio_asic: fix resource_size.cocci warnings

2022-04-17 Thread Yihao Han
drivers/macintosh/macio_asic.c:219:26-29: WARNING: Suspicious code. resource_size is maybe missing with res drivers/macintosh/macio_asic.c:221:26-29: WARNING: Suspicious code. resource_size is maybe missing with res Use resource_size function on resource object instead of explicit computation.