Re: [PATCH] misc: cxl: sysfs.c: Remove unused function

2014-12-21 Thread Michael Ellerman
On Sun, 2014-12-21 at 13:46 +0100, Rickard Strandqvist wrote: > 2014-12-21 5:05 GMT+01:00 Michael Neuling : > >> Remove the function mmio_size_show() that is not used anywhere. > > > > Did you compile check this patch? > > > > drivers/misc/cxl/sysfs.c:291:74: error: ‘mmio_size_show’ undeclared he

Re: [PATCH] misc: cxl: sysfs.c: Remove unused function

2014-12-21 Thread Rickard Strandqvist
2014-12-21 5:05 GMT+01:00 Michael Neuling : >> Remove the function mmio_size_show() that is not used anywhere. > > Did you compile check this patch? > > drivers/misc/cxl/sysfs.c:291:74: error: ‘mmio_size_show’ undeclared here > (not in a function) > > It's used here: > static struct devi

Re: [PATCH] misc: cxl: sysfs.c: Remove unused function

2014-12-20 Thread Michael Neuling
> Remove the function mmio_size_show() that is not used anywhere. Did you compile check this patch? drivers/misc/cxl/sysfs.c:291:74: error: ‘mmio_size_show’ undeclared here (not in a function) It's used here: static struct device_attribute afu_attrs[] = { __ATTR_RO(mmi

[PATCH] misc: cxl: sysfs.c: Remove unused function

2014-12-20 Thread Rickard Strandqvist
Remove the function mmio_size_show() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- drivers/misc/cxl/sysfs.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/misc/cxl/s