Re[2]: [PATCH] mm/shmem.c: fix division by zero

2008-12-23 Thread Yuri Tikhonov
Hello Hugh, On Tuesday, December 23, 2008 you wrote: > On Fri, 19 Dec 2008, Yuri Tikhonov wrote: >> >> The following patch fixes division by zero, which we have in >> shmem_truncate_range() and shmem_unuse_inode(), if use big >> PAGE_SIZE values (e.g. 256KB on ppc44x). >> >> With 256KB PAGE_S

Re: [PATCH] mm/shmem.c: fix division by zero

2008-12-22 Thread Hugh Dickins
On Fri, 19 Dec 2008, Yuri Tikhonov wrote: > > The following patch fixes division by zero, which we have in > shmem_truncate_range() and shmem_unuse_inode(), if use big > PAGE_SIZE values (e.g. 256KB on ppc44x). > > With 256KB PAGE_SIZE the ENTRIES_PER_PAGEPAGE constant becomes > too large (0x1.00

Re: [PATCH] mm/shmem.c: fix division by zero

2008-12-19 Thread Andrew Morton
On Fri, 19 Dec 2008 08:44:57 +0300 Yuri Tikhonov wrote: > > The following patch fixes division by zero, which we have in > shmem_truncate_range() and shmem_unuse_inode(), if use big > PAGE_SIZE values (e.g. 256KB on ppc44x). > > With 256KB PAGE_SIZE the ENTRIES_PER_PAGEPAGE constant becomes > t

[PATCH] mm/shmem.c: fix division by zero

2008-12-18 Thread Yuri Tikhonov
The following patch fixes division by zero, which we have in shmem_truncate_range() and shmem_unuse_inode(), if use big PAGE_SIZE values (e.g. 256KB on ppc44x). With 256KB PAGE_SIZE the ENTRIES_PER_PAGEPAGE constant becomes too large (0x1..), so this patch just changes the types from 'ulo