Re: [PATCH] pasemi_dma: Driver for PA Semi PWRficient on-chip DMA engine

2008-03-11 Thread Dan Williams
On Tue, 2008-03-11 at 11:29 -0700, Kumar Gala wrote: > > My fault for not pushing out this cleanup to the old url while the > > git-md-accel changeover was pending. > > Any reason not to push Zhang's fixes for 2.6.25? I plan to push these fixes for 2.6.25. Olof had some valid comments about "Fix

Re: [PATCH] pasemi_dma: Driver for PA Semi PWRficient on-chip DMA engine

2008-03-11 Thread Kumar Gala
Also this driver from git-md-accel is pretty sick: drivers/dma/fsldma.c:439: warning: comparison of distinct pointer types lacks a cast drivers/dma/fsldma.c: In function `fsl_chan_xfer_ld_queue': drivers/dma/fsldma.c:584: warning: long long unsigned int format, dma_addr_t arg (arg 4) drive

Re: [PATCH] pasemi_dma: Driver for PA Semi PWRficient on-chip DMA engine

2008-03-11 Thread Dan Williams
On Tue, 2008-03-11 at 10:53 -0700, Andrew Morton wrote: > On Tue, 11 Mar 2008 09:25:45 -0500 > Olof Johansson <[EMAIL PROTECTED]> wrote: > > > On Tue, Mar 11, 2008 at 12:06:19AM -0700, Andrew Morton wrote: > > > On Thu, 6 Mar 2008 17:39:00 -0600 Olof Johansson <[EMAIL PROTECTED]> > > > wrote: > >

Re: [PATCH] pasemi_dma: Driver for PA Semi PWRficient on-chip DMA engine

2008-03-11 Thread Andrew Morton
On Tue, 11 Mar 2008 09:25:45 -0500 Olof Johansson <[EMAIL PROTECTED]> wrote: > On Tue, Mar 11, 2008 at 12:06:19AM -0700, Andrew Morton wrote: > > On Thu, 6 Mar 2008 17:39:00 -0600 Olof Johansson <[EMAIL PROTECTED]> wrote: > > > > > pasemi_dma: Driver for PA Semi PWRficient on-chip DMA engine > >

Re: [PATCH] pasemi_dma: Driver for PA Semi PWRficient on-chip DMA engine

2008-03-11 Thread Olof Johansson
On Tue, Mar 11, 2008 at 12:06:19AM -0700, Andrew Morton wrote: > On Thu, 6 Mar 2008 17:39:00 -0600 Olof Johansson <[EMAIL PROTECTED]> wrote: > > > pasemi_dma: Driver for PA Semi PWRficient on-chip DMA engine > > > > First cut at a dma copy offload driver for PA Semi PWRficient. It uses the >

Re: [PATCH] pasemi_dma: Driver for PA Semi PWRficient on-chip DMA engine

2008-03-11 Thread Andrew Morton
On Thu, 6 Mar 2008 17:39:00 -0600 Olof Johansson <[EMAIL PROTECTED]> wrote: > pasemi_dma: Driver for PA Semi PWRficient on-chip DMA engine > > First cut at a dma copy offload driver for PA Semi PWRficient. It uses the > platform-specific functions to allocate channels, etc. Applied this on P

Re: [PATCH] pasemi_dma: Driver for PA Semi PWRficient on-chip DMA engine

2008-03-06 Thread Olof Johansson
On Fri, Mar 07, 2008 at 11:31:50AM +1100, Stephen Rothwell wrote: > Hi Olof, > > Just one thing I noticed ... > > On Thu, 6 Mar 2008 17:39:00 -0600 Olof Johansson <[EMAIL PROTECTED]> wrote: > > > > + dma_dev->device_dependency_added = pasemi_dma_dependency_added; > > device_dependency_added is

Re: [PATCH] pasemi_dma: Driver for PA Semi PWRficient on-chip DMA engine

2008-03-06 Thread Stephen Rothwell
Hi Olof, Just one thing I noticed ... On Thu, 6 Mar 2008 17:39:00 -0600 Olof Johansson <[EMAIL PROTECTED]> wrote: > > + dma_dev->device_dependency_added = pasemi_dma_dependency_added; device_dependency_added is going away in 2.6.26 ... -- Cheers, Stephen Rothwell[EMAIL

[PATCH] pasemi_dma: Driver for PA Semi PWRficient on-chip DMA engine

2008-03-06 Thread Olof Johansson
pasemi_dma: Driver for PA Semi PWRficient on-chip DMA engine First cut at a dma copy offload driver for PA Semi PWRficient. It uses the platform-specific functions to allocate channels, etc. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> --- This has some dependencies on other patches c