Re: [PATCH] powernv/opal: Handle OPAL_WRONG_STATE error from OPAL fails

2017-02-28 Thread Vipin K Parashar
Thanks!! for review. Sending out v2 with suggested changes. On Thursday 23 February 2017 09:22 AM, Stewart Smith wrote: Michael Ellerman writes: Stewart Smith writes: Vipin K Parashar writes: On Monday 13 February 2017 06:13 AM, Michael Ellerman wrote: Vipin K Parashar writes: OPA

Re: [PATCH] powernv/opal: Handle OPAL_WRONG_STATE error from OPAL fails

2017-02-22 Thread Stewart Smith
Michael Ellerman writes: > Stewart Smith writes: > >> Vipin K Parashar writes: >>> On Monday 13 February 2017 06:13 AM, Michael Ellerman wrote: Vipin K Parashar writes: > OPAL returns OPAL_WRONG_STATE for XSCOM operations > > done to read any core FIR which is sleeping, o

Re: [PATCH] powernv/opal: Handle OPAL_WRONG_STATE error from OPAL fails

2017-02-19 Thread Michael Ellerman
Stewart Smith writes: > Vipin K Parashar writes: >> On Monday 13 February 2017 06:13 AM, Michael Ellerman wrote: >>> Vipin K Parashar writes: >>> OPAL returns OPAL_WRONG_STATE for XSCOM operations done to read any core FIR which is sleeping, offline. >>> OK. >>> >>> Do we know wh

Re: [PATCH] powernv/opal: Handle OPAL_WRONG_STATE error from OPAL fails

2017-02-15 Thread Stewart Smith
Vipin K Parashar writes: > On Monday 13 February 2017 06:13 AM, Michael Ellerman wrote: >> Vipin K Parashar writes: >> >>> OPAL returns OPAL_WRONG_STATE for XSCOM operations >>> >>> done to read any core FIR which is sleeping, offline. >> OK. >> >> Do we know why Linux is causing that to happen?

Re: [PATCH] powernv/opal: Handle OPAL_WRONG_STATE error from OPAL fails

2017-02-15 Thread Vipin K Parashar
Hi Michael, Thanks!! for review. Answers to your questions as below: On Monday 13 February 2017 06:13 AM, Michael Ellerman wrote: Vipin K Parashar writes: OPAL returns OPAL_WRONG_STATE for XSCOM operations done to read any core FIR which is sleeping, offline. OK. Do we know why Linux is

Re: [PATCH] powernv/opal: Handle OPAL_WRONG_STATE error from OPAL fails

2017-02-14 Thread Stewart Smith
Michael Ellerman writes: > Vipin K Parashar writes: > >> OPAL returns OPAL_WRONG_STATE for XSCOM operations >> >> done to read any core FIR which is sleeping, offline. > > OK. > > Do we know why Linux is causing that to happen? > > It's also returned from many of the XIVE routines if we're in the

Re: [PATCH] powernv/opal: Handle OPAL_WRONG_STATE error from OPAL fails

2017-02-12 Thread Michael Ellerman
Vipin K Parashar writes: > OPAL returns OPAL_WRONG_STATE for XSCOM operations > > done to read any core FIR which is sleeping, offline. OK. Do we know why Linux is causing that to happen? It's also returned from many of the XIVE routines if we're in the wrong xive mode, all of which would indi

Re: [PATCH] powernv/opal: Handle OPAL_WRONG_STATE error from OPAL fails

2017-01-26 Thread Vipin K Parashar
OPAL returns OPAL_WRONG_STATE for XSCOM operations done to read any core FIR which is sleeping, offline. On Friday 27 January 2017 05:47 AM, Michael Ellerman wrote: Vipin K Parashar writes: Added check for OPAL_WRONG_STATE error code returned from OPAL. Currently Linux flashes "unexpected e

Re: [PATCH] powernv/opal: Handle OPAL_WRONG_STATE error from OPAL fails

2017-01-26 Thread Michael Ellerman
Vipin K Parashar writes: > Added check for OPAL_WRONG_STATE error code returned from OPAL. > Currently Linux flashes "unexpected error" over console for this > error. This will avoid throwing such message and return I/O error > for such OPAL failures. Why do we expect to get OPAL_WRONG_STATE ?

Re: [PATCH] powernv/opal: Handle OPAL_WRONG_STATE error from OPAL fails

2016-12-20 Thread Mukesh Ojha
On Tuesday 20 December 2016 07:46 PM, Vipin K Parashar wrote: Added check for OPAL_WRONG_STATE error code returned from OPAL. Currently Linux flashes "unexpected error" over console for this error. This will avoid throwing such message and return I/O error for such OPAL failures. Signed-off-by

[PATCH] powernv/opal: Handle OPAL_WRONG_STATE error from OPAL fails

2016-12-20 Thread Vipin K Parashar
Added check for OPAL_WRONG_STATE error code returned from OPAL. Currently Linux flashes "unexpected error" over console for this error. This will avoid throwing such message and return I/O error for such OPAL failures. Signed-off-by: Vipin K Parashar --- arch/powerpc/platforms/powernv/opal.c | 7