Re: [PATCH] powerpc/64e: Fix wrong test in __ptep_test_and_clear_young()

2023-09-05 Thread Christophe Leroy
Le 05/09/2023 à 06:46, Christophe Leroy a écrit : > > > Le 05/09/2023 à 04:36, Michael Ellerman a écrit : >> Christophe Leroy writes: >>> Commit 45201c879469 ("powerpc/nohash: Remove hash related code from >>> nohash headers.") replaced: >>> >>>    if ((pte_val(*ptep) & (_PAGE_ACCESSED |

Re: [PATCH] powerpc/64e: Fix wrong test in __ptep_test_and_clear_young()

2023-09-04 Thread Christophe Leroy
Le 05/09/2023 à 04:36, Michael Ellerman a écrit : > Christophe Leroy writes: >> Commit 45201c879469 ("powerpc/nohash: Remove hash related code from >> nohash headers.") replaced: >> >>if ((pte_val(*ptep) & (_PAGE_ACCESSED | _PAGE_HASHPTE)) == 0) >> return 0; >> >> By: >> >>if

Re: [PATCH] powerpc/64e: Fix wrong test in __ptep_test_and_clear_young()

2023-09-04 Thread Michael Ellerman
Christophe Leroy writes: > Commit 45201c879469 ("powerpc/nohash: Remove hash related code from > nohash headers.") replaced: > > if ((pte_val(*ptep) & (_PAGE_ACCESSED | _PAGE_HASHPTE)) == 0) > return 0; > > By: > > if (pte_young(*ptep)) > return 0; > > But it should be: > > if

[PATCH] powerpc/64e: Fix wrong test in __ptep_test_and_clear_young()

2023-09-02 Thread Christophe Leroy
Commit 45201c879469 ("powerpc/nohash: Remove hash related code from nohash headers.") replaced: if ((pte_val(*ptep) & (_PAGE_ACCESSED | _PAGE_HASHPTE)) == 0) return 0; By: if (pte_young(*ptep)) return 0; But it should be: if (!pte_young(*ptep)) return 0; Fix it.