Re: [PATCH] powerpc/bpf: Use bctrl for making function calls

2021-06-26 Thread Michael Ellerman
On Wed, 9 Jun 2021 14:30:24 +0530, Naveen N. Rao wrote: > blrl corrupts the link stack. Instead use bctrl when making function > calls from BPF programs. Applied to powerpc/next. [1/1] powerpc/bpf: Use bctrl for making function calls

Re: [PATCH] powerpc/bpf: Use bctrl for making function calls

2021-06-09 Thread Naveen N. Rao
Christophe Leroy wrote: Le 09/06/2021 à 11:00, Naveen N. Rao a écrit : blrl corrupts the link stack. Instead use bctrl when making function calls from BPF programs. What's the link stack ? Is it the PPC64 branch predictor stack ? c974809a26a13e ("powerpc/vdso: Avoid link stack corruption

Re: [PATCH] powerpc/bpf: Use bctrl for making function calls

2021-06-09 Thread Christophe Leroy
Le 09/06/2021 à 11:00, Naveen N. Rao a écrit : blrl corrupts the link stack. Instead use bctrl when making function calls from BPF programs. What's the link stack ? Is it the PPC64 branch predictor stack ? Reported-by: Anton Blanchard Signed-off-by: Naveen N. Rao ---

[PATCH] powerpc/bpf: Use bctrl for making function calls

2021-06-09 Thread Naveen N. Rao
blrl corrupts the link stack. Instead use bctrl when making function calls from BPF programs. Reported-by: Anton Blanchard Signed-off-by: Naveen N. Rao --- arch/powerpc/include/asm/ppc-opcode.h | 1 + arch/powerpc/net/bpf_jit_comp32.c | 4 ++-- arch/powerpc/net/bpf_jit_comp64.c | 12