Re: [PATCH] powerpc/eeh: Delay slot presence check once driver is notified about the pci error.

2021-11-29 Thread Mahesh J Salgaonkar
On 2021-11-24 23:01:45 Wed, Oliver O'Halloran wrote: > On Wed, Nov 24, 2021 at 12:05 AM Mahesh Salgaonkar > wrote: > > > > *snip* > > > > This causes the EEH handler to get stuck for ~6 > > seconds before it could notify that the pci error has been detected and > > stop any active operations. Hen

Re: [PATCH] powerpc/eeh: Delay slot presence check once driver is notified about the pci error.

2021-11-24 Thread Mahesh J Salgaonkar
On 2021-11-24 22:57:13 Wed, Oliver O'Halloran wrote: > On Wed, Nov 24, 2021 at 7:45 PM Mahesh J Salgaonkar > wrote: > > > > No it doesn't. We will still do a presence check before the recovery > > process starts. This patch moves the check after notifying the driver to > > stop active I/O operatio

Re: [PATCH] powerpc/eeh: Delay slot presence check once driver is notified about the pci error.

2021-11-24 Thread Oliver O'Halloran
On Wed, Nov 24, 2021 at 12:05 AM Mahesh Salgaonkar wrote: > > *snip* > > This causes the EEH handler to get stuck for ~6 > seconds before it could notify that the pci error has been detected and > stop any active operations. Hence with running I/O traffic, during this 6 > seconds, the network driv

Re: [PATCH] powerpc/eeh: Delay slot presence check once driver is notified about the pci error.

2021-11-24 Thread Oliver O'Halloran
On Wed, Nov 24, 2021 at 7:45 PM Mahesh J Salgaonkar wrote: > > No it doesn't. We will still do a presence check before the recovery > process starts. This patch moves the check after notifying the driver to > stop active I/O operations. If a presence check finds the device isn't > present, we will

Re: [PATCH] powerpc/eeh: Delay slot presence check once driver is notified about the pci error.

2021-11-24 Thread Mahesh J Salgaonkar
On 2021-11-24 10:14:30 Wed, Michael Ellerman wrote: > Mahesh Salgaonkar writes: > > When certain PHB HW failure causes phyp to recover PHB, it marks the PE > > state as temporarily unavailable until recovery is complete. This also > > triggers an EEH handler in Linux which needs to notify drivers,

Re: [PATCH] powerpc/eeh: Delay slot presence check once driver is notified about the pci error.

2021-11-23 Thread Michael Ellerman
Mahesh Salgaonkar writes: > When certain PHB HW failure causes phyp to recover PHB, it marks the PE > state as temporarily unavailable until recovery is complete. This also > triggers an EEH handler in Linux which needs to notify drivers, and perform > recovery. But before notifying the driver abo

[PATCH] powerpc/eeh: Delay slot presence check once driver is notified about the pci error.

2021-11-23 Thread Mahesh Salgaonkar
When certain PHB HW failure causes phyp to recover PHB, it marks the PE state as temporarily unavailable until recovery is complete. This also triggers an EEH handler in Linux which needs to notify drivers, and perform recovery. But before notifying the driver about the pci error it uses get_adapte