Re: [PATCH] powerpc/mm/hash: Fix the reference bit update when handling hash fault

2016-06-07 Thread Michael Ellerman
On Thu, 2016-06-02 at 08:12 -0700, Hugh Dickins wrote: > On Tue, 31 May 2016, Hugh Dickins wrote: > > > > But all my evidence so far is that it is now right: I'll continue > > testing v4.6+fix on a couple of loads until this evening: all is > > well so far. And then switch to testing v4.5+fix on

Re: [PATCH] powerpc/mm/hash: Fix the reference bit update when handling hash fault

2016-06-02 Thread Hugh Dickins via Linuxppc-dev
On Tue, 31 May 2016, Hugh Dickins wrote: > > But all my evidence so far is that it is now right: I'll continue > testing v4.6+fix on a couple of loads until this evening: all is > well so far. And then switch to testing v4.5+fix on those loads > for another day and a half. I'm glad to confirm: y

Re: [PATCH] powerpc/mm/hash: Fix the reference bit update when handling hash fault

2016-05-31 Thread Hugh Dickins via Linuxppc-dev
On Tue, 31 May 2016, Benjamin Herrenschmidt wrote: > On Mon, 2016-05-30 at 09:39 -0700, Hugh Dickins wrote: > > I don't mean to be churlish, and subtract from your triumph in tracking > > this down (assuming you have), but that commit log... okay, it's intended > > for powerpc mmu experts, not me,

Re: [PATCH] powerpc/mm/hash: Fix the reference bit update when handling hash fault

2016-05-30 Thread Benjamin Herrenschmidt
On Mon, 2016-05-30 at 09:39 -0700, Hugh Dickins wrote: > I don't mean to be churlish, and subtract from your triumph in tracking > this down (assuming you have), but that commit log... okay, it's intended > for powerpc mmu experts, not me, but if it hasn't already gone into git, > then a rewrite co

Re: [PATCH] powerpc/mm/hash: Fix the reference bit update when handling hash fault

2016-05-30 Thread Hugh Dickins via Linuxppc-dev
On Fri, 27 May 2016, Aneesh Kumar K.V wrote: > When we converted the asm routines to C functions, we missed updating > HPTE_R_R based on _PAGE_ACCESSED. ASM code used to copy over the lower > bits from pte via. > > andi. r3,r30,0x1fe/* Get basic set of flags */ > > Fixes: 'commit 89f

[PATCH] powerpc/mm/hash: Fix the reference bit update when handling hash fault

2016-05-26 Thread Aneesh Kumar K.V
When we converted the asm routines to C functions, we missed updating HPTE_R_R based on _PAGE_ACCESSED. ASM code used to copy over the lower bits from pte via. andi. r3,r30,0x1fe/* Get basic set of flags */ Fixes: 'commit 89ff725051d1 ("powerpc/mm: Convert __hash_page_64K to C")' W