Re: [PATCH] powerpc/powermac/pfunc_base: Fix refcount leak bug in macio_gpio_init_one()

2022-09-09 Thread Michael Ellerman
On Sat, 16 Jul 2022 15:31:11 +0800, Liang He wrote: > We should call of_node_put() for the reference 'gparent' escaped > out of the for_each_child_of_node() as it has increased the refcount. > > Applied to powerpc/next. [1/1] powerpc/powermac/pfunc_base: Fix refcount leak bug in

Re:Re: [PATCH] powerpc/powermac/pfunc_base: Fix refcount leak bug in macio_gpio_init_one()

2022-08-13 Thread Liang He
At 2022-08-02 12:51:08, "Benjamin Herrenschmidt" wrote: >On Sat, 2022-07-16 at 15:31 +0800, Liang He wrote: >> We should call of_node_put() for the reference 'gparent' escaped >> out of the for_each_child_of_node() as it has increased the refcount. > >Same comment as before. That stuff

Re: [PATCH] powerpc/powermac/pfunc_base: Fix refcount leak bug in macio_gpio_init_one()

2022-08-01 Thread Benjamin Herrenschmidt
On Sat, 2022-07-16 at 15:31 +0800, Liang He wrote: > We should call of_node_put() for the reference 'gparent' escaped > out of the for_each_child_of_node() as it has increased the refcount. Same comment as before. That stuff happens once at boot, there's never any dynamic allocation/deallocation

[PATCH] powerpc/powermac/pfunc_base: Fix refcount leak bug in macio_gpio_init_one()

2022-07-16 Thread Liang He
We should call of_node_put() for the reference 'gparent' escaped out of the for_each_child_of_node() as it has increased the refcount. Fixes: 5b9ca526917b ("[PATCH] 3/5 powerpc: Add platform functions interpreter") Signed-off-by: Liang He --- arch/powerpc/platforms/powermac/pfunc_base.c | 2 ++