Re: [PATCH] powerpc: Initialize local variable fdt to NULL in elf64_load()

2021-04-23 Thread Rob Herring
On Fri, Apr 23, 2021 at 9:42 AM David Laight wrote: > > From: Michael Ellerman > > Sent: 23 April 2021 14:51 > ... > > > (Does anyone - and by anyone I mean any large distro - compile with > > > local variables inited by the compiler?) > > > > This is where I say, "yes, Android" and you say "ugh n

RE: [PATCH] powerpc: Initialize local variable fdt to NULL in elf64_load()

2021-04-23 Thread David Laight
From: Michael Ellerman > Sent: 23 April 2021 14:51 ... > > (Does anyone - and by anyone I mean any large distro - compile with > > local variables inited by the compiler?) > > This is where I say, "yes, Android" and you say "ugh no I meant a real > distro", and I say "well ...". > > But yeah does

Re: [PATCH] powerpc: Initialize local variable fdt to NULL in elf64_load()

2021-04-23 Thread Michael Ellerman
Daniel Axtens writes: > Daniel Axtens writes: > >> Hi Lakshmi, >> >>> On 4/15/21 12:14 PM, Lakshmi Ramasubramanian wrote: >>> >>> Sorry - missed copying device-tree and powerpc mailing lists. >>> There are a few "goto out;" statements before the local variable "fdt" is initialized throu

Re: [PATCH] powerpc: Initialize local variable fdt to NULL in elf64_load()

2021-04-22 Thread Segher Boessenkool
On Thu, Apr 22, 2021 at 08:05:27AM +, David Laight wrote: > > (Does anyone - and by anyone I mean any large distro - compile with > > local variables inited by the compiler?) > > There are compilers that initialise locals to zero for 'debug' builds > and leave the 'random' for optimised 'relea

Re: [PATCH] powerpc: Initialize local variable fdt to NULL in elf64_load()

2021-04-22 Thread Dan Carpenter
On Thu, Apr 22, 2021 at 08:05:27AM +, David Laight wrote: > From: Daniel Axtens > > Sent: 22 April 2021 03:21 > > > > > Hi Lakshmi, > > > > > >> On 4/15/21 12:14 PM, Lakshmi Ramasubramanian wrote: > > >> > > >> Sorry - missed copying device-tree and powerpc mailing lists. > > >> > > >>> There

RE: [PATCH] powerpc: Initialize local variable fdt to NULL in elf64_load()

2021-04-22 Thread David Laight
From: Daniel Axtens > Sent: 22 April 2021 03:21 > > > Hi Lakshmi, > > > >> On 4/15/21 12:14 PM, Lakshmi Ramasubramanian wrote: > >> > >> Sorry - missed copying device-tree and powerpc mailing lists. > >> > >>> There are a few "goto out;" statements before the local variable "fdt" > >>> is initiali

Re: [PATCH] powerpc: Initialize local variable fdt to NULL in elf64_load()

2021-04-21 Thread Daniel Axtens
Daniel Axtens writes: > Hi Lakshmi, > >> On 4/15/21 12:14 PM, Lakshmi Ramasubramanian wrote: >> >> Sorry - missed copying device-tree and powerpc mailing lists. >> >>> There are a few "goto out;" statements before the local variable "fdt" >>> is initialized through the call to of_kexec_alloc_and_

Re: [PATCH] powerpc: Initialize local variable fdt to NULL in elf64_load()

2021-04-20 Thread Lakshmi Ramasubramanian
On 4/20/21 8:47 AM, Rob Herring wrote: On Tue, Apr 20, 2021 at 10:04 AM Lakshmi Ramasubramanian wrote: On 4/20/21 7:42 AM, Lakshmi Ramasubramanian wrote: On 4/20/21 6:06 AM, Rob Herring wrote: On Tue, Apr 20, 2021 at 12:20 AM Lakshmi Ramasubramanian wrote: On 4/19/21 10:00 PM, Dan Carpent

Re: [PATCH] powerpc: Initialize local variable fdt to NULL in elf64_load()

2021-04-20 Thread Rob Herring
On Tue, Apr 20, 2021 at 10:04 AM Lakshmi Ramasubramanian wrote: > > On 4/20/21 7:42 AM, Lakshmi Ramasubramanian wrote: > > On 4/20/21 6:06 AM, Rob Herring wrote: > >> On Tue, Apr 20, 2021 at 12:20 AM Lakshmi Ramasubramanian > >> wrote: > >>> > >>> On 4/19/21 10:00 PM, Dan Carpenter wrote: >

Re: [PATCH] powerpc: Initialize local variable fdt to NULL in elf64_load()

2021-04-20 Thread Lakshmi Ramasubramanian
On 4/20/21 7:42 AM, Lakshmi Ramasubramanian wrote: On 4/20/21 6:06 AM, Rob Herring wrote: On Tue, Apr 20, 2021 at 12:20 AM Lakshmi Ramasubramanian wrote: On 4/19/21 10:00 PM, Dan Carpenter wrote: On Tue, Apr 20, 2021 at 09:30:16AM +1000, Michael Ellerman wrote: Lakshmi Ramasubramanian writ

Re: [PATCH] powerpc: Initialize local variable fdt to NULL in elf64_load()

2021-04-20 Thread Lakshmi Ramasubramanian
On 4/20/21 6:06 AM, Rob Herring wrote: On Tue, Apr 20, 2021 at 12:20 AM Lakshmi Ramasubramanian wrote: On 4/19/21 10:00 PM, Dan Carpenter wrote: On Tue, Apr 20, 2021 at 09:30:16AM +1000, Michael Ellerman wrote: Lakshmi Ramasubramanian writes: On 4/16/21 2:05 AM, Michael Ellerman wrote: D

Re: [PATCH] powerpc: Initialize local variable fdt to NULL in elf64_load()

2021-04-20 Thread Rob Herring
On Tue, Apr 20, 2021 at 12:20 AM Lakshmi Ramasubramanian wrote: > > On 4/19/21 10:00 PM, Dan Carpenter wrote: > > On Tue, Apr 20, 2021 at 09:30:16AM +1000, Michael Ellerman wrote: > >> Lakshmi Ramasubramanian writes: > >>> On 4/16/21 2:05 AM, Michael Ellerman wrote: > >>> > Daniel Axtens wr

Re: [PATCH] powerpc: Initialize local variable fdt to NULL in elf64_load()

2021-04-19 Thread Lakshmi Ramasubramanian
On 4/19/21 10:00 PM, Dan Carpenter wrote: On Tue, Apr 20, 2021 at 09:30:16AM +1000, Michael Ellerman wrote: Lakshmi Ramasubramanian writes: On 4/16/21 2:05 AM, Michael Ellerman wrote: Daniel Axtens writes: On 4/15/21 12:14 PM, Lakshmi Ramasubramanian wrote: Sorry - missed copying device-t

Re: [PATCH] powerpc: Initialize local variable fdt to NULL in elf64_load()

2021-04-19 Thread Dan Carpenter
On Tue, Apr 20, 2021 at 09:30:16AM +1000, Michael Ellerman wrote: > Lakshmi Ramasubramanian writes: > > On 4/16/21 2:05 AM, Michael Ellerman wrote: > > > >> Daniel Axtens writes: > On 4/15/21 12:14 PM, Lakshmi Ramasubramanian wrote: > > Sorry - missed copying device-tree and powerp

Re: [PATCH] powerpc: Initialize local variable fdt to NULL in elf64_load()

2021-04-19 Thread Lakshmi Ramasubramanian
On 4/19/21 4:30 PM, Michael Ellerman wrote: Lakshmi Ramasubramanian writes: On 4/16/21 2:05 AM, Michael Ellerman wrote: Daniel Axtens writes: On 4/15/21 12:14 PM, Lakshmi Ramasubramanian wrote: Sorry - missed copying device-tree and powerpc mailing lists. There are a few "goto out;" stat

Re: [PATCH] powerpc: Initialize local variable fdt to NULL in elf64_load()

2021-04-19 Thread Michael Ellerman
Lakshmi Ramasubramanian writes: > On 4/16/21 2:05 AM, Michael Ellerman wrote: > >> Daniel Axtens writes: On 4/15/21 12:14 PM, Lakshmi Ramasubramanian wrote: Sorry - missed copying device-tree and powerpc mailing lists. > There are a few "goto out;" statements before the lo

Re: [PATCH] powerpc: Initialize local variable fdt to NULL in elf64_load()

2021-04-16 Thread Lakshmi Ramasubramanian
On 4/16/21 2:05 AM, Michael Ellerman wrote: Daniel Axtens writes: On 4/15/21 12:14 PM, Lakshmi Ramasubramanian wrote: Sorry - missed copying device-tree and powerpc mailing lists. There are a few "goto out;" statements before the local variable "fdt" is initialized through the call to of_ke

Re: [PATCH] powerpc: Initialize local variable fdt to NULL in elf64_load()

2021-04-16 Thread Michael Ellerman
Dan Carpenter writes: > On Fri, Apr 16, 2021 at 09:00:12AM +0200, Christophe Leroy wrote: >> Le 16/04/2021 à 08:44, Daniel Axtens a écrit : >> > > On 4/15/21 12:14 PM, Lakshmi Ramasubramanian wrote: >> > > >> > > > There are a few "goto out;" statements before the local variable "fdt" >> > > > is

Re: [PATCH] powerpc: Initialize local variable fdt to NULL in elf64_load()

2021-04-16 Thread Michael Ellerman
Daniel Axtens writes: >> On 4/15/21 12:14 PM, Lakshmi Ramasubramanian wrote: >> >> Sorry - missed copying device-tree and powerpc mailing lists. >> >>> There are a few "goto out;" statements before the local variable "fdt" >>> is initialized through the call to of_kexec_alloc_and_setup_fdt() in >>

Re: [PATCH] powerpc: Initialize local variable fdt to NULL in elf64_load()

2021-04-16 Thread Dan Carpenter
On Fri, Apr 16, 2021 at 09:00:12AM +0200, Christophe Leroy wrote: > > > Le 16/04/2021 à 08:44, Daniel Axtens a écrit : > > Hi Lakshmi, > > > > > On 4/15/21 12:14 PM, Lakshmi Ramasubramanian wrote: > > > > > > Sorry - missed copying device-tree and powerpc mailing lists. > > > > > > > There are

Re: [PATCH] powerpc: Initialize local variable fdt to NULL in elf64_load()

2021-04-16 Thread Dan Carpenter
On Fri, Apr 16, 2021 at 04:44:30PM +1000, Daniel Axtens wrote: > Hi Lakshmi, > > > On 4/15/21 12:14 PM, Lakshmi Ramasubramanian wrote: > > > > Sorry - missed copying device-tree and powerpc mailing lists. > > > >> There are a few "goto out;" statements before the local variable "fdt" > >> is initi

Re: [PATCH] powerpc: Initialize local variable fdt to NULL in elf64_load()

2021-04-16 Thread Christophe Leroy
Le 16/04/2021 à 08:44, Daniel Axtens a écrit : Hi Lakshmi, On 4/15/21 12:14 PM, Lakshmi Ramasubramanian wrote: Sorry - missed copying device-tree and powerpc mailing lists. There are a few "goto out;" statements before the local variable "fdt" is initialized through the call to of_kexec_a

Re: [PATCH] powerpc: Initialize local variable fdt to NULL in elf64_load()

2021-04-15 Thread Daniel Axtens
Hi Lakshmi, > On 4/15/21 12:14 PM, Lakshmi Ramasubramanian wrote: > > Sorry - missed copying device-tree and powerpc mailing lists. > >> There are a few "goto out;" statements before the local variable "fdt" >> is initialized through the call to of_kexec_alloc_and_setup_fdt() in >> elf64_load(). T

Re: [PATCH] powerpc: Initialize local variable fdt to NULL in elf64_load()

2021-04-15 Thread Lakshmi Ramasubramanian
On 4/15/21 12:14 PM, Lakshmi Ramasubramanian wrote: Sorry - missed copying device-tree and powerpc mailing lists. There are a few "goto out;" statements before the local variable "fdt" is initialized through the call to of_kexec_alloc_and_setup_fdt() in elf64_load(). This will result in an unin