Re: [PATCH] powerpc: Reduce footprint of irq_stat

2010-01-31 Thread Anton Blanchard
Hi, > > +static inline void ack_bad_irq(unsigned int irq) > > +{ > > + printk(KERN_CRIT "unexpected IRQ trap at vector %02x\n", irq); > > +} > > Looks like some unrelated gunk slipped into this patch :-) We need that to link :) kernel/irq/handle.c: In function ‘handle_bad_irq’: kernel/irq/h

Re: [PATCH] powerpc: Reduce footprint of irq_stat

2010-01-31 Thread Benjamin Herrenschmidt
> +typedef struct { > + unsigned int __softirq_pending; > +} cacheline_aligned irq_cpustat_t; > + > +DECLARE_PER_CPU_SHARED_ALIGNED(irq_cpustat_t, irq_stat); > + > +#define __ARCH_IRQ_STAT > + > +#define local_softirq_pending() > __get_cpu_var(irq_stat).__softirq_pending > + > +stati

[PATCH] powerpc: Reduce footprint of irq_stat

2010-01-12 Thread Anton Blanchard
PowerPC is currently using asm-generic/hardirq.h which statically allocates an NR_CPUS irq_stat array. Switch to an arch specific implementation which uses per cpu data: On a kernel with NR_CPUS=1024, this saves quite a lot of memory: textdata bss dec hexfilename 8767