Re: [PATCH] powerpc: Use octal numbers for file permissions

2017-01-17 Thread Cyril Bur
On Tue, 2017-01-17 at 20:52 +1100, Michael Ellerman wrote: > Cyril Bur writes: > > > On Thu, 2017-01-12 at 14:54 +1100, Russell Currey wrote: > > > Symbolic macros are unintuitive and hard to read, whereas octal constants > > > are much easier to interpret. Replace macros for the basic permissio

Re: [PATCH] powerpc: Use octal numbers for file permissions

2017-01-17 Thread Oliver O'Halloran
It has been pointed out that this actually occured in 2017. My apologies. On 17/01/2017 9:50 PM, "Oliver O'Halloran" wrote: > "It's possible I missed one, but I did genuinely review all of it" > > Cyril Bur, 2016 > In a hobart pub, specifically The Winston > > On 17/01/2017 8:53 PM, "Michael Ell

Re: [PATCH] powerpc: Use octal numbers for file permissions

2017-01-17 Thread Oliver O'Halloran
"It's possible I missed one, but I did genuinely review all of it" Cyril Bur, 2016 In a hobart pub, specifically The Winston On 17/01/2017 8:53 PM, "Michael Ellerman" wrote: > Cyril Bur writes: > > > On Thu, 2017-01-12 at 14:54 +1100, Russell Currey wrote: > >> Symbolic macros are unintuitive

Re: [PATCH] powerpc: Use octal numbers for file permissions

2017-01-17 Thread Michael Ellerman
Cyril Bur writes: > On Thu, 2017-01-12 at 14:54 +1100, Russell Currey wrote: >> Symbolic macros are unintuitive and hard to read, whereas octal constants >> are much easier to interpret. Replace macros for the basic permission >> flags (user/group/other read/write/execute) with numeric constants

Re: [PATCH] powerpc: Use octal numbers for file permissions

2017-01-16 Thread Balbir Singh
On Mon, Jan 16, 2017 at 11:21:52AM +1100, Russell Currey wrote: > On Fri, 2017-01-13 at 13:41 +0530, Balbir Singh wrote: > > On Thu, Jan 12, 2017 at 02:54:13PM +1100, Russell Currey wrote: > > > Symbolic macros are unintuitive and hard to read, whereas octal constants > > > are much easier to inter

Re: [PATCH] powerpc: Use octal numbers for file permissions

2017-01-15 Thread Russell Currey
On Fri, 2017-01-13 at 13:41 +0530, Balbir Singh wrote: > On Thu, Jan 12, 2017 at 02:54:13PM +1100, Russell Currey wrote: > > Symbolic macros are unintuitive and hard to read, whereas octal constants > > are much easier to interpret.  Replace macros for the basic permission > > flags (user/group/oth

Re: [PATCH] powerpc: Use octal numbers for file permissions

2017-01-13 Thread Balbir Singh
On Thu, Jan 12, 2017 at 02:54:13PM +1100, Russell Currey wrote: > Symbolic macros are unintuitive and hard to read, whereas octal constants > are much easier to interpret. Replace macros for the basic permission > flags (user/group/other read/write/execute) with numeric constants > instead, across

Re: [PATCH] powerpc: Use octal numbers for file permissions

2017-01-12 Thread Cyril Bur
On Thu, 2017-01-12 at 14:54 +1100, Russell Currey wrote: > Symbolic macros are unintuitive and hard to read, whereas octal constants > are much easier to interpret. Replace macros for the basic permission > flags (user/group/other read/write/execute) with numeric constants > instead, across the wh

[PATCH] powerpc: Use octal numbers for file permissions

2017-01-11 Thread Russell Currey
Symbolic macros are unintuitive and hard to read, whereas octal constants are much easier to interpret. Replace macros for the basic permission flags (user/group/other read/write/execute) with numeric constants instead, across the whole powerpc tree. Introducing a significant number of changes ac