Re: [PATCH] powerpc: add 16K/64K pages support for the 44x PPC32 architectures.

2008-12-27 Thread Josh Boyer
On Sat, Dec 27, 2008 at 08:22:55AM +1100, Benjamin Herrenschmidt wrote: The code looks pretty clean now. I think if we're going to include this patch it should go in now. Acked-by: Josh Boyer jwbo...@linux.vnet.ibm.com Ben, Paul, What else is needed to get this patch included? Can

Re: [PATCH] powerpc: add 16K/64K pages support for the 44x PPC32 architectures.

2008-12-26 Thread Benjamin Herrenschmidt
The code looks pretty clean now. I think if we're going to include this patch it should go in now. Acked-by: Josh Boyer jwbo...@linux.vnet.ibm.com Ben, Paul, What else is needed to get this patch included? Can you remind us the pre-req ? Cheers, Ben.

Re: [PATCH] powerpc: add 16K/64K pages support for the 44x PPC32 architectures.

2008-12-24 Thread Josh Boyer
On Wed, Dec 17, 2008 at 02:56:07PM -0500, Josh Boyer wrote: On Thu, Dec 11, 2008 at 04:55:41AM +0300, Ilya Yanok wrote: This patch adds support for page sizes bigger than 4K (16K/64K) on PPC 44x. PGDIR table is much smaller than page in case of 16K/64K pages (512 and 32 bytes resp.) so we allocate

Re: [PATCH] powerpc: add 16K/64K pages support for the 44x PPC32 architectures.

2008-12-17 Thread Josh Boyer
On Thu, Dec 11, 2008 at 04:55:41AM +0300, Ilya Yanok wrote: This patch adds support for page sizes bigger than 4K (16K/64K) on PPC 44x. PGDIR table is much smaller than page in case of 16K/64K pages (512 and 32 bytes resp.) so we allocate PGDIR with kzalloc() instead of __get_free_pages(). PTE

Re[2]: [PATCH] powerpc: add 16K/64K pages support for the 44x PPC32 architectures.

2008-12-10 Thread Yuri Tikhonov
Hello Ben, On Wednesday, December 10, 2008 you wrote: Hi Ilya ! Looks good overall. A few minor comments. +config PPC_4K_PAGES + bool 4k page size + +config PPC_16K_PAGES + bool 16k page size if 44x + +config PPC_64K_PAGES + bool 64k page size if 44x || PPC64 +

[PATCH] powerpc: add 16K/64K pages support for the 44x PPC32 architectures.

2008-12-10 Thread Ilya Yanok
This patch adds support for page sizes bigger than 4K (16K/64K) on PPC 44x. PGDIR table is much smaller than page in case of 16K/64K pages (512 and 32 bytes resp.) so we allocate PGDIR with kzalloc() instead of __get_free_pages(). PTE table covers rather big memory area in case of 16K/64K pages

Re: Re[2]: [PATCH] powerpc: add 16K/64K pages support for the 44x PPC32 architectures.

2008-12-10 Thread Benjamin Herrenschmidt
On Wed, 2008-12-10 at 14:21 +0300, Yuri Tikhonov wrote: I'm not sure about the above PMD_MASK. Shouldn't we instead make it not build if (PKMAP_BASE PMD_MASK) != 0 ? We separated the !4K_PAGES case here exactly because (PKMAP_BASE PMD_MASK) != 0 [see the comment to this chunk -

Re: [PATCH] powerpc: add 16K/64K pages support for the 44x PPC32 architectures.

2008-12-10 Thread Ilya Yanok
Hello guys, please discard this patch. It just doesn't compile with CONFIG_HIGHMEM set. I'll post updated patch in a short time. Excuse me. Regards, Ilya. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org

Re: [PATCH] powerpc: add 16K/64K pages support for the 44x PPC32 architectures.

2008-12-10 Thread Ilya Yanok
Hi Benjamin, Benjamin Herrenschmidt wrote: I'm not sure about the above PMD_MASK. Shouldn't we instead make it not build if (PKMAP_BASE PMD_MASK) != 0 ? We separated the !4K_PAGES case here exactly because (PKMAP_BASE PMD_MASK) != 0 [see the comment to this chunk - why]. So,

[PATCH] powerpc: add 16K/64K pages support for the 44x PPC32 architectures.

2008-12-10 Thread Ilya Yanok
This patch adds support for page sizes bigger than 4K (16K/64K) on PPC 44x. PGDIR table is much smaller than page in case of 16K/64K pages (512 and 32 bytes resp.) so we allocate PGDIR with kzalloc() instead of __get_free_pages(). PTE table covers rather big memory area in case of 16K/64K pages

Re: [PATCH] powerpc: add 16K/64K pages support for the 44x PPC32 architectures.

2008-12-09 Thread Benjamin Herrenschmidt
Hi Ilya ! Looks good overall. A few minor comments. +config PPC_4K_PAGES + bool 4k page size + +config PPC_16K_PAGES + bool 16k page size if 44x + +config PPC_64K_PAGES + bool 64k page size if 44x || PPC64 + select PPC_HAS_HASH_64K if PPC64 I'd rather if the PPC64

Re: [PATCH] powerpc: add 16K/64K pages support for the 44x PPC32 architectures.

2008-12-01 Thread Hollis Blanchard
On Thu, Nov 27, 2008 at 5:44 PM, Ilya Yanok [EMAIL PROTECTED] wrote: This patch adds support for page sizes bigger than 4K (16K/64K) on PPC 44x. PGDIR table is much smaller than page in case of 16K/64K pages (512 and 32 bytes resp.) so we allocate PGDIR with kzalloc() instead of

Re: [PATCH] powerpc: add 16K/64K pages support for the 44x PPC32 architectures.

2008-12-01 Thread Josh Boyer
On Mon, Dec 01, 2008 at 05:06:03PM -0600, Hollis Blanchard wrote: On Thu, Nov 27, 2008 at 5:44 PM, Ilya Yanok [EMAIL PROTECTED] wrote: This patch adds support for page sizes bigger than 4K (16K/64K) on PPC 44x. PGDIR table is much smaller than page in case of 16K/64K pages (512 and 32 bytes

Re: [PATCH] powerpc: add 16K/64K pages support for the 44x PPC32 architectures.

2008-12-01 Thread Benjamin Herrenschmidt
On Mon, 2008-12-01 at 17:06 -0600, Hollis Blanchard wrote: Ben, you had some comments on the previous version of this patch. Have those been addressed to your satisfaction? If so, could you please queue this for 2.6.29? From the description, they have, however I haven't had a chance to look

[PATCH] powerpc: add 16K/64K pages support for the 44x PPC32 architectures.

2008-11-27 Thread Ilya Yanok
This patch adds support for page sizes bigger than 4K (16K/64K) on PPC 44x. PGDIR table is much smaller than page in case of 16K/64K pages (512 and 32 bytes resp.) so we allocate PGDIR with kzalloc() instead of __get_free_pages(). PTE table covers rather big memory area in case of 16K/64K pages