Re: [PATCH] powerpc: dtb and purgatory support for ppc32

2008-10-14 Thread Simon Horman
On Sun, Oct 12, 2008 at 03:39:55PM +0200, Sebastian Andrzej Siewior wrote: * Simon Horman | 2008-10-08 14:03:26 [+1100]: +#ifdef WITH_GAMECUBE +static int go_purgatory = 0; +#else +static int go_purgatory = 1; +#endif Can you just use WITH_GAMECUBE inside elf_ppc_load() and remove

Re: [PATCH] powerpc: dtb and purgatory support for ppc32

2008-10-12 Thread Sebastian Andrzej Siewior
* Simon Horman | 2008-10-08 14:03:26 [+1100]: +#ifdef WITH_GAMECUBE +static int go_purgatory = 0; +#else +static int go_purgatory = 1; +#endif Can you just use WITH_GAMECUBE inside elf_ppc_load() and remove the need for go_purgatory, or do you plan to make go_purgatory switchable at

Re: [PATCH] powerpc: dtb and purgatory support for ppc32

2008-10-07 Thread Simon Horman
On Wed, Oct 01, 2008 at 11:20:24PM +0200, Sebastian Andrzej Siewior wrote: From: Sebastian Siewior [EMAIL PROTECTED] Some code dtb scanning filling has been borrowed from ppc64. The old behavior is still available if compiled with GameCube, other PowerPC platform use the can purgatory and

Re: [PATCH] powerpc: dtb and purgatory support for ppc32

2008-10-02 Thread Sebastian Siewior
Kumar Gala wrote: are you trying to get this accepted? If the reviewer don't have any objections yes. You sound like there is something terrible wrong. Do you want it in smaller pieces? - k Sebastian -- Firmensitz: 88690 Uhldingen, Auf dem Berg 3 Registergericht: Amtsgericht Freiburg i.

Re: [PATCH] powerpc: dtb and purgatory support for ppc32

2008-10-02 Thread Simon Horman
On Thu, Oct 02, 2008 at 09:50:16AM +0200, Sebastian Siewior wrote: Kumar Gala wrote: are you trying to get this accepted? If the reviewer don't have any objections yes. You sound like there is something terrible wrong. Do you want it in smaller pieces? I'm not speaking on behalf of Kumar

Re: [PATCH] powerpc: dtb and purgatory support for ppc32

2008-10-02 Thread Kumar Gala
On Oct 1, 2008, at 4:20 PM, Sebastian Andrzej Siewior wrote: From: Sebastian Siewior [EMAIL PROTECTED] Some code dtb scanning filling has been borrowed from ppc64. The old behavior is still available if compiled with GameCube, other PowerPC platform use the can purgatory and specify a new

Re: [PATCH] powerpc: dtb and purgatory support for ppc32

2008-10-02 Thread Sebastian Andrzej Siewior
Kumar Gala wrote: On Oct 1, 2008, at 4:20 PM, Sebastian Andrzej Siewior wrote: From: Sebastian Siewior [EMAIL PROTECTED] Some code dtb scanning filling has been borrowed from ppc64. The old behavior is still available if compiled with GameCube, other PowerPC platform use the can purgatory

Re: [PATCH] powerpc: dtb and purgatory support for ppc32

2008-10-02 Thread Mohan Kumar M
Simon Horman wrote: On Thu, Oct 02, 2008 at 09:50:16AM +0200, Sebastian Siewior wrote: I'm not speaking on behalf of Kumar Gala, just on behalf of myself. Hi Horms, I would like to get some review of this patch by if possible. Also, I'm a little unclear of how it will interact with the

[PATCH] powerpc: dtb and purgatory support for ppc32

2008-10-01 Thread Sebastian Andrzej Siewior
From: Sebastian Siewior [EMAIL PROTECTED] Some code dtb scanning filling has been borrowed from ppc64. The old behavior is still available if compiled with GameCube, other PowerPC platform use the can purgatory and specify a new dtb. The purgatory is disabled because somehting is wrong and I

Re: [PATCH] powerpc: dtb and purgatory support for ppc32

2008-10-01 Thread Kumar Gala
On Oct 1, 2008, at 4:20 PM, Sebastian Andrzej Siewior wrote: From: Sebastian Siewior [EMAIL PROTECTED] Some code dtb scanning filling has been borrowed from ppc64. The old behavior is still available if compiled with GameCube, other PowerPC platform use the can purgatory and specify a new