[PATCH] powerpc: mtmsrd not defined

2010-08-22 Thread Sean MacLennan
Let's try a patch to get the ball rolling. ldstfp.S does not compile if mtmsrd not defined. But is it only defined for BOOK3S_64. This defines mtmsrd to be mtmsr on all but BOOK3S_64. This solves the compile problem... but I am not sure how to test it. I am also not sure if this is the best plac

Re: [PATCH] powerpc: mtmsrd not defined

2010-08-22 Thread Benjamin Herrenschmidt
On Sun, 2010-08-22 at 18:09 -0400, Sean MacLennan wrote: > Let's try a patch to get the ball rolling. > > ldstfp.S does not compile if mtmsrd not defined. But is it only defined > for BOOK3S_64. This defines mtmsrd to be mtmsr on all but BOOK3S_64. > This solves the compile problem... but I am no

Re: [PATCH] powerpc: mtmsrd not defined

2010-08-22 Thread Sean MacLennan
On Mon, 23 Aug 2010 08:34:54 +1000 Benjamin Herrenschmidt wrote: > I'd rather have a macro somewhere in ppc_asm.h (MTMSR ?) that does the > right thing. We might even already have one... We do here is a new, improved patch. Replace the BOOK3S_64 specific mtmsrd with the generic MTMSRD macro

Re: [PATCH] powerpc: mtmsrd not defined

2010-08-30 Thread Paul Mackerras
On Sun, Aug 22, 2010 at 06:48:44PM -0400, Sean MacLennan wrote: > Replace the BOOK3S_64 specific mtmsrd with the generic MTMSRD macro. > > Signed-off-by: Sean MacLennan Acked-by: Paul Mackerras ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.

Re: [PATCH] powerpc: mtmsrd not defined

2010-08-31 Thread Kumar Gala
On Aug 22, 2010, at 5:48 PM, Sean MacLennan wrote: > On Mon, 23 Aug 2010 08:34:54 +1000 > Benjamin Herrenschmidt wrote: > >> I'd rather have a macro somewhere in ppc_asm.h (MTMSR ?) that does the >> right thing. We might even already have one... > > We do here is a new, improved patch. >

Re: [PATCH] powerpc: mtmsrd not defined

2010-08-31 Thread Sean MacLennan
On Tue, 31 Aug 2010 11:17:17 -0500 Kumar Gala wrote: > Can we add proper CONFIG_PPC_FPU into this file. If nobody beats me to it I can try this evening. Cheers, Sean ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozla

Re: [PATCH] powerpc: mtmsrd not defined

2010-08-31 Thread Sean MacLennan
On Tue, 31 Aug 2010 13:46:05 -0400 Sean MacLennan wrote: > On Tue, 31 Aug 2010 11:17:17 -0500 > Kumar Gala wrote: > > > Can we add proper CONFIG_PPC_FPU into this file. > > If nobody beats me to it I can try this evening. I had to give up. Without the CONFIG_PPC_FPU it compiles fine for

Re: [PATCH] powerpc: mtmsrd not defined

2010-08-31 Thread Kumar Gala
On Aug 31, 2010, at 9:55 PM, Sean MacLennan wrote: > On Tue, 31 Aug 2010 13:46:05 -0400 > Sean MacLennan wrote: > >> On Tue, 31 Aug 2010 11:17:17 -0500 >> Kumar Gala wrote: >> >>> Can we add proper CONFIG_PPC_FPU into this file. >> >> If nobody beats me to it I can try this evening. >

Re: [PATCH] powerpc: mtmsrd not defined

2010-08-31 Thread Sean MacLennan
On Wed, 1 Sep 2010 01:45:46 -0500 Kumar Gala wrote: > For what defconfig setup do you get the errors above? 44x/ebony_defconfig Then enable KPROBES (or XMON). Then put an #ifdef CONFIG_PPC_FPU in ldstfp.S. Cheers, Sean ___ Linuxppc-dev mailing li

Re: [PATCH] powerpc: mtmsrd not defined

2010-09-01 Thread Paul Mackerras
On Tue, Aug 31, 2010 at 10:55:25PM -0400, Sean MacLennan wrote: > I had to give up. Without the CONFIG_PPC_FPU it compiles fine for an > FPU less 44x. But with the CONFIG_PPC_FPU, I get the following errors: Ah, those references would be from arch/powerpc/lib/sstep.c. Evidently we need #ifdef CO

Re: [PATCH] powerpc: mtmsrd not defined

2010-09-01 Thread Kumar Gala
On Sep 1, 2010, at 3:02 AM, Paul Mackerras wrote: > On Tue, Aug 31, 2010 at 10:55:25PM -0400, Sean MacLennan wrote: > >> I had to give up. Without the CONFIG_PPC_FPU it compiles fine for an >> FPU less 44x. But with the CONFIG_PPC_FPU, I get the following errors: > > Ah, those references would

Re: [PATCH] powerpc: mtmsrd not defined

2010-09-01 Thread Sean MacLennan
On Wed, 1 Sep 2010 18:02:14 +1000 Paul Mackerras wrote: > Ah, those references would be from arch/powerpc/lib/sstep.c. > Evidently we need #ifdef CONFIG_PPC_FPU around the emulation of the > floating-point loads and stores. I tried that yesterday and it didn't help, although maybe I forgot to ma

Re: [PATCH] powerpc: mtmsrd not defined

2010-09-01 Thread Sean MacLennan
Ok, I didn't catch all the cases the first time :( Since the errors seemed to come from copy_32.S, I didn't spend much time on sstep.c. Here is an updated patch the fixes the mtmsrd problem and maps out the floating point. Cheers, Sean Replace the BOOK3S_64 specific mtmsrd with the generic MT