-Original Message-
From: Paul Mackerras [mailto:[EMAIL PROTECTED]
Sent: Friday, October 10, 2008 1:14 PM
To: [EMAIL PROTECTED]
Cc: Arnd Bergmann; [EMAIL PROTECTED]; Sadashiiv, Halesh;
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] remove bogus ppc_select syscall
Benjamin Herrenschmidt
Please don't apply Arnd's patch. As I said, all we need is this
one-line change in arch/powerpc/include/asm/systbl.h:
-SYSX_SPU(sys_select,ppc32_select,ppc_select)
+SYSX_SPU(sys_select,ppc32_select,sys_select)
I have tested the testcase that I have provided at the time of
reporting
this
Sadashiiv, Halesh writes:
I have tested the testcase that I have provided at the time of reporting
this issue. But it didn't work as expected with the above patch you
provided.
(Failed to return EINVAL on negative value of n to select())
How is your testcase invoking select? Is it doing its
On Saturday 11 October 2008, Benjamin Herrenschmidt wrote:
-SYSX_SPU(sys_select,ppc32_select,ppc_select)
+SYSX_SPU(sys_select,ppc32_select,sys_select)
Ok, so you want to keep compat with the old stuff. Note that we still
have this weird thing that on 64-bit kernels, we don't provide
Arnd Bergmann writes:
Well, the point I made earlier ist that the native ppc32 path should
behave the same way as the compat ppc32 path. If we keep ppc_select
in one way or another, we should also have a compat wrapper for that,
right?
No - we have other old system calls that don't exist at
Benjamin Herrenschmidt writes:
On Wed, 2008-09-24 at 08:39 +0200, Arnd Bergmann wrote:
The ppc_select function was introduced in linux-2.3.48 in order to support
code confusing the legacy select() calling convention with the standard one.
Even 11 years ago, all correctly built code should
On Friday 10 October 2008, Paul Mackerras wrote:
Arnd Bergmann writes:
Well, the point I made earlier ist that the native ppc32 path should
behave the same way as the compat ppc32 path. If we keep ppc_select
in one way or another, we should also have a compat wrapper for that,
right?
On Friday 10 October 2008, Paul Mackerras wrote:
Please don't apply Arnd's patch. As I said, all we need is this
one-line change in arch/powerpc/include/asm/systbl.h:
-SYSX_SPU(sys_select,ppc32_select,ppc_select)
+SYSX_SPU(sys_select,ppc32_select,sys_select)
Paul.
FWIW,
Acked-by: Arnd
On Fri, 2008-10-10 at 18:43 +1100, Paul Mackerras wrote:
It's me or the patch is whitespaces damaged ?
Please don't apply Arnd's patch. As I said, all we need is this
one-line change in arch/powerpc/include/asm/systbl.h:
-SYSX_SPU(sys_select,ppc32_select,ppc_select)
On Wed, 2008-09-24 at 08:39 +0200, Arnd Bergmann wrote:
The ppc_select function was introduced in linux-2.3.48 in order to support
code confusing the legacy select() calling convention with the standard one.
Even 11 years ago, all correctly built code should not have done this and
could have
personality) {
Thanks
Halesh
-Original Message-
From: Arnd Bergmann [mailto:[EMAIL PROTECTED]
Sent: Wednesday, September 24, 2008 12:09 PM
To: [EMAIL PROTECTED]; [EMAIL PROTECTED]
Cc: [EMAIL PROTECTED]; Sadashiiv, Halesh;
linuxppc-dev@ozlabs.org
Subject: [PATCH] remove bogus ppc_select
PM
To: 'Arnd Bergmann'; [EMAIL PROTECTED]; [EMAIL PROTECTED]
Cc: [EMAIL PROTECTED]; linuxppc-dev@ozlabs.org
Subject: RE: [PATCH] remove bogus ppc_select syscall
I have tested the provided patch on PPC32 with little modifications.
Test passed on the PPC32.
Modification to Arnd's Patch
The ppc_select function was introduced in linux-2.3.48 in order to support
code confusing the legacy select() calling convention with the standard one.
Even 11 years ago, all correctly built code should not have done this and
could have easily been phased out. Nothing that was compiled later
Arnd Bergmann writes:
diff --git a/arch/powerpc/include/asm/systbl.h
b/arch/powerpc/include/asm/systbl.h
index f6cc7a4..5a69b32 100644
--- a/arch/powerpc/include/asm/systbl.h
+++ b/arch/powerpc/include/asm/systbl.h
@@ -85,7 +85,7 @@ COMPAT_SYS_SPU(gettimeofday)
On Wednesday 24 September 2008, Paul Mackerras wrote:
diff --git a/arch/powerpc/include/asm/systbl.h
b/arch/powerpc/include/asm/systbl.h
index f6cc7a4..5a69b32 100644
--- a/arch/powerpc/include/asm/systbl.h
+++ b/arch/powerpc/include/asm/systbl.h
@@ -85,7 +85,7 @@
15 matches
Mail list logo
