Re: [PATCH] sched: provide scheduler_ipi() callback in response to smp_send_reschedule()

2011-02-09 Thread Peter Zijlstra
On Wed, 2011-02-09 at 17:14 +1100, Benjamin Herrenschmidt wrote: > On Mon, 2011-02-07 at 14:54 +0100, Peter Zijlstra wrote: > > On Mon, 2011-02-07 at 10:26 +1100, Benjamin Herrenschmidt wrote: > > > You missed: > > > > > > diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c > > > in

Re: [PATCH] sched: provide scheduler_ipi() callback in response to smp_send_reschedule()

2011-02-09 Thread Benjamin Herrenschmidt
On Mon, 2011-02-07 at 14:54 +0100, Peter Zijlstra wrote: > On Mon, 2011-02-07 at 10:26 +1100, Benjamin Herrenschmidt wrote: > > You missed: > > > > diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c > > index 9813605..467d122 100644 > > --- a/arch/powerpc/kernel/smp.c > > +++ b/arc

Re: [PATCH] sched: provide scheduler_ipi() callback in response to smp_send_reschedule()

2011-02-07 Thread Peter Zijlstra
On Mon, 2011-02-07 at 10:26 +1100, Benjamin Herrenschmidt wrote: > You missed: > > diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c > index 9813605..467d122 100644 > --- a/arch/powerpc/kernel/smp.c > +++ b/arch/powerpc/kernel/smp.c > @@ -98,6 +98,7 @@ void smp_message_recv(int ms

Re: [PATCH] sched: provide scheduler_ipi() callback in response to smp_send_reschedule()

2011-02-06 Thread Benjamin Herrenschmidt
On Mon, 2011-01-17 at 12:07 +0100, Peter Zijlstra wrote: > diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c > index 68034bb..7ee0fc3 100644 > --- a/arch/powerpc/kernel/smp.c > +++ b/arch/powerpc/kernel/smp.c > @@ -128,6 +128,7 @@ static irqreturn_t call_function_action(int irq, vo

Re: [PATCH] sched: provide scheduler_ipi() callback in response to smp_send_reschedule()

2011-01-17 Thread Peter Zijlstra
On Tue, 2011-01-18 at 07:31 +1100, Benjamin Herrenschmidt wrote: > > Beware of false positive, I've used "fake" reschedule IPIs in the past > for other things (like kicking a CPU out of sleep state for unrelated > reasons). Nothing that I know that is upstream today but some of that > might come b

Re: [PATCH] sched: provide scheduler_ipi() callback in response to smp_send_reschedule()

2011-01-17 Thread Benjamin Herrenschmidt
On Mon, 2011-01-17 at 12:07 +0100, Peter Zijlstra wrote: > For future rework of try_to_wake_up() we'd like to push part of that > onto the CPU the task is actually going to run on, in order to do so we > need a generic callback from the existing scheduler IPI. > > This patch introduces such a gene

Re: [uclinux-dist-devel] [PATCH] sched: provide scheduler_ipi() callback in response to smp_send_reschedule()

2011-01-17 Thread Peter Zijlstra
On Mon, 2011-01-17 at 14:49 -0500, Mike Frysinger wrote: > On Mon, Jan 17, 2011 at 06:07, Peter Zijlstra wrote: > > Also, while reading through all this, I noticed the blackfin SMP code > > looks to be broken, it simply discards any IPI when low on memory. > > not really. see changelog of commit

Re: [uclinux-dist-devel] [PATCH] sched: provide scheduler_ipi() callback in response to smp_send_reschedule()

2011-01-17 Thread Mike Frysinger
On Mon, Jan 17, 2011 at 06:07, Peter Zijlstra wrote: > Also, while reading through all this, I noticed the blackfin SMP code > looks to be broken, it simply discards any IPI when low on memory. not really. see changelog of commit 73a400646b8e26615f3ef1a0a4bc0cd0d5bd284c. -mike ___

Re: [PATCH] sched: provide scheduler_ipi() callback in response to smp_send_reschedule()

2011-01-17 Thread David Daney
On 01/17/2011 03:07 AM, Peter Zijlstra wrote: For future rework of try_to_wake_up() we'd like to push part of that onto the CPU the task is actually going to run on, in order to do so we need a generic callback from the existing scheduler IPI. This patch introduces such a generic callback: sched

Re: [PATCH] sched: provide scheduler_ipi() callback in response to smp_send_reschedule()

2011-01-17 Thread Jesper Nilsson
On Mon, Jan 17, 2011 at 12:41:49PM +0100, Peter Zijlstra wrote: > Index: linux-2.6/arch/cris/arch-v32/kernel/smp.c > === > --- linux-2.6.orig/arch/cris/arch-v32/kernel/smp.c > +++ linux-2.6/arch/cris/arch-v32/kernel/smp.c > @@ -340,15

Re: [PATCH] sched: provide scheduler_ipi() callback in response to smp_send_reschedule()

2011-01-17 Thread Chris Metcalf
On 1/17/2011 6:41 AM, Peter Zijlstra wrote: > Index: linux-2.6/arch/tile/kernel/smp.c > === > --- linux-2.6.orig/arch/tile/kernel/smp.c > +++ linux-2.6/arch/tile/kernel/smp.c > @@ -184,12 +184,8 @@ void flush_icache_range(unsigned long

Re: [PATCH] sched: provide scheduler_ipi() callback in response to smp_send_reschedule()

2011-01-17 Thread Martin Schwidefsky
On Mon, 17 Jan 2011 12:07:13 +0100 Peter Zijlstra wrote: > I visited existing smp_send_reschedule() implementations and tried to > add a call to scheduler_ipi() in their handler part, but esp. for MIPS > I'm not quite sure I actually got all of them. > > diff --git a/arch/s390/kernel/smp.c b/ar

Re: [PATCH] sched: provide scheduler_ipi() callback in response to smp_send_reschedule()

2011-01-17 Thread Russell King - ARM Linux
On Mon, Jan 17, 2011 at 12:41:49PM +0100, Peter Zijlstra wrote: > === > --- linux-2.6.orig/arch/arm/kernel/smp.c > +++ linux-2.6/arch/arm/kernel/smp.c > @@ -575,10 +575,7 @@ asmlinkage void __exception do_IPI(struc >

Re: [PATCH] sched: provide scheduler_ipi() callback in response to smp_send_reschedule()

2011-01-17 Thread Russell King - ARM Linux
On Mon, Jan 17, 2011 at 12:07:13PM +0100, Peter Zijlstra wrote: > diff --git a/arch/alpha/kernel/smp.c b/arch/alpha/kernel/smp.c > index 42aa078..c4a570b 100644 > --- a/arch/alpha/kernel/smp.c > +++ b/arch/alpha/kernel/smp.c > @@ -587,6 +587,7 @@ handle_ipi(struct pt_regs *regs) > cas

Re: [PATCH] sched: provide scheduler_ipi() callback in response to smp_send_reschedule()

2011-01-17 Thread Peter Zijlstra
On Mon, 2011-01-17 at 12:31 +0100, Peter Zijlstra wrote: > On Mon, 2011-01-17 at 11:26 +, Russell King - ARM Linux wrote: > > Maybe remove the comment "everything is done on the interrupt return path" > > as with this function call, that is no longer the case. (Removed am33, m32r-ka, m32r, ar

Re: [PATCH] sched: provide scheduler_ipi() callback in response to smp_send_reschedule()

2011-01-17 Thread Peter Zijlstra
On Mon, 2011-01-17 at 11:26 +, Russell King - ARM Linux wrote: > On Mon, Jan 17, 2011 at 12:07:13PM +0100, Peter Zijlstra wrote: > > diff --git a/arch/alpha/kernel/smp.c b/arch/alpha/kernel/smp.c > > index 42aa078..c4a570b 100644 > > --- a/arch/alpha/kernel/smp.c > > +++ b/arch/alpha/kernel/smp

[PATCH] sched: provide scheduler_ipi() callback in response to smp_send_reschedule()

2011-01-17 Thread Peter Zijlstra
For future rework of try_to_wake_up() we'd like to push part of that onto the CPU the task is actually going to run on, in order to do so we need a generic callback from the existing scheduler IPI. This patch introduces such a generic callback: scheduler_ipi() and implements it as a NOP. I visite