Re: [PATCH] soc: fsl: Remove bogus packed attributes from qman.h

2020-09-01 Thread Herbert Xu
On Tue, Sep 01, 2020 at 04:40:16PM -0500, Li Yang wrote: > > Looks like the CAAM driver and dependent QBMAN driver doesn't support > COMPILE_TEST yet. Are you trying to add the support for it? Yes. > I think this is a valid concern that if the parent structure doesn't > meet certain alignment

Re: [PATCH] soc: fsl: Remove bogus packed attributes from qman.h

2020-09-01 Thread Li Yang
On Mon, Aug 31, 2020 at 8:57 PM Herbert Xu wrote: > > On Tue, Sep 01, 2020 at 01:50:38AM +, Leo Li wrote: > > > > Sorry for the late response. I missed this email previously. > > > > These structures are descriptors used by hardware, we cannot have _ANY_ > > padding from the compiler. The

Re: [PATCH] soc: fsl: Remove bogus packed attributes from qman.h

2020-08-31 Thread Herbert Xu
On Tue, Sep 01, 2020 at 01:50:38AM +, Leo Li wrote: > > Sorry for the late response. I missed this email previously. > > These structures are descriptors used by hardware, we cannot have _ANY_ > padding from the compiler. The compiled result might be the same with or > without the

RE: [PATCH] soc: fsl: Remove bogus packed attributes from qman.h

2020-08-31 Thread Leo Li
> -Original Message- > From: Herbert Xu > Sent: Thursday, July 30, 2020 7:53 AM > To: Leo Li ; linuxppc-dev@lists.ozlabs.org; linux-arm- > ker...@lists.infradead.org > Subject: [PATCH] soc: fsl: Remove bogus packed attributes from qman.h > > There are two __pac

Re: [PATCH] soc: fsl: Remove bogus packed attributes from qman.h

2020-08-31 Thread Herbert Xu
On Thu, Jul 30, 2020 at 10:52:59PM +1000, Herbert Xu wrote: > There are two __packed attributes in qman.h that are both unnecessary > and causing compiler warnings because they're conflicting with > explicit alignment requirements set on members within the structure. > > This patch removes them

[PATCH] soc: fsl: Remove bogus packed attributes from qman.h

2020-07-30 Thread Herbert Xu
There are two __packed attributes in qman.h that are both unnecessary and causing compiler warnings because they're conflicting with explicit alignment requirements set on members within the structure. This patch removes them both. Signed-off-by: Herbert Xu diff --git a/include/soc/fsl/qman.h